Rollup of 9 pull requests #29232
Closed
Rollup of 9 pull requests #29232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The paragraph here seemed confusing, so I reworded it. Also added another possible reason why `curl | sh` might be objectionable to users.
When reading this paragraph, the beginning Rust programmer is starting to write a Hello World program. We have just told her to name the file `main.rs`, and immediately afterward, a `hello_world.rs` is mentioned. I changed this to an unrelated filename (incidentally one that appears in this repository) to make it clear that this is just an example. Also, wording it as a declarative sentence rather than an imperative one further separates it from the Hello World instructions in this section.
…ichton I suspect this won't work on Windows, but let's be optimistic and try it before disabling.
…bnik The paragraph here seemed confusing, so I reworded it. Also added another possible reason why `curl | sh` might be objectionable to users. r? @steveklabnik
…=steveklabnik Adds the pacman git command to the high level Windows installation instructions. As the MSYS2 installation may not include Windows git on the path by default (based on the path settings of Windows users), I figured this could be a helpful inclusion.
…ichton When reading this paragraph, the beginning Rust programmer is starting to write a Hello World program. We have just told her to name the file `main.rs`, and immediately afterward, a `hello_world.rs` is mentioned. I changed this to an unrelated filename (incidentally one that appears in this repository) to make it clear that this is just an example. Also, wording it as a declarative sentence rather than an imperative one further separates it from the Hello World instructions in this section. r? @steveklabnik (Let me know if I'm sending too many PRs -- I can batch up TRPL edits, say, per chapter, if that works better. Or I can just refrain from editing TRPL as I read through it, if these are not sufficiently useful.)
|
@bors: r+ p=1 |
|
📌 Commit d941e40 has been approved by |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
⌛ Testing commit d941e40 with merge 22fcc1e... |
|
💔 Test failed - auto-win-gnu-32-nopt-t |
|
@bors: retry |
|
@bors: r- I think the failure was legitimately caused by #29151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
curl | shdisclaimer in TRPL §2.1 #29170, Add example for installing git in MSYS2 #29180, Remove reference tohello_world.rsin TRPL §2.2 #29193, Fix some typos in TRPL #29207, Remove obsolete note aboutUnsafeCell's fields #29213, Fix doc sample for Cursor #29224, Add missing "to" in Rustonomicon Atomics. #29230