Skip to content

Fix some typos in TRPL #29207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2015
Merged

Fix some typos in TRPL #29207

merged 2 commits into from
Oct 23, 2015

Conversation

ykomatsu
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@@ -2057,7 +2057,7 @@ so. This can be a little clumsy, especially if you intend for the program to
be used in shell scripts.

So let's start by adding the flags. Like before, we need to tweak the usage
string and add a flag to the Option variable. Once were done that, Getopts does the rest:
string and add a flag to the Option variable. Once we're done that, Getopts does the rest:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may actually want to be "we've" ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @alexcrichton and @steveklabnik.

I corrected this.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 22, 2015

📌 Commit f609d17 has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Oct 22, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Oct 22, 2015
bors added a commit that referenced this pull request Oct 22, 2015
@alexcrichton alexcrichton merged commit f609d17 into rust-lang:master Oct 23, 2015
@ykomatsu ykomatsu deleted the trpl branch October 23, 2015 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants