-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Fix some typos in TRPL #29207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some typos in TRPL #29207
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@@ -2057,7 +2057,7 @@ so. This can be a little clumsy, especially if you intend for the program to | |||
be used in shell scripts. | |||
|
|||
So let's start by adding the flags. Like before, we need to tweak the usage | |||
string and add a flag to the Option variable. Once were done that, Getopts does the rest: | |||
string and add a flag to the Option variable. Once we're done that, Getopts does the rest: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this may actually want to be "we've" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @alexcrichton and @steveklabnik.
I corrected this.
@bors: r+ rollup |
📌 Commit f609d17 has been approved by |
No description provided.