[Forwardport] Correct return type of methods and typo correction. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when they shouldn't
…tification and Release Notification window is opened
… when they shouldn't
… product with required custom option
… product with required custom option
…bsites - Disable fields for locked attributes
… contains double quote "
… contains double quote "
- Added test for customer view
- Fixed some conventions and assert success message seen. Also check that there is not a 404 error
- Put elements in more appropriate sections
- Move elements to the correct section and remove adding the product to the category
- Updated test to be more specific in selectors and name steps correctly
- Change the group value back to the correct name
- Move part of the code from the action group to the test page to make the action group more reuseable
…ct with product name MC-146: Guest customer should be able to advance search grouped product with product sku MC-282: Guest customer should be able to advance search grouped product with product description MC-283: Guest customer should be able to advance search grouped product with product short description MC-284: Guest customer should be able to advance search grouped product with product price - updated mftf tests
…gurable product - Parameterized selectors and reduced redundancy
…count down as more characters are entered - Stabilize builds
… & category page of Hot Sel magento#15896 - Merge Pull Request magento#15896 from chirag-wagento/magento2:2.3-develop-PR-port-15893 - Merged commits: 1. a851540
…n page magento#15884 - Merge Pull Request magento#15884 from dankhrapiyush/magento2:2.3-develop-PR-15365 - Merged commits: 1. c44f1f8
…tions for better performance magento#16128
…rvice\V1\ShipmentCreateTest::testInvoke magento#15974
…der' button new behaviour. magento#16006
[Team 3] Improving dev experience for Products widget
…eam3-delivery-bug-fixes
…2_2.3-upgrade-changes
- merged latest code from mainline branch
[borg] MAGETWO-91608: SEO-friendly URL for category page not working
- merged latest code from mainline branch
Accepted Public Pull Requests: - magento#16103: [Forwardport] fixed word typo (by @hitesh-wagento) - magento#16117: Captcha: Added unit test for CheckRegisterCheckoutObserver (by @rogyar) - magento#16121: [Forwardport] Improve retrieval of first array element (by @thomas-blackbird) - magento#16128: [Forwardport] Disabling sorting in glob and scandir functions for better performance (by @lfluvisotto) - magento#16036: [Forwardport] Fix issue magento#15832 (by @chirag-wagento) - magento#15975: [Forwardport] magento#15308 removed extraneous margin (by @chirag-wagento) - magento#15982: Fix Magento\Sales\Service\V1\ShipmentGetTest::testShipmentGet (by @slackerzz) - magento#15974: Fix magento/inventory#1339 issue - Fix \Magento\Sales\Service\V1\ShipmentCreateTest::testInvoke (by @slackerzz) - magento#16006: 1334: CreateOrderBackendTest rework to support MSI 'Reorder' button new behaviour. (by @nmalevanec) - magento#15685: Fulltext replacement with like condition (by @phoenix128) Fixed GitHub Issues: - magento#15832: No button-primary__font-weight (reported by @DanielRuf) has been fixed in magento#16036 by @chirag-wagento in 2.3-develop branch Related commits: 1. d7e77e6 2. c4de267 - magento#15308: extraneous margins on product list and product list items (reported by @DanielRuf) has been fixed in magento#15975 by @chirag-wagento in 2.3-develop branch Related commits: 1. eee2e7c - magento#1350: Install Quits on install on Magento_Catalog (reported by @Zaylril) has been fixed in magento#15982 by @slackerzz in 2.3-develop branch Related commits: 1. 9e5757d 2. 1555b96 3. 039e71c - magento#680: More settings for image storage (reported by @bubach) has been fixed in magento#16006 by @nmalevanec in 2.3-develop branch Related commits: 1. 0501e17 2. 731b58f 3. 7c3d53f 4. 0d06ad8 - magento#1221: "Uncaught TypeError: Event.observe is not a function" In Version 0.74.0-beta6 (reported by @RisingRavi) has been fixed in magento#15685 by @phoenix128 in 2.3-develop branch Related commits: 1. 7259c4b
…eam3-delivery-bug-fixes
…-pdp [borg] MAGETWO-91595: Image doesn't load on frontend PDP if the product name contains double quote "
…eam3-delivery-bug-fixes
…ug-fixes [Team 3] Bug Fixes
…2_2.3-upgrade-changes
…pgrade-changes [borg] MAGETWO-85929: Create and configure deployment plans to test publication changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#15993
Description
Correct return type of methods and change return type.
Fixed Issues (if relevant)
N/A
Manual testing scenarios
N/A
Contribution checklist