Adjust test cases for fixed enum case rename #1471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 9, 2024
hamishknight
approved these changes
Jun 10, 2024
Comment on lines
1220
to
+1224
| newName: "newName(_:)", | ||
| expectedPrepareRenamePlaceholder: "myCase", | ||
| expectedPrepareRenamePlaceholder: "myCase(label:)", | ||
| expected: """ | ||
| enum MyEnum { | ||
| case newName(_ label: String) |
There was a problem hiding this comment.
Should we be dropping the label completely here?
There was a problem hiding this comment.
I think it’s valuable to keep it as an internal label, similar to what we do for function completion (and yes, also easier to implement 🙈)
Enum case rename is fixed by changes in sourcekitd. We can remove our workaround for the issue and add test cases that test the rename behavior. Fixes swiftlang#1228 rdar://127646036
ahoppen
force-pushed
the
enum-case-rename
branch
from
bd7e9e3 to
7a61ff9
Compare
|
@swift-ci Please test |
|
swiftlang/swift-syntax#2678 @swift-ci Please test Windows |
|
swiftlang/swift-syntax#2678 @swift-ci Please test macOS |
|
swiftlang/swift-syntax#2678 @swift-ci Please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to swiftlang/swift-syntax#2678 and swiftlang/swift#74241
Enum case rename is fixed by changes in sourcekitd. We can remove our workaround for the issue and add test cases that test the rename behavior.
Fixes #1228
rdar://127646036