Fix renaming enum case parameters with unnamed associated arguments #74241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
bnbarham,
hamishknight,
rintaro and
CodaFi
as code owners
This was referenced Jun 9, 2024
|
swiftlang/swift-syntax#2678 @swift-ci Please smoke test |
hamishknight
approved these changes
Jun 10, 2024
We treated enum case parameters the same way as function parameters and weren’t considering that they can be unlabeled. That caused us to insert eg. `_ ` in front of the case’s type, producing `case myCase(_ String)`, which is invalid. When we are inside an enum case parameter and the parameter label is empty, treat it the same as a function call, which will leave the label untouched if it isn’t modified and insert a label including a colon if a new label is introduced. swiftlang/sourcekit-lsp#1228
ahoppen
force-pushed
the
enum-case-rename
branch
from
8058abc to
155773c
Compare
|
swiftlang/swift-syntax#2678 @swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to swiftlang/swift-syntax#2678 and swiftlang/sourcekit-lsp#1471
We treated enum case parameters the same way as function parameters and weren’t considering that they can be unlabeled. That caused us to insert eg.
_in front of the case’s type, producingcase myCase(_ String), which is invalid. When we are inside an enum case parameter and the parameter label is empty, treat it the same as a function call, which will leave the label untouched if it isn’t modified and insert a label including a colon if a new label is introduced.swiftlang/sourcekit-lsp#1228