Fix renaming enum case parameters with unnamed associated arguments #2678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 9, 2024
hamishknight
approved these changes
Jun 10, 2024
| @@ -102,6 +102,12 @@ public struct DeclNameLocation: Equatable { | |||
| /// The parameter of a function declaration, like `func foo(a b: Int)` | |||
| case parameters([Argument]) | |||
|
|
|||
| /// An enum ase declaration like `case myCase(label: String)`. | |||
There was a problem hiding this comment.
Suggested change
| /// An enum ase declaration like `case myCase(label: String)`. | |
| /// An enum case declaration like `case myCase(label: String)`. |
There was a problem hiding this comment.
I swear I made this type 10 times while writing the PR. One of them seems to have slipped through 😆
We treated enum case parameters the same way as function parameters and weren’t considering that they can be unlabeled. That caused us to insert eg. `_ ` in front of the case’s type, producing `case myCase(_ String)`, which is invalid. Report `enumCaseParameters` as a special parameter kind so that sourcekitd can work with it. swiftlang/sourcekit-lsp#1228
ahoppen
force-pushed
the
enum-case-rename
branch
from
91c6bbe to
b2180c4
Compare
|
swiftlang/swift#74241 @swift-ci Please test Windows |
This was referenced Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to and swiftlang/swift#74241 and swiftlang/sourcekit-lsp#1471
We treated enum case parameters the same way as function parameters and weren’t considering that they can be unlabeled. That caused us to insert eg.
_in front of the case’s type, producingcase myCase(_ String), which is invalid. ReportenumCaseParametersas a special parameter kind so that sourcekitd can work with it.swiftlang/sourcekit-lsp#1228