Tweak SwiftUI tutorial #240
Conversation
0xTim
requested review from
alexandersandberg,
daveverwer,
dempseyatgithub,
kaishin,
krstnfx,
mschinis,
shahmishal,
TimTr,
twostraws and
tomerd
as code owners
There was a problem hiding this comment.
Excellent additions, especially the screenshots.
I've optimized the images for ~50% reduction in size, which is significant enough to warrant replacing the ones in the PR. The optimized images can be downloaded here: optimized-images.zip.
My 2 cents regarding the gif: videos tend to be smaller, better quality, and provide more control over playback, including the ability to pause them for preference or accessibility reasons. If you still have the source video around it might be beneficial to include it in the PR to keep the option to switch open before merging to main.
|
IIRC we had issues embedding the video in the markdown for another PR so switched to a Gif? Can anyone remember? |
I wasn't aware. I'd be happy to take a look into it if you include the source video. |
|
@kaishin here you go, thanks! app-demo.mov |
|
@0xTim I'll get around this later today. Do you want me to replace the images as well and push to this branch? |
|
@kaishin if you could that would be awesome! 🙌 |
* Update landing page content (#127) * First pass at the new Getting Started page (#174) * Adding Getting Started tutorial for SwiftUI / iOS 16. (#185) * Add data file with items for "Go Further" section (#184) * Add cli and library getting started guides (#192) * Getting started tweaks (#208) * Rename Markdown files to have an `.md` extension. (#209) * Fix typo (#214) * Update getting started page layout (#204) * Add documentation information to Getting Started (#226) * Add Vapor Getting Started guide (#229) * Update content-improvments branch per feedback (#244) * Tweak SwiftUI tutorial (#240) * Add TSPL Go Further section and resource thumbnails (#227) * Improve 'Why Swift?' section on landing page (#252) * Replace Go Further item for advanced String Under The Hood blog post with item for Structures and Classes chapter in TSPL (#254) * Update landing page layout (#267) * Link to developer.apple.com from apple use case (#291) * Smaller landing page changes on content improvements branch (#294) * Update Go Further section (#300) * Update icons and placeholder image (#301) * Improve description of use cases and getting started guides (#304) * POC: Feature random code snippet on landing page (#303) * New “Swift is…” and About page copy (#336) * Move link to A Swift Tour to the Use Cases section (#329) * Add consistent download section to start and end of each guide (#351) * Add a new install page, update the download page, and move release yml files into one file. (#310) * Update navigation for install page (#355) * Update cli and library getting started guides (#357) * Content improvement guide updates (#373) * Add value and reference types article (#377) * Add some showcase snippets (#371) * Resolve issue with Red Hat download links (#379) * Add Info about Scoop for Windows install page (#382) --------- Co-authored-by: Alexander Sandberg <[email protected]> Co-authored-by: Paul Hudson <[email protected]> Co-authored-by: James Dempsey <[email protected]> Co-authored-by: tomer doron <[email protected]> Co-authored-by: Dave Verwer <[email protected]> Co-authored-by: Tim Condon <[email protected]> Co-authored-by: Max Desiatov <[email protected]> Co-authored-by: Mishal Shah <[email protected]> Co-authored-by: AG <[email protected]> Co-authored-by: Ted Kremenek <[email protected]>
Adds screenshots the SwiftUI Tutorial.
I've also updated the code blocks so we get syntax highlighting. I've left the 1st person text as we don't have a style guide (nor do I think we should have one) and it reads well