[CI/Build] Disable SiluMul NVFP4 quant fusion tests #24121
Conversation
Signed-off-by: Matthew Bonanni <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request disables the test_silu_nvfp4_quant_fusion test to fix a CI failure. While this resolves the immediate issue by commenting out the test, it also removes test coverage for this feature on platforms where it should be running. I've suggested an alternative approach that fixes the CI failure without disabling the test, ensuring test coverage is maintained.
| - pytest -v -s tests/kernels/quantization/test_cutlass_scaled_mm.py -k 'fp8' | ||
| - pytest -v -s tests/kernels/quantization/test_nvfp4_quant.py | ||
| - pytest -v -s tests/kernels/quantization/test_silu_nvfp4_quant_fusion.py | ||
| # - pytest -v -s tests/kernels/quantization/test_silu_nvfp4_quant_fusion.py |
There was a problem hiding this comment.
Commenting out this test run disables it for all platforms, including those where it is intended to run. This results in a loss of test coverage for the silu_nvfp4_quant_fusion feature.
A better approach is to allow pytest to succeed even when no tests are collected. If the project uses pytest version 7.0 or newer, you can add the --allow-no-tests flag. This will cause pytest to exit with code 0 (success) instead of 5 when no tests are found, resolving the CI issue without sacrificing test coverage on supported platforms.
If using an older version of pytest, other options could be considered, such as wrapping the command in shell logic to ignore exit code 5.
- pytest -v -s --allow-no-tests tests/kernels/quantization/test_silu_nvfp4_quant_fusion.py
There was a problem hiding this comment.
@MatthewBonanni that sounds like a better option, could we add --allow-no-tests with a comment?
There was a problem hiding this comment.
@njhill pytest doesn't recognize --allow-no-tests as an option (I'm on 8.4.1) and I can't find it documented online anywhere. I think gemini may have hallucinated that. There are definitely other workarounds though, like I could add a dummy test that passes or something
MatthewBonanni
changed the title
Signed-off-by: Matthew Bonanni <[email protected]>
|
Thanks @MatthewBonanni. What is the plan for uncommenting these then? Just don't want it to get forgotten... |
|
@njhill update: this has been reverted in that PR, thanks @elvischenv! |
* 'main' of https://github.com/845473182/vllm: (457 commits) [BugFix] Fix routed_scaling_factor double mul for dots1 and glm4 MoE models (vllm-project#24132) [Misc] Add check for dual_chunk_attention (vllm-project#24070) [Doc]: fix typos in Python comments (vllm-project#24115) [Doc]: fix typos in Python comments (vllm-project#24093) [Compile] Fix Compile Warning for `w4a8_mm_entry.cu` (vllm-project#23660) fix some typos (vllm-project#24071) [V1] Wrapper which plumbs request-level logits processors into vLLM batch-level logits processing (vllm-project#23656) Upgrade xgrammar to 0.1.23 (vllm-project#22988) Update release pipeline post PyTorch 2.8.0 update (vllm-project#24073) [XPU] Fix the bug of LoRA logits on the XPU platform (vllm-project#24081) [CI/Build] Disable SiluMul NVFP4 quant fusion tests (vllm-project#24121) [Bug] R1 Accuracy: Fix `routed_scaling_factor` Double Mul Issue (vllm-project#24119) [AMD][Kernel][Bugfix] Cast offsets tensor bn to tl.int64 to avoid GPU segfault (vllm-project#23692) [CI] Enable all hf transformers baselines in test_hybrid (vllm-project#23936) [Log] Only Print Profiler Results on Rank 0 (vllm-project#23370) Fix weights loading for Apertus (vllm-project#24100) [Metrics] Deprecate TPOT in favor of ITL (vllm-project#24110) [Bugfix] Fix packed_factor missing attribute error (vllm-project#23902) Run ruff format on a few files. (vllm-project#24075) [Bugfix] Fix transform_config parsing in Compressed Tensors (vllm-project#23945) ...
Signed-off-by: Matthew Bonanni <[email protected]> Signed-off-by: 子悬 <[email protected]>
…ject#24121)" This reverts commit 2fd1a40. Signed-off-by: elvischenv <[email protected]>
Signed-off-by: Matthew Bonanni <[email protected]>
Signed-off-by: Matthew Bonanni <[email protected]>
3 participants
Purpose
Quick follow on to #23959 to disable
test_silu_nvfp4_quant_fusionandtest_silu_mul_quant_fusionin buildkite, fixing error 5 (which arises since no tests from this file are run)Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.