[BugFix] Fix routed_scaling_factor double mul for dots1 and glm4 MoE models #24132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Deepseek fix landed in #24119. This is the same fix for Dots1 and GLM4 moe models as they both have double mult issue:
vllm/vllm/model_executor/models/dots1.py
Line 163 in 98aee61
vllm/vllm/model_executor/models/glm4_moe.py
Line 189 in 98aee61
Test Plan
gsm8k
Test Result
Unable to test glm4 due to hang (#24133)
dots1
Before:
After PR:
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.