update Complex Options ident block per #1150
#1157
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removing info past new `T>...` about `ident` as anyone looking to migrate from this point on should be on webpack >= v2.2.1 but leaving the tip just to clarify for any curious during migration. thoughts @michael-ciniawsky & @skipjack?
|
will rebase if necessary for silly extra commit, just lemme know. otherwise this closes #1154 |
|
@rouzbeh84 #1154 is a pull request that should close #1150, does this add something to #1154? |
|
@rouzbeh84 closing but feel free to re-open if you want to tweak something that was added in #1154 |
|
nope sorry, didn't see there was a PR on it already. all good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per #1150 removing info past new
T>...aboutidentas anyone looking to migrate from this point on should be on webpack >= v2.2.1 but leaving the tip just to clarify for any curious during migration.thoughts @michael-ciniawsky & @skipjack?