Remove Obsolete ident Section
#1154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a warning instead that points to the v2 version in which this option became obsolete. We could also reference an older version of the docs if necessary for people to jump back to, though that may be overkill. Fixes #1150
michael-ciniawsky
approved these changes
Apr 25, 2017
content/guides/migrating.md
Outdated
|
|
||
| `require("some-loader??by-ident!resource")` | ||
|
|
||
| ``` js |
There was a problem hiding this comment.
Maybe move this example under the note, so folks know how it looked like :). Does ```diff work on the docs page ?
webpack.config.js
{
test: /\.ext/
use: {
loader: '...',
options: {
- ident: 'id',
fn: () => require('./foo.js')
}
}
}There was a problem hiding this comment.
Does ```diff work on the docs page ?
It does, I'll update.
|
@michael-ciniawsky done 👍
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a warning instead that points to the v2 version in which this option
became obsolete. We could also reference an older version of the docs if
necessary for people to jump back to, though that may be overkill.
Fixes #1150