Skip to content

#14 basic mempool implementation #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 46 commits into from
Jul 17, 2019
Merged

#14 basic mempool implementation #65

merged 46 commits into from
Jul 17, 2019

Conversation

iltoga
Copy link
Contributor

@iltoga iltoga commented Jul 16, 2019 •
edited
Loading

Description

First implementation of the mempool logic.

Breakdown

  • mempoolCoreService: service layer where most of the business logic resides: get/add/delete/select mempool transactions
  • mempoolQuery: db repository layer where all db queries are
  • mempool.proto: mempool model
  • blockchainProcessor: added tx selection from mempool when generating new blocks and logic to include transactions (tx payoload) in a block
  • blockCoreService: added method to remove (delete from db) mempool tx once the relative block is pushed

Reference Issue

Close #14

Step to Test (optional)

  • just run normal test suite with "go test ./..." from project root

stefano galassi and others added 30 commits July 9, 2019 12:38
#20 added timestamp to transaction table and simplified mempool table…
ecbbb0f 
… structure
Merge branch 'develop' into 14-basic-mempool-implementation
7898dbe
#14 WIP: added query repo and service for mempool
b755b34
#14 - resolved conflicts with develop branch
cd87a2f
resolved conflicts
e297841
recompiled protos
0273484
Merge branch 'develop' into 14-basic-mempool-implementation
21167c8
#14 - WIP: started implementing mempoolService
5ede6ec
#14 - WIP: still implementing mempoolservice and mempoolQuery
66d6d8c
Merge branch 'develop' into 14-basic-mempool-implementation
2945bf0
fixed GetMempoolTransaction query
076e4ac
Merge branch 'develop' into 14-basic-mempool-implementation
7c1a46b
@andy-shi88
#6 add executeTransactionStatements method to handle multiple query s…
e1fe55c 
…tatement
@andy-shi88
#6 add get transaction bytes and parse transaction bytes method
0cc6f62
@andy-shi88
#6 update transaction model
6a202a2
@andy-shi88
Merge branch 'develop' of github.com:zoobc/zoobc-core into 6-transact…
e1ba15c 
…ion-implementation
@andy-shi88
#6 handle no-recipient get transaction bytes
6b8e479
@andy-shi88
#6 update doc : add transaction bytes structure
0b8b3f8
merged develop and resolved conflicts
5afdcbe 
implmentation  of mempoolCoreService (still to be tested)
implementation of mempoolCoreService
a85a70c
Merge branch 'develop' into 14-basic-mempool-implementation
f0100da
merged develop into branch
35f21f8
#14 tested GetMempoolTransactions, AddMempoolTransaction, RemoveMempo…
b26f70e 
…olTransaction
#14 completed testing mempool service
ec28914
Merge branch 'develop' into 14-basic-mempool-implementation
80fcaa4
merged develop into branch
b1843ea
start integrating mempool service into main process and blockchainpro…
7c94000 
…cessor
merge develop into branch
81949bb
added tx timeout (mempool tx expiration time)
aee3b67
added getamount and getsize to transaction,TypeAction
7491477 
added logic to pass in payload to blockchainprocessor when generating blocks
@iltoga iltoga self-assigned this Jul 16, 2019
stefano galassi added 3 commits July 16, 2019 11:11
fixed some lint issues
b02633f
refactored part of mempoolService: moved removemempooltransactions to…
e3e9054 
… blockservice because part of PushBlock method

fixed unit tests
added to transactionUtil function to calculate transaction ID from transaction model
refactored old unit tests (64 bytes signature instead of 256)
4cdbb06 
added tests for GetTransactionID
andy-shi88
andy-shi88 reviewed Jul 17, 2019
View reviewed changes
stefano galassi added 2 commits July 17, 2019 12:28
merged develop with branch
53e7d7c 
fixed parse transaction bytes: added checks if bytes we are parsing are formally correct while reading them
merged develop into branch
354e869
@iltoga iltoga requested a review from astaphobia July 17, 2019 04:38
stefano galassi added 3 commits July 17, 2019 14:34
@andy-shi88 andy-shi88 mentioned this pull request Jul 17, 2019
Merged
12 tasks
@andy-shi88
Copy link
Contributor

is this PR final? need to merge this one, I need some functionality that's already here for PR: #74

@astaphobia astaphobia merged commit 317012a into develop Jul 17, 2019
@astaphobia astaphobia deleted the 14-basic-mempool-implementation branch July 17, 2019 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-shi88 andy-shi88 andy-shi88 left review comments

@astaphobia astaphobia astaphobia approved these changes

@sukrawidhyawan sukrawidhyawan sukrawidhyawan approved these changes

@capt4ce capt4ce Awaiting requested review from capt4ce

@komodo2662 komodo2662 Awaiting requested review from komodo2662

Assignees

@iltoga iltoga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tech: basic mempool implementation. Transaction validation and selection for block creation process
4 participants
@iltoga @andy-shi88 @astaphobia @sukrawidhyawan