55 genesis txs #74
Merged
55 genesis txs #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
ready for review 👍 |
|
sorry, put back to WIP, will need to update some tests. |
astaphobia
approved these changes
Jul 17, 2019
astaphobia
approved these changes
Jul 18, 2019
astaphobia
approved these changes
Jul 18, 2019
capt4ce
reviewed
Jul 18, 2019
common/query/accountBalanceQuery.go
Outdated
| @@ -19,6 +19,8 @@ type ( | |||
| GetAccountBalanceByAccountID() string | |||
| UpdateAccountBalance(fields, causedFields map[string]interface{}) (str string, args []interface{}) | |||
| InsertAccountBalance(accountBalance *model.AccountBalance) (str string, args []interface{}) | |||
| AddAccountBalance(balance int64, causedFields map[string]interface{}) (str string, args []interface{}) | |||
| AddAccountUnconfirmedBalance(balance int64, causedFields map[string]interface{}) (str string, args []interface{}) | |||
There was a problem hiding this comment.
Don't we use SpendableBalance?
common/query/accountBalanceQuery.go
Outdated
| q.TableName, balance, balance), []interface{}{causedFields["account_id"]} | ||
| } | ||
|
|
||
| func (q *AccountBalanceQuery) AddAccountUnconfirmedBalance(balance int64, causedFields map[string]interface{}) ( |
There was a problem hiding this comment.
don't we use SpendableBalance?
There was a problem hiding this comment.
ah right, updating
capt4ce
approved these changes
Jul 18, 2019
iltoga
approved these changes
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add genesis txs to genesis block.
Breakdown
GetTransactionTypenot injecting complete depAccountBalanceQuerybalance not update.breakdown after merge from develop
if err != nillogic flawReference Issue
Close #55
may affect #14
need #65 to be merged for some block fields and transaction save method.
Step to Test (optional)
go test ./..go run main.goaccount balance should be distributed according to genesis txs