Skip to content

[Backport] Add 'const' type support to layout arguments #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 111 commits into from
Closed

[Backport] Add 'const' type support to layout arguments #2

wants to merge 111 commits into from

Conversation

IgorVitol
Copy link
Owner

Original Pull Request

magento#15058

Description

For now in Magento we can not use xsi:type="const" in layout arguments. But it looks like such ability can be very useful. Moreover such code already exists in Magento core, we just need to include/enable it.

Manual testing scenarios

  1. Add argument with "const" type to any block via layout arguments. For example like this:
<referenceBlock name="product.info.sku">
    <arguments>
        <argument name="my_const_value" xsi:type="const">Magento\Catalog\Api\Data\ProductAttributeInterface::ENTITY_TYPE_CODE</argument>
    </arguments>
</referenceBlock>
  1. Verify that it is correctly passed to block constructor. Like here: http://prntscr.com/jf7qa0

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

gwharton and others added 30 commits May 7, 2018 18:30
Correct missing commits for magento#10210
9a95dae 
Add missing commits for \app\code\Magento\Sales\Model\Order\Email\Sender\OrderSender.php
@magento-engcom-team
ENGCOM-1465: [2.1-develop][Backport] Transport variable can not be al…
3309052 
…tered in email_invoice_set_template_vars_before Event magento#15038

 - Merge Pull Request magento#15038 from gwharton/magento2:2.1-develop-10210
 - Merged commits:
   1. 9a95dae
@rogyar
Add statement to 'beforeSave' method to allow app:config:import
a7e8b71
@magento-engcom-team
ENGCOM-1475: [Backport] Add statement to 'beforeSave' method to allow…
ba2cbf7 
… app:config:import magento#15066

 - Merge Pull Request magento#15066 from rogyar/magento2:2.1-config-import-country-card
 - Merged commits:
   1. a7e8b71
@rogyar
JSCS fix: empty line above ‘return’ is required
78a2e51
@magento-engcom-team
ENGCOM-1491: [Backport] Fix infinite checkout loader on a script error …
4f1e677 
…magento#15091

 - Merge Pull Request magento#15091 from rogyar/magento2:2.1-checkout-loader-fix
 - Merged commits:
   1. 78a2e51
@rogyar
Changed return type of addToCartPostParams to array
7104b91
@rogyar
Duplicate Order Confirmation Emails for PayPal Express checkout order
0799789
@magento-engcom-team
ENGCOM-1492: [Backport] Duplicate Order Confirmation Emails for PayPa…
3380ce4 
…l Express checkout order magento#15094

 - Merge Pull Request magento#15094 from rogyar/magento2:2.1-paypal-duplicate-email-fix
 - Merged commits:
   1. 0799789
Removed extra spaces from language file
21bd884
@magento-engcom-team
ENGCOM-1494: [Backport] Removed extra spaces from language file magen…
1a50b07 
…to#15099

 - Merge Pull Request magento#15099 from sergiy-v/magento2:feature/catalog-inventory-language-file-fix
 - Merged commits:
   1. 21bd884
stripped filter value
ceb486d
@magento-engcom-team
ENGCOM-1496: [Backport] Changed return type of addToCartPostParams to…
d75f71b 
… array magento#15093

 - Merge Pull Request magento#15093 from rogyar/magento2:2.1-product-list-return-hint-fix
 - Merged commits:
   1. 7104b91
@magento-engcom-team
ENGCOM-1497: [Backport] FIX for issue#14855 - Adding an * to do a cus…
4d21774 
…tomer search magento#15101

 - Merge Pull Request magento#15101 from sergiy-v/magento2:feature/2.1-asterisk-on-grid-search
 - Merged commits:
   1. ceb486d
move customer.account.dashboard.info.extra block to contact information
9a1d9de
Removed extra close tag
8823f96
Change 'Update'-button visibility on change qty event
45b8f87
Renamed config setting to represent what it actually does
841b322
@magento-engcom-team
ENGCOM-1498: [Backport] Removed extra close tag magento#15103
f6c7d20 
 - Merge Pull Request magento#15103 from sergiy-v/magento2:feature/2.1-magento-review-view-template-remove-extra-tag
 - Merged commits:
   1. 8823f96
changed path for templates
20993c1
Fix typo in less button definition
12bf629
fixed typos in less files
e2f70fe
@magento-engcom-team
ENGCOM-1499: [Backport] Change 'Update'-button visibility on change q…
713e1d2 
…ty event magento#15104

 - Merge Pull Request magento#15104 from sergiy-v/magento2:feature/2.1-minicart-update-button
 - Merged commits:
   1. 45b8f87
@magento-engcom-team
ENGCOM-1500: [Backport] use 'Module_Name::template/path' format inste…
fb082c7 
…ad of using template/path magento#15106

 - Merge Pull Request magento#15106 from sergiy-v/magento2:feature/2.1-magento-review-renderer-path
 - Merged commits:
   1. 20993c1
@magento-engcom-team
ENGCOM-1502: [Backport] Fix typo in less button definition magento#15108
7b63e4a 


 - Merge Pull Request magento#15108 from sergiy-v/magento2:feature/2.1-buttons-less-typo
 - Merged commits:
   1. 12bf629
@magento-engcom-team
ENGCOM-1503: [Backport] Fixed typos in .less files magento#15109
ba9e51c 
 - Merge Pull Request magento#15109 from sergiy-v/magento2:feature/2.1-port-15023
 - Merged commits:
   1. e2f70fe
@magento-engcom-team
ENGCOM-1504: [Backport] 'Add Block Names to Hints' config setting to …
ded7178 
…represent what it actually does magento#15105

 - Merge Pull Request magento#15105 from sergiy-v/magento2:feature/2.1-block-class-type-config-label
 - Merged commits:
   1. 841b322
ENGCOM-1504: [Backport] "Add Block Names to Hints" config setting to …
32f4cbd 
…represent what it actually does magento#15105
ENGCOM-1503: [Backport] Fixed typos in .less files magento#15109
2f8e5b7
ENGCOM-1502: [Backport] Fix typo in less button definition magento#15108
b2c16dc
magento-engcom-team and others added 28 commits May 16, 2018 01:13
@magento-engcom-team
ENGCOM-1566: Remove unused namespace from ui export magento#15240
8c1db59 
 - Merge Pull Request magento#15240 from Atwix/magento2:remove-unused-namespace-from-ui-export
 - Merged commits:
   1. 3d3f922
@magento-engcom-team
ENGCOM-1567: [Backport] Fix typo in design rule hint message magento#…
c2ce873 
…15233

 - Merge Pull Request magento#15233 from VitaliyBoyko/magento2:fix/design-rule-typo
 - Merged commits:
   1. 9994410
@magento-engcom-team
ENGCOM-1568: [Backport] Add missing translations in Magento_UI magent…
df1bf21 
…o#15234

 - Merge Pull Request magento#15234 from VitaliyBoyko/magento2:11440-Add-missing-translations-in-Magento_UI
 - Merged commits:
   1. 0c2e496
@magento-engcom-team
ENGCOM-1569: [Backport] Fixed double space typo magento#15235
868ca56 
 - Merge Pull Request magento#15235 from VitaliyBoyko/magento2:11569-Fixed_double_space_typo
 - Merged commits:
   1. d41e2c5
@magento-engcom-team
ENGCOM-1570: [Backport] Fixed php notice when invalid ui_component co…
8136458 
…nfig is used magento#15238

 - Merge Pull Request magento#15238 from VitaliyBoyko/magento2:Fixed-php-notice-when-invalid-ui_component-config-is-used
 - Merged commits:
   1. 5980670
@magento-engcom-team
ENGCOM-1571: [Backport] Changed constructor typo in Javascript class m…
0de8750 
…agento#15237

 - Merge Pull Request magento#15237 from VitaliyBoyko/magento2:Changed-constructor-typo-in-Javascript-class
 - Merged commits:
   1. 76c4463
ENGCOM-1566: Remove unused namespace from ui export magento#15240
d38c545
ENGCOM-1554: [Backport 2.1] Fix for displaying a negative price for a…
938dba1 
… custom option magento#15203
ENGCOM-1536: Fixed format of purchase date in order grid again. magen…
bf0b5df 
…to#15176
@magento-engcom-team
🔃 [EngCom] Public Pull Requests - 2.1-develop
f95b59f 
Accepted Public Pull Requests:
 - magento#15240: Remove unused namespace from ui export (by @yuriyDne)
 - magento#15203: [Backport 2.1] Fix for displaying a negative price for a custom option (by @dverkade)
 - magento#15176: Fixed format of purchase date in order grid again. (by @hostep)
ENGCOM-1565: [Backport] Fixed datepicker problem when using non en-US…
611b209 
… locale. magento#15222
ENGCOM-1564: [Backport] Translate action Label magento#15221
8886c04
@magento-engcom-team
🔃 [EngCom] Public Pull Requests - 2.1-develop
4586128 
Accepted Public Pull Requests:
 - magento#15222: [Backport] Fixed datepicker problem when using non en-US locale. (by @rogyar)
 - magento#15221: [Backport] Translate action Label (by @rogyar)
@VladimirZaets
ENGCOM-1528: [Backport] Default schedule config for sitemap_generate …
b25a3e0 
…job added magento#15159
@magento-engcom-team
🔃 [EngCom] Public Pull Requests - 2.1-develop
71d4467 
Accepted Public Pull Requests:
 - magento#15159: [Backport] Default schedule config for sitemap_generate job added (by @rogyar)


Fixed GitHub Issues:
 - magento#5768: Magento 2.0.7 XML sitemap is not generated by schedule (reported by @dexterityzx) has been fixed in magento#15159 by @rogyar in 2.1-develop branch
   Related commits:
     1. f4ae0e3
@VladimirZaets
ENGCOM-1571: [Backport] Changed constructor typo in Javascript class m…
816fa8c 
…agento#15237
@VladimirZaets
ENGCOM-1569: [Backport] Fixed double space typo magento#15235
218f204
@magento-engcom-team
🔃 [EngCom] Public Pull Requests - 2.1-develop
cecccb0 
Accepted Public Pull Requests:
 - magento#15237: [Backport] Changed constructor typo in Javascript class (by @VitaliyBoyko)
 - magento#15235: [Backport] Fixed double space typo (by @VitaliyBoyko)
ENGCOM-1570: [Backport] Fixed php notice when invalid ui_component co…
1e3f153 
…nfig is used magento#15238
ENGCOM-1568: [Backport] Add missing translations in Magento_UI magent…
95477e3 
…o#15234
ENGCOM-1567: [Backport] Fix typo in design rule hint message magento#…
9af1689 
…15233
@VladimirZaets
Fix copyright
3c2a747
@magento-engcom-team
🔃 [EngCom] Public Pull Requests - 2.1-develop
e0c7fae 
Accepted Public Pull Requests:
 - magento#15238: [Backport] Fixed php notice when invalid ui_component config is used (by @VitaliyBoyko)
 - magento#15234: [Backport] Add missing translations in Magento_UI (by @VitaliyBoyko)
 - magento#15233: [Backport] Fix typo in design rule hint message (by @VitaliyBoyko)
@VladimirZaets
ENGCOM-1465: [2.1-develop][Backport] Transport variable can not be al…
14c9529 
…tered in email_invoice_set_template_vars_before Event magento#15038
@magento-engcom-team
🔃 [EngCom] Public Pull Requests - 2.1-develop
e176b1e 
Accepted Public Pull Requests:
 - magento#15038: [2.1-develop][Backport] Transport variable can not be altered in email_invoice_set_template_vars_before Event (by @gwharton)


Fixed GitHub Issues:
 - magento#10210: Transport variable can not be altered in email_invoice_set_template_vars_before Event (reported by @diybook) has been fixed in magento#15038 by @gwharton in 2.1-develop branch
   Related commits:
     1. 9a95dae
@slavvka
MAGETWO-91894: Backport Static Test Fixes in CE
d5694d3
@slavvka
Merge pull request magento#2562 from magento-borg/MAGETWO-91894-2.1
347fd37 
Fixed issues:
- MAGETWO-91894 Backport Static Test Fixes in CE
@IgorVitol
Add 'const' type support to layout arguments
3723581
@IgorVitol IgorVitol force-pushed the 2.1-develop-PR-port-15058 branch from 63827dc to 3723581 Compare May 20, 2018 10:18
@IgorVitol IgorVitol closed this May 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@IgorVitol @magento-engcom-team @rogyar @dmytro-ch @VladimirZaets @KaushikChavda @hostep @dverkade @VitaliyBoyko @slavvka