Update translations from Weblate #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
55f30ff to
2cd3f29
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
2cd3f29 to
323e644
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
2 times, most recently
from
46a6f30 to
71d1fcf
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
71d1fcf to
40f3c4f
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
2 times, most recently
from
28e4431 to
14491db
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
2 times, most recently
from
279a12c to
b0805f1
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
b0805f1 to
7bb9c53
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
2 times, most recently
from
86b3f96 to
367a2bd
Compare
PIG208
force-pushed
the
main
branch
2 times, most recently
from
904062a to
9689dce
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
2 times, most recently
from
290b7c0 to
2e0adb7
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
2e0adb7 to
8aef121
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
8aef121 to
1dac8b9
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
2 times, most recently
from
0cd4fb6 to
588a19a
Compare
This will prevent string interpolation being evaluated during release build. Especially useful in later commit where it becomes more expensive.
And rename previous type to KatexSpanNode, also while making it a subtype of KatexNode.
… doc The doc for message_details on this event says the field is present if the flag is "read", with no mention of event_types. Looking through zulip/zulip's Git history, it turns out it had been mentioned in the past, but the mention was removed, in zulip/zulip@48a1cf04d: - Present if `message` and `update_message_flags` are both present in - `event_types` and the `flag` is `read` and the `op` is `remove`. + Only present if the specified `flag` is `"read"`. So the comment (and no-op `&& true`) isn't necessary; remove it. We noticed this because the analyzer started flagging an info-level `no_literal_bool_comparisons` here.
`flutter analyze` has started giving the following, which breaks CI:
info • Unnecessary comparison to a boolean literal • lib/api/model/events.dart:1177:10 •
no_literal_bool_comparisons
info • Unnecessary comparison to a boolean literal • lib/model/channel.dart:158:13 •
no_literal_bool_comparisons
We fixed the first one in the previous commit; this fixes the
second.
See discussion:
https://chat.zulip.org/#narrow/channel/243-mobile-team/topic/CI.20on.20latest.20upstream/near/2228858
This lets us make it a bit more thorough, while not adding to the complexity of reading the test case for the basic logic.
Potentially this would have helped us avoid the issue zulip#1743.
…itions This test relies on background assumptions about how the "back" page transition work which are true of the current default transitions on Android (the default target platform of tests), but are broken by the upcoming introduction of predictive back: flutter/flutter#165832 (comment) For a quick unblocking of the upstream change, skip the test. In principle there's no reason a test like this can't work with the upcoming upstream behavior; it'll just need to work a little differently. But leave that for a follow-up change.
And update Flutter's supporting libraries to match.
This reverts commit 55d055f (zulip#1738). That change was described as upgrading Flutter and its supporting libraries, but it looks like it accidentally included other upgrades, something like `flutter pub upgrade`. It also didn't include the CocoaPods updates for those upgrades; see zulip#1746. So revert that change, to get back to a well-understood state. Then we can retry the upgrade.
Thanks Komyyy for this idea, which I took from PR zulip#1363. Co-authored-by: Komyyy <[email protected]>
Servers can't yet start sending null without breaking clients. Releasing this will start lowering the number of client installs that would break, and eventually there will be few enough that the breakage is acceptable; see discussion (same link as in comment): https://chat.zulip.org/#narrow/channel/378-api-design/topic/.60user_settings.2Etwenty_four_hour_time.60/near/2220696
See the doc: https://pub.dev/documentation/intl/latest/intl/DateFormat-class.html > Formatting dates in the default 'en_US' format does not require > any initialization. (And we haven't been doing the described initialization for 'en_US' or any other locale; it's asynchronous, and we have a better plan for international formatting described in zulip#45, using ffi.)
We don't use these yet; coming up.
…tamps Fixes-partly: zulip#1015
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
4da9f02 to
077e33c
Compare
|
@PIG208, would you update this repo's settings to disable the Weblate bot, when you get a chance to do so? (Today's update from the bot caused me to get an email notification, which is why I noticed the thread. I don't understand why that happened; but I guess that will remain one of the mysteries of GitHub.) |
|
I don't recall enabling Weblate in this fork before. Disabled the workflow manually, and disallowed GitHub Actions from creating PRs. Thanks for the reminder! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action