Skip to content

feature: additional options to disable exceptions/pragmas #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
smb opened this issue Feb 10, 2021 · 0 comments · Fixed by #361
Closed

feature: additional options to disable exceptions/pragmas #329

smb opened this issue Feb 10, 2021 · 0 comments · Fixed by #361
Labels
feature New feature or refactoring

Comments

@smb
Copy link
Contributor

smb commented Feb 10, 2021

Would it be possible to enhance the check settings to include a checkbox to disable the pragma? (bonus would be to display the pragma name in the options dialog)

image

like

[ ] Disable Pragma "#EC NON_CL_EXCEPT"

so you can disable exceptions for certain check variants.
@lucasborin lucasborin added the feature New feature or refactoring label Feb 10, 2021
@ghost ghost self-assigned this Apr 1, 2021
@ghost ghost linked a pull request Apr 7, 2021 that will close this issue
Part 1 - core feature - allow pseudo comment exception #329 #357
Merged
ghost pushed a commit that referenced this issue Apr 7, 2021
@lucasborin
Part 1 - core feature - allow pseudo comment exception #329 (#357)
4da128b 
* feature - allow pseudo comment exception

* Update y_check_unit_test_assert.clas.abap

Co-authored-by: Lucas Borin <[email protected]>
lucasborin added a commit that referenced this issue Apr 7, 2021
@lucasborin
Revert "Part 1 - core feature - allow pseudo comment exception #329 (#…
20a895e 
…357)"

This reverts commit 4da128b.
lucasborin added a commit that referenced this issue Apr 7, 2021
@lucasborin
Revert "Part 1 - core feature - allow pseudo comment exception #329 (#…
c6108f1 
…357)"

This reverts commit 4da128b.
lucasborin added a commit that referenced this issue Apr 7, 2021
@lucasborin
Revert "Part 1 - core feature - allow pseudo comment exception #329 (#…
045d311 
…357)" (#358)

This reverts commit 4da128b.
@ghost ghost removed a link to a pull request Apr 8, 2021
Part 1 - core feature - allow pseudo comment exception #329 #357
Merged
@ghost ghost linked a pull request Apr 8, 2021 that will close this issue
Feature allow pseudo comment exception #361
Merged
lucasborin added a commit that referenced this issue Apr 23, 2021
@lucasborin @estevao-schultz-neto-SAP @abaplint
1.14.0 (#345)
e45ffb4 
* 1.14.0

* fixing version

* adding missing checks feature (#346)

* adding missing checks feature

* minor update

Co-authored-by: Eugen Guenther <[email protected]>

* Update changelog.txt

* Standard Functions in Prefer IS NOT to NOT IS (#353)

* solves #338

* Update changelog.txt

* contains_any_not_of and contains_any_of

* Prefer New to Create Object (#354)

* implements #283

* Update check_documentation.md

* minor fixes

* Create prefer-new-to-create-object.md

* Update changelog.txt

* Update prefer-new-to-create-object.md

* adding example

Co-authored-by: estevao-schultz-neto-SAP <[email protected]>

* Unit Test Assert Check (#347)

* new check

* fixing class description

* adding demo

* comparing token type

* Update check_documentation.md

* Update check_documentation.md

* Create unit_test_assert.md

* Update changelog.txt

* Update unit_test_assert.md

Co-authored-by: estevao-schultz-neto-SAP <[email protected]>

* Update y_check_unit_test_assert.clas.abap

* Update y_check_unit_test_assert.clas.abap

* Part 1 - core feature - allow pseudo comment exception #329 (#357)

* feature - allow pseudo comment exception

* Update y_check_unit_test_assert.clas.abap

Co-authored-by: Lucas Borin <[email protected]>

* Revert "Part 1 - core feature - allow pseudo comment exception #329 (#357)" (#358)

This reverts commit 4da128b.

* fixes #359 (#366)

* Update changelog.txt

* New abapLint Rules (#304)

* Update abaplint.json

* Update abaplint.json

* Update abaplint.json

* Update abaplint.json

* disabling empty_line_in_statement

* Remove double space

* disabling exit_or_check

* disabling line_only_punc

Reporting false-positives:
abaplint/abaplint#1888

* Update abaplint.json

* Update abaplint.json

* Compare operator "EQ" not preferred

* Disabling no_yoda_conditions

abaplint/abaplint#1891

* Method "get_first_character" not used

* Compare operator "EQ" not preferred

* Keep single parameter on one line

* Statement "ADD" is obsolete

* Compare operator "GE" not preferred

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Compare operator "GE" not preferred

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Compare operator "EQ" not preferred

* Avoid use of SELECT *

* Uncaught exception cx_sy_itab_line_not_found

* Compare operator "EQ", "LT, "GT" not preferred

* Reorder definitions to top of routine

* Too many parenthesis, simple

* Prefer Inline Declarations, CHECK_CONFIGURATION

* Missing space between string or character literal

* wrongly commited object

* Some fixes

Compare operator "EQ" not preferred
Prefer Inline Declarations, FM_NAME
Reorder definitions to top of routine

* Statement "ADD" is obsolete

* Compare operator "EQ" not preferred

* Some fixes

Compare operator "EQ" not preferred
Statement "ADD" is obsolete
Statement "SUBTRACT" is obsolete
Line break multiple parameters

* Some fixes

Compare operator "EQ" not preferred
Method "check_token_content" not used
Statement "ADD" is obsolete

* Some fixes

Line break multiple parameters
Compare operator "GE" not preferred
Compare operator "EQ" not preferred

* ops, fixing bug

* Compare operator "EQ" not preferred

* Statement "ADD" is obsolete

* Some fixes

Statement "ADD" is obsolete
Statement "SUBTRACT" is obsolete
Too many parenthesis, complex

* Some fixes

Omit default parameter name "FIRST_TOKEN"
Statement "SUBTRACT" is obsolete
Statement "ADD" is obsolete

* several fixes

* Update y_check_unit_test_assert.clas.abap

* Update abaplint.json

* Update abaplint.json

* Update abaplint.json

* Several fixes

* several fixes

* SEVERAL FIXES

* Update abaplint.json

* Update abaplint.json

* several fixes

* Update abaplint.json

* Update abaplint.json

* Update abaplint.json

* Update abaplint.json

* a few fixes

* Update abaplint.json

* several fixes

* Update abaplint.json

* several fixes

* Update abaplint.json

* a few fixes

* Update abaplint.json

* Update y_exemption_general.clas.abap

* Update y_test_code_detector.clas.abap

* Update y_check_empty_catches.clas.abap

* Don't mix RETURNING and EXPORTING/CHANGING paramet

* Update abaplint.json

* Update abaplint.json

* Update abaplint.json

Co-authored-by: Eugen Günther <[email protected]>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update changelog.txt

* Update y_check_base.clas.abap

* Update src/foundation/y_check_base.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update unit_test_assert.md

* Feature allow pseudo comment exception (#361)

* feature - allow pseudo comment exception

* Update y_check_unit_test_assert.clas.abap

* update

* minor update

* requested changes

* Update src/profiles/y_profile_admin_classes.prog.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* UX update

* abaplint fix

* Update y_check_base.clas.abap

* Update y_profile_admin_classes.prog.abap

* Update y_profile_manager.clas.abap

* Update src/profiles/y_profile_admin_classes.prog.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update y_profile_administrator.prog.xml

* Update y_profile_admin_classes.prog.abap

* Update y_profile_admin_classes.prog.abap

* minor change

* abaplint fix

* Update y_check_base.clas.abap

* update

* update

* Update y_profile_admin_classes.prog.abap

* update

* Update how-to-configure.md

* Update how-to-configure.md

* Update how-to-configure.md

* Update changelog.txt

Co-authored-by: Eugen Guenther <[email protected]>
Co-authored-by: Eugen Günther <[email protected]>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Prefer LINE_EXISTS or LINE_INDEX to READ TABLE or LOOP AT (#355)

* implements #286

* Update changelog.txt

* Update check_documentation.md

* demo + description

* Create prefer-line-exists.md

* Update y_check_unit_test_assert.clas.abap

* fixing from/to

* Update y_check_prefer_line_exists.clas.testclasses.abap

Co-authored-by: Eugen Günther <[email protected]>

* Update changelog.txt

* Update abaplint.json (#377)

* adjust of ignore pseudocomment on relevant checks (#375)

* adjust of ignore pseudocomment on relevant checks

* update

* update

Co-authored-by: Lucas Borin <[email protected]>

* changing default severity (#376)

* changing default severity

* fixing version

* c_note

* Update README.md

* Update README.md

* Update how-to-configure.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update how-to-configure.md

* Update how-to-configure.md

* Update how-to-configure.md

* Update how-to-configure.md

* Update how-to-configure.md

* Update changelog.txt

* Update README.md

* Update how-to-configure.md

* Update how-to-configure.md

* Update how-to-configure.md

* Update how-to-configure.md

* Update how-to-configure.md

Co-authored-by: estevao-schultz-neto-SAP <[email protected]>

* Update changelog.txt

* Update changelog.txt

* Update changelog.txt

* fixing broken ut

Co-authored-by: Eugen Guenther <[email protected]>
Co-authored-by: estevao-schultz-neto-SAP <[email protected]>
Co-authored-by: Eugen Günther <[email protected]>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature allow pseudo comment exception SAP/code-pal-for-abap
2 participants
@smb @lucasborin