Skip to content

1.14.0 #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Apr 23, 2021
Merged

1.14.0 #345

merged 33 commits into from
Apr 23, 2021

Conversation

lucasborin
Copy link
Member

No description provided.

lucasborin and others added 9 commits March 31, 2021 17:06
* adding missing checks feature

* minor update

Co-authored-by: Eugen Guenther <[email protected]>
* solves #338

* Update changelog.txt

* contains_any_not_of and contains_any_of
* implements #283

* Update check_documentation.md

* minor fixes

* Create prefer-new-to-create-object.md

* Update changelog.txt

* Update prefer-new-to-create-object.md

* adding example

Co-authored-by: estevao-schultz-neto-SAP <[email protected]>
* new check

* fixing class description

* adding demo

* comparing token type

* Update check_documentation.md

* Update check_documentation.md

* Create unit_test_assert.md

* Update changelog.txt

* Update unit_test_assert.md

Co-authored-by: estevao-schultz-neto-SAP <[email protected]>
@ghost ghost linked an issue Apr 7, 2021 that may be closed by this pull request
@lucasborin lucasborin linked an issue Apr 8, 2021 that may be closed by this pull request
lucasborin and others added 6 commits April 8, 2021 11:26
* Update abaplint.json

* Update abaplint.json

* Update abaplint.json

* Update abaplint.json

* disabling empty_line_in_statement

* Remove double space

* disabling exit_or_check

* disabling line_only_punc

Reporting false-positives:
abaplint/abaplint#1888

* Update abaplint.json

* Update abaplint.json

* Compare operator "EQ" not preferred

* Disabling no_yoda_conditions

abaplint/abaplint#1891

* Method "get_first_character" not used

* Compare operator "EQ" not preferred

* Keep single parameter on one line

* Statement "ADD" is obsolete

* Compare operator "GE" not preferred

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Compare operator "GE" not preferred

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Compare operator "EQ" not preferred

* Avoid use of SELECT *

* Uncaught exception cx_sy_itab_line_not_found

* Compare operator "EQ", "LT, "GT" not preferred

* Reorder definitions to top of routine

* Too many parenthesis, simple

* Prefer Inline Declarations, CHECK_CONFIGURATION

* Missing space between string or character literal

* wrongly commited object

* Some fixes

Compare operator "EQ" not preferred
Prefer Inline Declarations, FM_NAME
Reorder definitions to top of routine

* Statement "ADD" is obsolete

* Compare operator "EQ" not preferred

* Some fixes

Compare operator "EQ" not preferred
Statement "ADD" is obsolete
Statement "SUBTRACT" is obsolete
Line break multiple parameters

* Some fixes

Compare operator "EQ" not preferred
Method "check_token_content" not used
Statement "ADD" is obsolete

* Some fixes

Line break multiple parameters
Compare operator "GE" not preferred
Compare operator "EQ" not preferred

* ops, fixing bug

* Compare operator "EQ" not preferred

* Statement "ADD" is obsolete

* Some fixes

Statement "ADD" is obsolete
Statement "SUBTRACT" is obsolete
Too many parenthesis, complex

* Some fixes

Omit default parameter name "FIRST_TOKEN"
Statement "SUBTRACT" is obsolete
Statement "ADD" is obsolete

* several fixes

* Update y_check_unit_test_assert.clas.abap

* Update abaplint.json

* Update abaplint.json

* Update abaplint.json

* Several fixes

* several fixes

* SEVERAL FIXES

* Update abaplint.json

* Update abaplint.json

* several fixes

* Update abaplint.json

* Update abaplint.json

* Update abaplint.json

* Update abaplint.json

* a few fixes

* Update abaplint.json

* several fixes

* Update abaplint.json

* several fixes

* Update abaplint.json

* a few fixes

* Update abaplint.json

* Update y_exemption_general.clas.abap

* Update y_test_code_detector.clas.abap

* Update y_check_empty_catches.clas.abap

* Don't mix RETURNING and EXPORTING/CHANGING paramet

* Update abaplint.json

* Update abaplint.json

* Update abaplint.json

Co-authored-by: Eugen Günther <[email protected]>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@larshp
Copy link
Contributor

larshp commented Apr 12, 2021

https://rules.abaplint.org/intf_referencing_clas/ now includes a allow list, so you can exempt the warning

lucasborin and others added 3 commits April 13, 2021 14:57
* feature - allow pseudo comment exception

* Update y_check_unit_test_assert.clas.abap

* update

* minor update

* requested changes

* Update src/profiles/y_profile_admin_classes.prog.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* UX update

* abaplint fix

* Update y_check_base.clas.abap

* Update y_profile_admin_classes.prog.abap

* Update y_profile_manager.clas.abap

* Update src/profiles/y_profile_admin_classes.prog.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update y_profile_administrator.prog.xml

* Update y_profile_admin_classes.prog.abap

* Update y_profile_admin_classes.prog.abap

* minor change

* abaplint fix

* Update y_check_base.clas.abap

* update

* update

* Update y_profile_admin_classes.prog.abap

* update

* Update how-to-configure.md

* Update how-to-configure.md

* Update how-to-configure.md

* Update changelog.txt

Co-authored-by: Eugen Guenther <[email protected]>
Co-authored-by: Eugen Günther <[email protected]>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
* implements #286

* Update changelog.txt

* Update check_documentation.md

* demo + description

* Create prefer-line-exists.md

* Update y_check_unit_test_assert.clas.abap

* fixing from/to

* Update y_check_prefer_line_exists.clas.testclasses.abap

Co-authored-by: Eugen Günther <[email protected]>
@lucasborin lucasborin self-assigned this Apr 13, 2021
Eugen Günther and others added 3 commits April 15, 2021 08:30
* adjust of ignore pseudocomment on relevant checks

* update

* update

Co-authored-by: Lucas Borin <[email protected]>
* changing default severity

* fixing version

* c_note

* Update README.md

* Update README.md

* Update how-to-configure.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update how-to-configure.md

* Update how-to-configure.md

* Update how-to-configure.md

* Update how-to-configure.md

* Update how-to-configure.md

* Update changelog.txt

* Update README.md

* Update how-to-configure.md

* Update how-to-configure.md

* Update how-to-configure.md

* Update how-to-configure.md

* Update how-to-configure.md

Co-authored-by: estevao-schultz-neto-SAP <[email protected]>
@lucasborin lucasborin marked this pull request as ready for review April 19, 2021 16:50
@lucasborin lucasborin requested a review from a team as a code owner April 19, 2021 16:50
@lucasborin
Copy link
Member Author

ABAP 7.40 = OK

@lucasborin
Copy link
Member Author

Please, change the changelog.txt date before releasing it.

ghost
ghost previously approved these changes Apr 20, 2021
@lucasborin lucasborin dismissed stale reviews from ghost via 3cae21a April 22, 2021 19:24
@lucasborin
Copy link
Member Author

Broken UT:

image

@lucasborin lucasborin merged commit e45ffb4 into master Apr 23, 2021
@lucasborin lucasborin deleted the 1.14.0 branch April 23, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diffs for TABL Add missing/new checks to Profile Manager
2 participants