changing default severity #376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasborin
commented
Apr 14, 2021
lucasborin
commented
Apr 14, 2021
|
it corrupts the variant 😢 |
|
"corrupts" => it forces the user to review the new customizing on each check. To avoid manual efforts in the upgrade, let's keep the same Check version. |
lucasborin
requested review from
estevao-schultz-neto-SAP,
a user and
maxim-engel-sap
estevao-schultz-neto-SAP
requested changes
Apr 15, 2021
lucasborin
commented
Apr 15, 2021
lucasborin
commented
Apr 15, 2021
estevao-schultz-neto-SAP
approved these changes
Apr 15, 2021
lucasborin
added a commit
that referenced
this pull request
Apr 23, 2021
* 1.14.0 * fixing version * adding missing checks feature (#346) * adding missing checks feature * minor update Co-authored-by: Eugen Guenther <[email protected]> * Update changelog.txt * Standard Functions in Prefer IS NOT to NOT IS (#353) * solves #338 * Update changelog.txt * contains_any_not_of and contains_any_of * Prefer New to Create Object (#354) * implements #283 * Update check_documentation.md * minor fixes * Create prefer-new-to-create-object.md * Update changelog.txt * Update prefer-new-to-create-object.md * adding example Co-authored-by: estevao-schultz-neto-SAP <[email protected]> * Unit Test Assert Check (#347) * new check * fixing class description * adding demo * comparing token type * Update check_documentation.md * Update check_documentation.md * Create unit_test_assert.md * Update changelog.txt * Update unit_test_assert.md Co-authored-by: estevao-schultz-neto-SAP <[email protected]> * Update y_check_unit_test_assert.clas.abap * Update y_check_unit_test_assert.clas.abap * Part 1 - core feature - allow pseudo comment exception #329 (#357) * feature - allow pseudo comment exception * Update y_check_unit_test_assert.clas.abap Co-authored-by: Lucas Borin <[email protected]> * Revert "Part 1 - core feature - allow pseudo comment exception #329 (#357)" (#358) This reverts commit 4da128b. * fixes #359 (#366) * Update changelog.txt * New abapLint Rules (#304) * Update abaplint.json * Update abaplint.json * Update abaplint.json * Update abaplint.json * disabling empty_line_in_statement * Remove double space * disabling exit_or_check * disabling line_only_punc Reporting false-positives: abaplint/abaplint#1888 * Update abaplint.json * Update abaplint.json * Compare operator "EQ" not preferred * Disabling no_yoda_conditions abaplint/abaplint#1891 * Method "get_first_character" not used * Compare operator "EQ" not preferred * Keep single parameter on one line * Statement "ADD" is obsolete * Compare operator "GE" not preferred Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com> * Compare operator "GE" not preferred Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com> * Compare operator "EQ" not preferred * Avoid use of SELECT * * Uncaught exception cx_sy_itab_line_not_found * Compare operator "EQ", "LT, "GT" not preferred * Reorder definitions to top of routine * Too many parenthesis, simple * Prefer Inline Declarations, CHECK_CONFIGURATION * Missing space between string or character literal * wrongly commited object * Some fixes Compare operator "EQ" not preferred Prefer Inline Declarations, FM_NAME Reorder definitions to top of routine * Statement "ADD" is obsolete * Compare operator "EQ" not preferred * Some fixes Compare operator "EQ" not preferred Statement "ADD" is obsolete Statement "SUBTRACT" is obsolete Line break multiple parameters * Some fixes Compare operator "EQ" not preferred Method "check_token_content" not used Statement "ADD" is obsolete * Some fixes Line break multiple parameters Compare operator "GE" not preferred Compare operator "EQ" not preferred * ops, fixing bug * Compare operator "EQ" not preferred * Statement "ADD" is obsolete * Some fixes Statement "ADD" is obsolete Statement "SUBTRACT" is obsolete Too many parenthesis, complex * Some fixes Omit default parameter name "FIRST_TOKEN" Statement "SUBTRACT" is obsolete Statement "ADD" is obsolete * several fixes * Update y_check_unit_test_assert.clas.abap * Update abaplint.json * Update abaplint.json * Update abaplint.json * Several fixes * several fixes * SEVERAL FIXES * Update abaplint.json * Update abaplint.json * several fixes * Update abaplint.json * Update abaplint.json * Update abaplint.json * Update abaplint.json * a few fixes * Update abaplint.json * several fixes * Update abaplint.json * several fixes * Update abaplint.json * a few fixes * Update abaplint.json * Update y_exemption_general.clas.abap * Update y_test_code_detector.clas.abap * Update y_check_empty_catches.clas.abap * Don't mix RETURNING and EXPORTING/CHANGING paramet * Update abaplint.json * Update abaplint.json * Update abaplint.json Co-authored-by: Eugen Günther <[email protected]> Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com> * Update changelog.txt * Update y_check_base.clas.abap * Update src/foundation/y_check_base.clas.abap Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com> * Update unit_test_assert.md * Feature allow pseudo comment exception (#361) * feature - allow pseudo comment exception * Update y_check_unit_test_assert.clas.abap * update * minor update * requested changes * Update src/profiles/y_profile_admin_classes.prog.abap Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com> * UX update * abaplint fix * Update y_check_base.clas.abap * Update y_profile_admin_classes.prog.abap * Update y_profile_manager.clas.abap * Update src/profiles/y_profile_admin_classes.prog.abap Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com> * Update y_profile_administrator.prog.xml * Update y_profile_admin_classes.prog.abap * Update y_profile_admin_classes.prog.abap * minor change * abaplint fix * Update y_check_base.clas.abap * update * update * Update y_profile_admin_classes.prog.abap * update * Update how-to-configure.md * Update how-to-configure.md * Update how-to-configure.md * Update changelog.txt Co-authored-by: Eugen Guenther <[email protected]> Co-authored-by: Eugen Günther <[email protected]> Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com> * Prefer LINE_EXISTS or LINE_INDEX to READ TABLE or LOOP AT (#355) * implements #286 * Update changelog.txt * Update check_documentation.md * demo + description * Create prefer-line-exists.md * Update y_check_unit_test_assert.clas.abap * fixing from/to * Update y_check_prefer_line_exists.clas.testclasses.abap Co-authored-by: Eugen Günther <[email protected]> * Update changelog.txt * Update abaplint.json (#377) * adjust of ignore pseudocomment on relevant checks (#375) * adjust of ignore pseudocomment on relevant checks * update * update Co-authored-by: Lucas Borin <[email protected]> * changing default severity (#376) * changing default severity * fixing version * c_note * Update README.md * Update README.md * Update how-to-configure.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update how-to-configure.md * Update how-to-configure.md * Update how-to-configure.md * Update how-to-configure.md * Update how-to-configure.md * Update changelog.txt * Update README.md * Update how-to-configure.md * Update how-to-configure.md * Update how-to-configure.md * Update how-to-configure.md * Update how-to-configure.md Co-authored-by: estevao-schultz-neto-SAP <[email protected]> * Update changelog.txt * Update changelog.txt * Update changelog.txt * fixing broken ut Co-authored-by: Eugen Guenther <[email protected]> Co-authored-by: estevao-schultz-neto-SAP <[email protected]> Co-authored-by: Eugen Günther <[email protected]> Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #368