refactor(router-core): move router-core into a separate package

[birkskyum]

This is a preparation step for:

• feat(solid-router): Add a SolidJS driver for TanStack Router #3276

It moves pieces of shared logic from react-router to router-core, and imports it from there.

The exports in react-router/src/index.tsx are kept as is, by re-exporting functions from router-core, to avoid breaking changes.

[nx-cloud]

View your CI Pipeline Execution ↗ for commit a1b74c8.

Command	Status	Duration	Result
nx affected --targets=test:eslint,test:unit,tes...	✅ Succeeded	6m 1s	View ↗
nx run-many --target=build --exclude=examples/*...	✅ Succeeded	1m 44s	View ↗

---

☁️ Nx Cloud last updated this comment at 2025-01-26 01:05:01 UTC

[pkg-pr-new]

Open in Stackblitz

More templates

• tanstack-router-react-example-authenticated-routes
• tanstack-router-react-example-basic
• tanstack-router-react-example-basic-file-based
• tanstack-router-react-example-basic-file-based-codesplitting
• tanstack-router-react-example-basic-default-search-params
• tanstack-router-react-example-react-query
• tanstack-router-react-example-basic-react-query-file-based
• tanstack-router-react-example-basic-ssr-file-based
• tanstack-router-react-example-basic-ssr-streaming-file-based
• tanstack-router-react-example-basic-virtual-file-based
• tanstack-router-react-example-deferred-data
• tanstack-router-react-example-kitchen-sink
• tanstack-router-react-example-basic-virtual-inside-file-based
• tanstack-router-react-example-kitchen-sink-file-based
• tanstack-router-react-example-kitchen-sink-react-query
• tanstack-router-react-example-kitchen-sink-react-query-file-based
• tanstack-router-react-example-large-file-based
• tanstack-router-react-example-location-masking
• tanstack-router-react-example-navigation-blocking
• tanstack-router-react-example-quickstart
• tanstack-router-react-example-quickstart-esbuild-file-based
• tanstack-router-react-example-quickstart-file-based
• tanstack-router-react-example-quickstart-rspack-file-based
• tanstack-router-react-example-quickstart-webpack-file-based
• router-monorepo-react-query
• router-mono-simple
• tanstack-router-react-example-scroll-restoration
• tanstack-search-validator-adapters
• tanstack-start-example-basic
• tanstack-start-example-basic-auth
• tanstack-start-example-basic-react-query
• tanstack-start-example-basic-rsc
• tanstack-start-example-clerk-basic
• tanstack-start-example-convex-trellaux
• tanstack-start-example-counter
• tanstack-start-example-large
• tanstack-start-example-supabase-basic
• tanstack-start-example-trellaux
• tanstack-router-react-example-with-framer-motion
• tanstack-router-react-example-with-trpc
• tanstack-router-react-example-with-trpc-react-query

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@3171

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@3171

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/@tanstack/directive-functions-plugin@3171

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3171

@tanstack/create-start

npm i https://pkg.pr.new/@tanstack/create-start@3171

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@3171

@tanstack/react-cross-context

npm i https://pkg.pr.new/@tanstack/react-cross-context@3171

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@3171

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@3171

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@3171

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@3171

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@3171

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@3171

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@3171

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3171

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/@tanstack/server-functions-plugin@3171

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@3171

@tanstack/start-api-routes

npm i https://pkg.pr.new/@tanstack/start-api-routes@3171

@tanstack/start-client

npm i https://pkg.pr.new/@tanstack/start-client@3171

@tanstack/start-config

npm i https://pkg.pr.new/@tanstack/start-config@3171

@tanstack/start-plugin

npm i https://pkg.pr.new/@tanstack/start-plugin@3171

@tanstack/start-router-manifest

npm i https://pkg.pr.new/@tanstack/start-router-manifest@3171

@tanstack/start-server

npm i https://pkg.pr.new/@tanstack/start-server@3171

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/@tanstack/start-server-functions-client@3171

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/@tanstack/start-server-functions-fetcher@3171

@tanstack/start-server-functions-handler

npm i https://pkg.pr.new/@tanstack/start-server-functions-handler@3171

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/@tanstack/start-server-functions-server@3171

@tanstack/start-server-functions-ssr

npm i https://pkg.pr.new/@tanstack/start-server-functions-ssr@3171

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@3171

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3171

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@3171

commit: a1b74c8

[birkskyum]

I think basically we're facing a hoisting issue, similar to:

• pnpm support without --shamefully-hoist nuxt/nuxt#14146

[birkskyum]

As stated here:

Generated types are not fully functional without hoisted node_modules

Meaning that users can have partial types (the @tanstack/router-core won't be resolved), or add public-hoist-pattern[]=@tanstack/router-core to .npmrc

It's unlikely I'll find a better solution for hoisting a nested package than the Nuxt/UnJS team who deep dived this.

The solutions I see here are basically to treat router-core not as a package, but just as a simple folder that's referenced or otherwise copied into the react-router/solid-router packages. Or alternatively, to duplicate this code for now, and abstract it out at next major release with a recommendation to install @tanstack/router-core

[SeanCassiere]

@birkskyum thanks for your work on this one. I've pushed this to the team for review and we should be able to merge tomorrow.

---

In response to your comment above, we'll wait to see the common practice going forward since this pattern is currently in use by TanStack Table as well, so we'll be to apply whatever changes to the TanStack ecosystem as whole when the "correct" way has been figured out.

[birkskyum]

Sounds good. And the CI just passed? Did the tsconfig change do the trick, making react-router a self-contained module/folder? or does it run fewer tests

[SeanCassiere]

... And the CI just passed?

One of your commits prior to 538b8b9 did the trick. All that remains were eslint errors.