Skip to content

SolidJS driver for TanStack Start #3522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 124 commits into from
Mar 1, 2025

Conversation

birkskyum
Copy link
Member

@birkskyum birkskyum commented Feb 22, 2025

This PR introduce support for Solid to be used with TanStack Start.

There are several ongoing refactors that can influence the timing of when it's most feasible to merge this.

Status (build and run e2e/solid-start/basic)

  • SSR
  • API Routes
  • Server Functions
  • HMR
  • Streaming (/stream route)
  • Timely hydration

Ongoing refactors

Refactor to make router packages (aka. client-only features) more agnostic:

Refactor to make start packages (aka. server features) more agnostic:

Upstream changes to solid-router

Passing E2E test suites

  • basic
  • website
  • scroll-restoration
  • server-functions

Copy link

nx-cloud bot commented Feb 22, 2025

View your CI Pipeline Execution ↗ for commit 910b612.

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 10m 45s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 29s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-01 12:43:22 UTC

@birkskyum birkskyum force-pushed the tanstack-solid-start branch 3 times, most recently from 6686a0b to 4382f2f Compare February 24, 2025 18:54
@birkskyum birkskyum force-pushed the tanstack-solid-start branch from fd0e9e0 to 809e7ff Compare February 24, 2025 19:55
@birkskyum birkskyum force-pushed the tanstack-solid-start branch from dc8f144 to 384689f Compare February 24, 2025 20:42
@birkskyum birkskyum force-pushed the tanstack-solid-start branch 2 times, most recently from e98b210 to 9d0c941 Compare February 24, 2025 22:45
@birkskyum birkskyum force-pushed the tanstack-solid-start branch from 86452cb to efaab75 Compare February 24, 2025 23:09
@birkskyum birkskyum changed the title WIP - SolidJS driver for TanStack Start SolidJS driver for TanStack Start Feb 25, 2025
@birkskyum birkskyum changed the title SolidJS driver for TanStack Start feat(solid-start) SolidJS driver for TanStack Start Feb 25, 2025
@birkskyum birkskyum changed the title feat(solid-start) SolidJS driver for TanStack Start Experimental: SolidJS driver for TanStack Start Feb 25, 2025
@birkskyum birkskyum force-pushed the tanstack-solid-start branch from f335f15 to 7c76170 Compare February 25, 2025 21:08
@birkskyum birkskyum force-pushed the tanstack-solid-start branch from 212c51c to 35745c2 Compare February 25, 2025 21:39
@birkskyum birkskyum changed the title Experimental: SolidJS driver for TanStack Start SolidJS driver for TanStack Start Feb 26, 2025
Copy link

pkg-pr-new bot commented Mar 1, 2025

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@3522

@tanstack/create-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/create-router@3522

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@3522

@tanstack/create-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/create-start@3522

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@3522

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@3522

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@3522

@tanstack/react-router-with-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-with-query@3522

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@3522

@tanstack/react-start-api-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-api-routes@3522

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@3522

@tanstack/react-start-config

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-config@3522

@tanstack/react-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-plugin@3522

@tanstack/react-start-router-manifest

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-router-manifest@3522

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@3522

@tanstack/react-start-server-functions-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server-functions-client@3522

@tanstack/react-start-server-functions-fetcher

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server-functions-fetcher@3522

@tanstack/react-start-server-functions-handler

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server-functions-handler@3522

@tanstack/react-start-server-functions-ssr

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server-functions-ssr@3522

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@3522

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@3522

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@3522

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@3522

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@3522

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@3522

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@3522

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@3522

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@3522

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@3522

@tanstack/solid-start-api-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-api-routes@3522

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@3522

@tanstack/solid-start-config

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-config@3522

@tanstack/solid-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-plugin@3522

@tanstack/solid-start-router-manifest

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-router-manifest@3522

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@3522

@tanstack/solid-start-server-functions-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server-functions-client@3522

@tanstack/solid-start-server-functions-fetcher

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server-functions-fetcher@3522

@tanstack/solid-start-server-functions-handler

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server-functions-handler@3522

@tanstack/solid-start-server-functions-ssr

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server-functions-ssr@3522

@tanstack/start

npm i https://pkg.pr.new/TanStack/router/@tanstack/start@3522

@tanstack/start-config

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-config@3522

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-server@3522

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@3522

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@3522

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@3522

commit: 910b612

@schiller-manuel schiller-manuel merged commit e2ac863 into TanStack:main Mar 1, 2025
6 of 7 checks passed
leesb971204 pushed a commit to leesb971204/router that referenced this pull request Apr 16, 2025
This PR introduce support for Solid to be used with TanStack Start.

There are several ongoing refactors that can influence the timing of
when it's most feasible to merge this.

### Status (build and run e2e/solid-start/basic)
- [X] SSR
- [x] API Routes
- [x] Server Functions
- [x] HMR
- [x] Streaming (/stream route)
- [X] Timely hydration

### Ongoing refactors

Refactor to make router packages (aka. client-only features) more
agnostic:
- TanStack#3552
- TanStack#3540
- TanStack#3538
- TanStack#3171

Refactor to make start packages (aka. server features) more agnostic:
- TanStack#3546 
- TanStack#3563 
- TanStack#3565 

### Upstream changes to solid-router
- TanStack#3592
- TanStack#3591
- TanStack#3589
- TanStack#3616 

### Passing E2E test suites
- [x]  basic
- [x]  website
- [x] scroll-restoration
- [x] server-functions

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Brenley Dueck <[email protected]>
Co-authored-by: Iha Shin <[email protected]>
Co-authored-by: Brenley Dueck <[email protected]>
serhalp added a commit to netlify/build that referenced this pull request Apr 25, 2025
serhalp added a commit to netlify/build that referenced this pull request Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants