Skip to content

fix(solid-router): remove delete linkProps.disabled #3592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

fix(solid-router): remove delete linkProps.disabled #3592

merged 1 commit into from
Feb 27, 2025

Conversation

brenelz
Copy link
Contributor

@brenelz brenelz commented Feb 27, 2025 •
edited
Loading

We were getting a TypeError around this in the Tanstack Solid Start when working with it.

I am not sure if this is a proper fix as maybe something won't work as expected then?

The error we get is:

TypeError: Cannot delete property 'disabled' of #

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 27, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 8077fff.

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 2m 24s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 13s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-27 13:58:18 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 27, 2025

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@3592

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@3592

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/@tanstack/directive-functions-plugin@3592

@tanstack/create-start

npm i https://pkg.pr.new/@tanstack/create-start@3592

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3592

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@3592

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@3592

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@3592

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@3592

@tanstack/react-start-api-routes

npm i https://pkg.pr.new/@tanstack/react-start-api-routes@3592

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@3592

@tanstack/react-start-config

npm i https://pkg.pr.new/@tanstack/react-start-config@3592

@tanstack/react-start-plugin

npm i https://pkg.pr.new/@tanstack/react-start-plugin@3592

@tanstack/react-start-router-manifest

npm i https://pkg.pr.new/@tanstack/react-start-router-manifest@3592

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@3592

@tanstack/react-start-server-functions-client

npm i https://pkg.pr.new/@tanstack/react-start-server-functions-client@3592

@tanstack/react-start-server-functions-fetcher

npm i https://pkg.pr.new/@tanstack/react-start-server-functions-fetcher@3592

@tanstack/react-start-server-functions-handler

npm i https://pkg.pr.new/@tanstack/react-start-server-functions-handler@3592

@tanstack/react-start-server-functions-ssr

npm i https://pkg.pr.new/@tanstack/react-start-server-functions-ssr@3592

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@3592

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@3592

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@3592

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@3592

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@3592

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@3592

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3592

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/@tanstack/server-functions-plugin@3592

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@3592

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@3592

@tanstack/start-config

npm i https://pkg.pr.new/@tanstack/start-config@3592

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/@tanstack/start-server-functions-server@3592

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@3592

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3592

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@3592

commit: 8077fff

@birkskyum birkskyum mentioned this pull request Feb 27, 2025
Merged
10 tasks
@birkskyum
Copy link
Member

birkskyum commented Feb 27, 2025 •
edited
Loading

The code that's now deleted, and the tests of it were introduced here:

Tests got refactored here:

Tests both before/after that refactor still pass for solid-router

SeanCassiere
SeanCassiere approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@SeanCassiere SeanCassiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from discord
... I think there was an issue with Anchor Elements in React's runtime receiving the disabled prop

If this works fine for Solid, then 👍🏼

@birkskyum
Copy link
Member

Excellent - it does.

@SeanCassiere SeanCassiere merged commit 24add74 into TanStack:main Feb 27, 2025
7 checks passed
schiller-manuel pushed a commit that referenced this pull request Mar 1, 2025
@birkskyum @autofix-ci
@brenelz @XiNiHa
SolidJS driver for TanStack Start (#3522)
e2ac863 
This PR introduce support for Solid to be used with TanStack Start.

There are several ongoing refactors that can influence the timing of
when it's most feasible to merge this.

### Status (build and run e2e/solid-start/basic)
- [X] SSR
- [x] API Routes
- [x] Server Functions
- [x] HMR
- [x] Streaming (/stream route)
- [X] Timely hydration

### Ongoing refactors

Refactor to make router packages (aka. client-only features) more
agnostic:
- #3552
- #3540
- #3538
- #3171

Refactor to make start packages (aka. server features) more agnostic:
- #3546 
- #3563 
- #3565 

### Upstream changes to solid-router
- #3592
- #3591
- #3589
- #3616 

### Passing E2E test suites
- [x]  basic
- [x]  website
- [x] scroll-restoration
- [x] server-functions

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Brenley Dueck <[email protected]>
Co-authored-by: Iha Shin <[email protected]>
Co-authored-by: Brenley Dueck <[email protected]>
leesb971204 pushed a commit to leesb971204/router that referenced this pull request Apr 16, 2025
@brenelz @leesb971204
fix(solid-router): remove delete linkProps.disabled (TanStack#3592)
3321097
leesb971204 pushed a commit to leesb971204/router that referenced this pull request Apr 16, 2025
@birkskyum @autofix-ci
@brenelz @XiNiHa @leesb971204
SolidJS driver for TanStack Start (TanStack#3522)
90f49de 
This PR introduce support for Solid to be used with TanStack Start.

There are several ongoing refactors that can influence the timing of
when it's most feasible to merge this.

### Status (build and run e2e/solid-start/basic)
- [X] SSR
- [x] API Routes
- [x] Server Functions
- [x] HMR
- [x] Streaming (/stream route)
- [X] Timely hydration

### Ongoing refactors

Refactor to make router packages (aka. client-only features) more
agnostic:
- TanStack#3552
- TanStack#3540
- TanStack#3538
- TanStack#3171

Refactor to make start packages (aka. server features) more agnostic:
- TanStack#3546 
- TanStack#3563 
- TanStack#3565 

### Upstream changes to solid-router
- TanStack#3592
- TanStack#3591
- TanStack#3589
- TanStack#3616 

### Passing E2E test suites
- [x]  basic
- [x]  website
- [x] scroll-restoration
- [x] server-functions

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Brenley Dueck <[email protected]>
Co-authored-by: Iha Shin <[email protected]>
Co-authored-by: Brenley Dueck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeanCassiere SeanCassiere SeanCassiere approved these changes

Assignees
No one assigned
Labels
package: solid-router
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brenelz @birkskyum @SeanCassiere