Skip to content

refactor(start-client, start-server, start-server-functions-fetcher): work towards making agnostic #3546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 25, 2025
Merged

refactor(start-client, start-server, start-server-functions-fetcher): work towards making agnostic #3546

merged 7 commits into from
Feb 25, 2025

Conversation

birkskyum
Copy link
Member

@birkskyum birkskyum commented Feb 24, 2025 •
edited
Loading

Move imports from react-router to router-core / tiny-warning @tanstack/history

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 24, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 188e954.

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 4m 1s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 42s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-25 11:32:40 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 24, 2025 •
edited
Loading

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@3546

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@3546

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/@tanstack/directive-functions-plugin@3546

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3546

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@3546

@tanstack/create-start

npm i https://pkg.pr.new/@tanstack/create-start@3546

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@3546

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@3546

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@3546

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@3546

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@3546

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@3546

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@3546

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@3546

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3546

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/@tanstack/server-functions-plugin@3546

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@3546

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@3546

@tanstack/start-api-routes

npm i https://pkg.pr.new/@tanstack/start-api-routes@3546

@tanstack/start-client

npm i https://pkg.pr.new/@tanstack/start-client@3546

@tanstack/start-config

npm i https://pkg.pr.new/@tanstack/start-config@3546

@tanstack/start-plugin

npm i https://pkg.pr.new/@tanstack/start-plugin@3546

@tanstack/start-router-manifest

npm i https://pkg.pr.new/@tanstack/start-router-manifest@3546

@tanstack/start-server

npm i https://pkg.pr.new/@tanstack/start-server@3546

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/@tanstack/start-server-functions-client@3546

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/@tanstack/start-server-functions-fetcher@3546

@tanstack/start-server-functions-handler

npm i https://pkg.pr.new/@tanstack/start-server-functions-handler@3546

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/@tanstack/start-server-functions-server@3546

@tanstack/start-server-functions-ssr

npm i https://pkg.pr.new/@tanstack/start-server-functions-ssr@3546

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@3546

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3546

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@3546

commit: 188e954

@birkskyum birkskyum force-pushed the towards-agnostic-start-packages branch from cfcf9dd to 9f04d29 Compare February 25, 2025 10:39
@birkskyum birkskyum mentioned this pull request Feb 25, 2025
Merged
10 tasks
@schiller-manuel schiller-manuel merged commit e4d26cc into TanStack:main Feb 25, 2025
7 checks passed
schiller-manuel pushed a commit that referenced this pull request Mar 1, 2025
@birkskyum @autofix-ci
@brenelz @XiNiHa
SolidJS driver for TanStack Start (#3522)
e2ac863 
This PR introduce support for Solid to be used with TanStack Start.

There are several ongoing refactors that can influence the timing of
when it's most feasible to merge this.

### Status (build and run e2e/solid-start/basic)
- [X] SSR
- [x] API Routes
- [x] Server Functions
- [x] HMR
- [x] Streaming (/stream route)
- [X] Timely hydration

### Ongoing refactors

Refactor to make router packages (aka. client-only features) more
agnostic:
- #3552
- #3540
- #3538
- #3171

Refactor to make start packages (aka. server features) more agnostic:
- #3546 
- #3563 
- #3565 

### Upstream changes to solid-router
- #3592
- #3591
- #3589
- #3616 

### Passing E2E test suites
- [x]  basic
- [x]  website
- [x] scroll-restoration
- [x] server-functions

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Brenley Dueck <[email protected]>
Co-authored-by: Iha Shin <[email protected]>
Co-authored-by: Brenley Dueck <[email protected]>
leesb971204 pushed a commit to leesb971204/router that referenced this pull request Apr 16, 2025
@birkskyum @autofix-ci @leesb971204
refactor(start-client, start-server, start-server-functions-fetcher):…
72cce69 
… work towards making agnostic (TanStack#3546)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
leesb971204 pushed a commit to leesb971204/router that referenced this pull request Apr 16, 2025
@birkskyum @autofix-ci
@brenelz @XiNiHa @leesb971204
SolidJS driver for TanStack Start (TanStack#3522)
90f49de 
This PR introduce support for Solid to be used with TanStack Start.

There are several ongoing refactors that can influence the timing of
when it's most feasible to merge this.

### Status (build and run e2e/solid-start/basic)
- [X] SSR
- [x] API Routes
- [x] Server Functions
- [x] HMR
- [x] Streaming (/stream route)
- [X] Timely hydration

### Ongoing refactors

Refactor to make router packages (aka. client-only features) more
agnostic:
- TanStack#3552
- TanStack#3540
- TanStack#3538
- TanStack#3171

Refactor to make start packages (aka. server features) more agnostic:
- TanStack#3546 
- TanStack#3563 
- TanStack#3565 

### Upstream changes to solid-router
- TanStack#3592
- TanStack#3591
- TanStack#3589
- TanStack#3616 

### Passing E2E test suites
- [x]  basic
- [x]  website
- [x] scroll-restoration
- [x] server-functions

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Brenley Dueck <[email protected]>
Co-authored-by: Iha Shin <[email protected]>
Co-authored-by: Brenley Dueck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@birkskyum @schiller-manuel