Skip to content

The environment can now close right after being instantiated #4071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

vincentpierre
Copy link
Contributor

Proposed change(s)

env = UnityEnvironment("path-to-env")
env.close()

Now properly does nothing.
This change is on the C# side.
The environment currently on the registry will be unaffected by that fix.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@vincentpierre vincentpierre self-assigned this Jun 4, 2020
@vincentpierre vincentpierre merged commit b6f72c1 into master Jun 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the bug-fix-close-immediate branch June 4, 2020 22:46
vincentpierre added a commit that referenced this pull request Jun 9, 2020
vincentpierre added a commit that referenced this pull request Jun 9, 2020
ervteng pushed a commit that referenced this pull request Jun 9, 2020
ervteng pushed a commit that referenced this pull request Jun 9, 2020
* [bug-fix] Fix regression in --initialize-from feature (#4086)

* Fixed text in GettingStarted page specifying the logdir for tensorboard. Before it was in a directory summaries which no longer existed. Results are now saved to the results dir. (#4085)

* [refactor] Remove nonfunctional `output_path` option from TrainerSettings (#4087)

* Reverting bug introduced in #4071 (#4101)

Co-authored-by: Scott <[email protected]>
Co-authored-by: Vincent-Pierre BERGES <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants