[refactor] Remove nonfunctional output_path
option from TrainerSettings
#4087
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
In the settings change (#3936)
output_path
was left as a trainer configuration with the valuedefault
, but changing it had no effect, as the trainer always saves inresults/run_id/behavior_name
. This PR removes that option and removes it from the example YAMLs. Instead, theresults/run_id
directory is passed to the Trainer and Policy as an artifact directory. In the future, if we want this to be user-configurable, we should do it at the level ofrun-id
rather than trainer, so that all trainers for that run save in the same directoryThis also removes the
run_id
that was being passed to the trainer and not used.NOTE: Likely to cherry-pick this commit into the release branch as it avoid some confusion for our users.
Types of change(s)
Checklist