Skip to content

[refactor] Remove nonfunctional output_path option from TrainerSettings #4087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 9, 2020

Conversation

ervteng
Copy link
Contributor

@ervteng ervteng commented Jun 5, 2020

Proposed change(s)

In the settings change (#3936) output_path was left as a trainer configuration with the value default, but changing it had no effect, as the trainer always saves in results/run_id/behavior_name. This PR removes that option and removes it from the example YAMLs. Instead, the results/run_id directory is passed to the Trainer and Policy as an artifact directory. In the future, if we want this to be user-configurable, we should do it at the level of run-id rather than trainer, so that all trainers for that run save in the same directory

This also removes the run_id that was being passed to the trainer and not used.

NOTE: Likely to cherry-pick this commit into the release branch as it avoid some confusion for our users.

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Copy link
Contributor

@vincentpierre vincentpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it is safe to cherry pick such a large change into this release?

@ervteng
Copy link
Contributor Author

ervteng commented Jun 9, 2020

Do you think it is safe to cherry pick such a large change into this release?

I agree it's a bit of a risk. But I think the tradeoff in terms of user experience is worth it. What do you think?

@ervteng ervteng merged commit 09853de into master Jun 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the develop-outputpath branch June 9, 2020 18:42
ervteng pushed a commit that referenced this pull request Jun 9, 2020
ervteng pushed a commit that referenced this pull request Jun 9, 2020
* [bug-fix] Fix regression in --initialize-from feature (#4086)

* Fixed text in GettingStarted page specifying the logdir for tensorboard. Before it was in a directory summaries which no longer existed. Results are now saved to the results dir. (#4085)

* [refactor] Remove nonfunctional `output_path` option from TrainerSettings (#4087)

* Reverting bug introduced in #4071 (#4101)

Co-authored-by: Scott <[email protected]>
Co-authored-by: Vincent-Pierre BERGES <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants