Skip to content

[documentation] Fixed text in GettingStarted sepecifying tensorboard logdir #4085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

emmaajordan
Copy link
Contributor

Proposed change(s)

This pull requests corrects text in GettingStarted.md page specifying the logdir for tensorboard. Before it was in a directory called summaries which no longer existed. Results are now saved to the results directory.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

After running the training commands specified I ran the command tensorboard --logdir=results and it opened the correct folder.

…rd. Before it was in a directory summaries which no longer existed. Results are now saved to the results dir.
@emmaajordan emmaajordan requested a review from ervteng June 5, 2020 21:53
@CLAassistant
Copy link

CLAassistant commented Jun 5, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@ervteng ervteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@emmaajordan emmaajordan merged commit 341e17c into master Jun 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the develop-gettingstartedfixes branch June 8, 2020 21:08
ervteng pushed a commit that referenced this pull request Jun 9, 2020
…rd. Before it was in a directory summaries which no longer existed. Results are now saved to the results dir. (#4085)
ervteng pushed a commit that referenced this pull request Jun 9, 2020
* [bug-fix] Fix regression in --initialize-from feature (#4086)

* Fixed text in GettingStarted page specifying the logdir for tensorboard. Before it was in a directory summaries which no longer existed. Results are now saved to the results dir. (#4085)

* [refactor] Remove nonfunctional `output_path` option from TrainerSettings (#4087)

* Reverting bug introduced in #4071 (#4101)

Co-authored-by: Scott <[email protected]>
Co-authored-by: Vincent-Pierre BERGES <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants