[bug-fix] Fix regression in --initialize-from feature #4086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ervteng
changed the title
added 2 commits
June 5, 2020 17:01
chriselion
approved these changes
Jun 8, 2020
ervteng
pushed a commit
that referenced
this pull request
Jun 9, 2020
10 tasks
ervteng
pushed a commit
that referenced
this pull request
Jun 9, 2020
* [bug-fix] Fix regression in --initialize-from feature (#4086) * Fixed text in GettingStarted page specifying the logdir for tensorboard. Before it was in a directory summaries which no longer existed. Results are now saved to the results dir. (#4085) * [refactor] Remove nonfunctional `output_path` option from TrainerSettings (#4087) * Reverting bug introduced in #4071 (#4101) Co-authored-by: Scott <[email protected]> Co-authored-by: Vincent-Pierre BERGES <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
--initalize-fromwas using the wrong directory (it was loaded from therun-idinstead of theinitialize_path. This PR fixes that issue and adds a test. This was not broken in the last release and as such no changes to the changelog were made.NOTE: This commit will be cherry-picked into the release branch.
Types of change(s)
Checklist