rework jasmine to ts #5075
rework jasmine to ts #5075
Conversation
Update circleci to support async await. For the basicConf test suite: - Only run the element_spec test in the Protractor config, we will add back other specs as we migrate the basicConf off of the control flow. - In the Protractor configuration file, set `SELENIUM_PROMISE_MANAGER` to false. - Refactor to use async / await. - Refactor `var` to use either `const` or `let`.
- Travis tests are failing: removing the full test suite and only check against just lib_spec. Adding an issue item to resolve this at the end of the selenium4 roadmap. - Update circleci to 8.11 instead of 10. Version 8 is a more appropriate test to reflect a version we are supporting. - Use Travis support for node 9 and 10. Travis does not allow to specify node version 8.11 or 8.11.4. It has been reported to webdriver-manager that 8.12.0 was having issues.
- this.slow works only if we use `function` and not a fat arrow. - moved tests to be async / await where appropriate.
* move hybrid/async_spec off of the control flow * increase waiting time from 4s to 7s due to slow connection during SauceLabs tests in the ng2/async_spec
…5034) Driver providers and tests: - Use native promises over q promises in driver providers - Remove driverProviderUseExistingWebDriver since the generation of the selenium server is already accomplished when providing a selenium address in driverProvider.ts. Also clean up docs and tests. - Enabled the driverProviderLocal tests - Clean up JSDocs for q.promise Basic lib spec: - Remove auto unwrap test for a WebElement. Reference PR #3471 Browser: - Remove control flow from waitForAngularEnabled, waitForAngular, and angularAppRoot in the Browser class.
- remove q promises and webdriver promises from the runner, launcher, plugins, and taskRunner - add deprecated message to element explorer. - add unhandledRejection - update browser versions used in travis tests
- Removing the addMatchers test since we no longer support async calls resolve with jasminewd since we removed jasminewd. Also Jasmine does not appear to support async calls in custom expectations or the compare method.
- Current workaround to use webdriver-manager-replacement until we publish a beta release of webdriver-manager closes #5087
* deps(latest): upgrade to the gulp and typescript - add in @types/loglevel and @types/yargs for webdriver-manager - upgrade tslint clean up for tslint - use latest gulp 4 and remove run sequence since this feature is supported by gulp - remove compile to es5
- remove .ready since forking should automatically return a browser - getNewDriver should return a promised WebDriver that can be awaited - fix interaction tests and local driver tests - update unit tests for async await due to getNewDriver fix closes #5031
- elements workaround for WebElement.equals - added a better unhandled rejection warning message in the launcher - remove global function wrappers for mocha (these wrappers went away with control flow) - fix the attach to session driver provider Typing exported from Protractor: - removed ActionSequence and EventEmitter (actions is currently missing) - removed promise.Promise - removed Promise, defer, delayed, createFlow, controlFlow, all, fulfilled, filter, when Typings exported from WebDriver: - removed attachToSession - removed WebDriver instance methods: touchActions, call - removed WebElement getSize and getLocation for getRect - removed redefined global vars for testing - In the typings, we are missing Options.setScriptTimeout method. This should not impact users unless they are using the driver.manage() method. Tests: - fix element equals test - add missing 'await' in colorList test that is causing unhandled promise rejections. - remove control flow related tests - disable the install test. Installing from "file:../../" is not working. - fix the attach to session driver provider test to exit with a 1 if errors are encountered
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
1 similar comment
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
@cnishina , both CIs were passed |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
1 similar comment
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
|
The changes look acceptable. Some line clean up stuff. |
|
create new PR #5189 |
@cnishina , could you help me with
spec/custom/framework.js. How to modified this file properly?@heathkit , could you take a look at it if you have a time