Rework setupaAfterEach.js to ts #5111

CrispusDH · 2018-12-28T13:17:30Z

No description provided.

Update circleci to support async await. For the basicConf test suite: - Only run the element_spec test in the Protractor config, we will add back other specs as we migrate the basicConf off of the control flow. - In the Protractor configuration file, set `SELENIUM_PROMISE_MANAGER` to false. - Refactor to use async / await. - Refactor `var` to use either `const` or `let`.

- Travis tests are failing: removing the full test suite and only check against just lib_spec. Adding an issue item to resolve this at the end of the selenium4 roadmap. - Update circleci to 8.11 instead of 10. Version 8 is a more appropriate test to reflect a version we are supporting. - Use Travis support for node 9 and 10. Travis does not allow to specify node version 8.11 or 8.11.4. It has been reported to webdriver-manager that 8.12.0 was having issues.

…5003)

…5018)

…5013)

- this.slow works only if we use `function` and not a fat arrow. - moved tests to be async / await where appropriate.

…5020)

* move hybrid/async_spec off of the control flow * increase waiting time from 4s to 7s due to slow connection during SauceLabs tests in the ng2/async_spec

…l flow (#5021)

…5025)

…5034) Driver providers and tests: - Use native promises over q promises in driver providers - Remove driverProviderUseExistingWebDriver since the generation of the selenium server is already accomplished when providing a selenium address in driverProvider.ts. Also clean up docs and tests. - Enabled the driverProviderLocal tests - Clean up JSDocs for q.promise Basic lib spec: - Remove auto unwrap test for a WebElement. Reference PR #3471 Browser: - Remove control flow from waitForAngularEnabled, waitForAngular, and angularAppRoot in the Browser class.

- remove q promises and webdriver promises from the runner, launcher, plugins, and taskRunner - add deprecated message to element explorer. - add unhandledRejection - update browser versions used in travis tests

closes #5092

- remove .ready since forking should automatically return a browser - getNewDriver should return a promised WebDriver that can be awaited - fix interaction tests and local driver tests - update unit tests for async await due to getNewDriver fix closes #5031

- elements workaround for WebElement.equals - added a better unhandled rejection warning message in the launcher - remove global function wrappers for mocha (these wrappers went away with control flow) - fix the attach to session driver provider Typing exported from Protractor: - removed ActionSequence and EventEmitter (actions is currently missing) - removed promise.Promise - removed Promise, defer, delayed, createFlow, controlFlow, all, fulfilled, filter, when Typings exported from WebDriver: - removed attachToSession - removed WebDriver instance methods: touchActions, call - removed WebElement getSize and getLocation for getRect - removed redefined global vars for testing - In the typings, we are missing Options.setScriptTimeout method. This should not impact users unless they are using the driver.manage() method. Tests: - fix element equals test - add missing 'await' in colorList test that is causing unhandled promise rejections. - remove control flow related tests - disable the install test. Installing from "file:../../" is not working. - fix the attach to session driver provider test to exit with a 1 if errors are encountered

- Use `() => Promise<boolean>` over `Function` typings. - Fix an ExpectedConditions test where it was set to a const. - Fix a TypeScript typing interface issue with RunResults in taskRunner.

CrispusDH · 2018-12-28T13:17:39Z

Reference #5061

googlebot · 2018-12-28T13:18:06Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

googlebot · 2018-12-28T13:18:07Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

googlebot · 2018-12-28T13:18:15Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

googlebot · 2018-12-28T13:18:16Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

…tor into setup-after-each-to-ts

CrispusDH · 2018-12-28T18:11:49Z

CI is passed

cnishina and others added 30 commits November 7, 2018 10:43

chore(test): cleanup async await in element_spec.js (#4999)

f11cdf4

chore(test): move lib_spec.js off of the control flow (#5000)

5900571

chore(test): move handling_spec off of the control flow (#5010)

4d67fed

chore(test): move navigation_spec off of the control flow (#5011)

37043ca

chore(test): move locators_spec.js off of the control flow (#5001)

c957c58

chore(test): move mockmodule_spec.js off of the control flow (#5002)

ae84f95

chore(test): move altRoot and inferRoot test off of the control flow (#…

ea348ba

…5003)

chore(test): use native promises instead of q on onPrepare (#5005)

4e149af

chore(test): move plugins tests off of the control flow and remove q (#…

8d900f9

…5018)

chore(test): use native promises instead of q onCleanUp (#5004)

d4f4c09

chore(test): move restart_spec off of the control flow (#5014)

d931bcd

chore(test): move withLogin test off of the control flow (#5008)

5b7160f

chore(test): move expected_conditions_spec off of the control flow (#…

601bd53

…5013)

chore(test): clean up mocha tests (#5007)

672f04b

- this.slow works only if we use `function` and not a fat arrow. - moved tests to be async / await where appropriate.

chore(test): move polling_spec off of the control flow (#5012)

6e023e3

chore(test): move synchronize_spec off of the control flow (#5016)

8fd6370

chore(test): clean up no control flow typescript tests (#5023)

eb5913a

chore(test): move controlLock test off of the control flow (#5022)

ba33f08

chore(test): move restartBrowserBetweenTests off of the control flow (#…

7b77acf

…5020)

chore(test): move interaction test off of the control flow (#5019)

7172e48

chore(test): move hybrid/async_spec off of the control flow (#5024)

c0855fc

* move hybrid/async_spec off of the control flow * increase waiting time from 4s to 7s due to slow connection during SauceLabs tests in the ng2/async_spec

chore(test): update provider and capabilities tests off of the contro…

bf3ffba

…l flow (#5021)

chore(test): move custom/smoke_spec off of the control flow (#5026)

6b3d9c0

chore(test): move noGlobals/noGlobals_spec off of the control flow (#…

02b3cb9

…5025)

chore(promises): move locator wdpromise to native Promise (#5044)

51cb087

chore(promises): move element wdpromise to native Promise (#5047)

beb961d

chore(promises): remove q promises and webdriver promises (#5052)

e458025

- remove q promises and webdriver promises from the runner, launcher, plugins, and taskRunner - add deprecated message to element explorer. - add unhandledRejection - update browser versions used in travis tests

cnishina and others added 14 commits December 18, 2018 23:04

chore(bin): update webdriver-manager require to use the cli (#5093)

3cbbf8a

closes #5092

typings(selenium): try out new version of typings (#5084)

e73c101

docs(api): update examples to use async/await (#5081)

cf03143

chore(elementexplorer): remove explorer bin file (#5094)

53df06a

chore(debugprint): convert debugprint to TypeScript (#5074)

7654039

merge conflicts

4f43d9b

return debugprint

61913bc

chore(expectedConditions): update generic Function typings (#5101)

f872aa7

- Use `() => Promise<boolean>` over `Function` typings. - Fix an ExpectedConditions test where it was set to a const. - Fix a TypeScript typing interface issue with RunResults in taskRunner.

deps(jasmine): upgrade jasmine 3.3 (#5102)

a33918a

chore(webdriver-manager): use [email protected]

375daf8

chore(release): release 6.0.0-beta and update the changelog

205c4d8

rework setupAfterEach.js to ts

9287f04

googlebot added the cla: no label Dec 28, 2018

CrispusDH added 6 commits December 28, 2018 15:35

fix linter

b1b8c0d

Merge branch 'selenium4' into setup-after-each-to-ts

3862d5b

fix formatter

fb41a41

Merge branch 'setup-after-each-to-ts' of github.com:CrispusDH/protrac…

3250cde

…tor into setup-after-each-to-ts

change path to setupAfterEach

d6134ad

change import in js file

d7a21c1

cnishina force-pushed the selenium4 branch from cd95794 to 8e43822 Compare March 23, 2019 00:15

CrispusDH changed the base branch from selenium4 to master March 25, 2019 08:35

CrispusDH closed this Apr 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rework setupaAfterEach.js to ts #5111

Rework setupaAfterEach.js to ts #5111

CrispusDH commented Dec 28, 2018

CrispusDH commented Dec 28, 2018

googlebot commented Dec 28, 2018

googlebot commented Dec 28, 2018

googlebot commented Dec 28, 2018

googlebot commented Dec 28, 2018

CrispusDH commented Dec 28, 2018

Rework setupaAfterEach.js to ts #5111

Rework setupaAfterEach.js to ts #5111

Conversation

CrispusDH commented Dec 28, 2018

CrispusDH commented Dec 28, 2018

googlebot commented Dec 28, 2018

googlebot commented Dec 28, 2018

googlebot commented Dec 28, 2018

googlebot commented Dec 28, 2018

CrispusDH commented Dec 28, 2018