Skip to content

chore: Support configuration for max grpc inbound message #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

javier-aliaga
Copy link
Contributor

Description

Support for grpc max inbound message and metadata size

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1410

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@javier-aliaga javier-aliaga force-pushed the javi-add-grpc-max-inbound-config branch from 578aa42 to 31504ca Compare June 10, 2025 08:37
@javier-aliaga javier-aliaga marked this pull request as ready for review June 10, 2025 08:46
@javier-aliaga javier-aliaga requested review from a team as code owners June 10, 2025 08:46
Copy link
Collaborator

@salaboy salaboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@siri-varma siri-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cicoyle cicoyle merged commit e13f934 into dapr:master Jun 10, 2025
9 checks passed
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.38%. Comparing base (d759c53) to head (31504ca).
Report is 166 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1411      +/-   ##
============================================
+ Coverage     76.91%   78.38%   +1.46%     
- Complexity     1592     1847     +255     
============================================
  Files           145      226      +81     
  Lines          4843     5718     +875     
  Branches        562      601      +39     
============================================
+ Hits           3725     4482     +757     
- Misses          821      916      +95     
- Partials        297      320      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcduiker
Copy link
Contributor

@holopin-bot @javier-aliaga Thank you! Here's a digital badge as a small token of appreciation.

Copy link

holopin-bot bot commented Jun 11, 2025

Congratulations @javier-aliaga, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmbs0nspg668407lamgtcyy4l

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

cicoyle pushed a commit to cicoyle/java-sdk that referenced this pull request Jun 11, 2025
cicoyle added a commit that referenced this pull request Jun 11, 2025
cicoyle pushed a commit to cicoyle/java-sdk that referenced this pull request Jul 25, 2025
@cicoyle cicoyle mentioned this pull request Jul 25, 2025
cicoyle added a commit that referenced this pull request Jul 29, 2025
siri-varma pushed a commit to siri-varma/java-sdk that referenced this pull request Aug 6, 2025
siri-varma pushed a commit to siri-varma/java-sdk that referenced this pull request Aug 12, 2025
…dapr#1414)

Signed-off-by: Javier Aliaga <[email protected]>
Co-authored-by: Javier Aliaga <[email protected]>
Signed-off-by: siri-varma <[email protected]>
siri-varma pushed a commit to siri-varma/java-sdk that referenced this pull request Aug 12, 2025
…dapr#1414)

Signed-off-by: Javier Aliaga <[email protected]>
Co-authored-by: Javier Aliaga <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java SDK doesn't respect Dapr sidecar max-body-size configuration for large gRPC messages
6 participants