[plugin_platform_interface] typo in link #2888

jarrodcolburn · 2020-07-21T18:46:03Z

The link for federated flutter plugins https://fluter.dev/go/federated-plugins,
fluter.dev is missing second 't'.
fluter vs
flutter

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

The link for federated flutter plugins https://fluter.dev/go/federated-plugins, fluter.dev is missing second 't'. `fluter` vs `flutter`

ditman · 2020-07-21T20:09:06Z

Ohh, good catch! Can you do a patch version bump in this package's pubspec.yaml and CHANGELOG.md? That way we can publish the fix to pub.dev. (I think v 1.0.2+1 should work)

jarrodcolburn · 2020-07-21T21:33:31Z

Ohh, good catch! Can you do a patch version bump in this package's pubspec.yaml and CHANGELOG.md? That way we can publish the fix to pub.dev. (I think v 1.0.2+1 should work)

Yes, I'll try.

Since that requires editing the changelog anyways. Can I go ahead and incorporate issue #2879 ?
Which is also just a simple typo (this time on pubspec)

Pubspec.yaml homepage is:
github.com/flutter/plugins/plugin_platform_interface

corrected: (add packages)
github.com/flutter/plugins/tree/master/packages/plugin_platform_interface

ditman · 2020-07-21T21:50:08Z

@JarrodCColburn yes, please! Thanks for consolidating all the fixes to this package!

jarrodcolburn · 2020-07-21T22:07:07Z

Updated.

ditman · 2020-08-19T20:59:30Z

I had to fix the versioning, analyzer didn't like 1.0.2+1 (not sure why), so I bumped this to 1.0.3. I'll merge this as soon as the CI passes!

ditman · 2020-08-20T19:25:17Z

@JarrodCColburn do you mind rebasing this with the latest master? The test that is failing was fixed a few days ago.

Thanks!

…port path" (flutter#2896) * Revert "[path_provider] Use the application ID in the application support path (flutter#2845)" This reverts commit 7d4a918. * bump version to satisfy the machine. Also fix linting issue caught because of changes in this folder.

* Make package:e2e a relative reference

…ils (flutter#2866) * [e2e] Fix incorrect test results when one test passes then another fails For example, the following test will result in an error reported for the first test case. ``` void main() { testWidgets('a test that passes', (tester) async { expect(true, true); }); testWidgets('a test that fails', (tester) async { expect(true, false); }); } ``` We need to reset `reportTestException` back to the previous value after completion of `runTest`, or repeated failures will cause the exception handler for a previous test to be invoked, as they "stack". Instead of reseting it, however, do this once in the constructor because the test description is already provided by the function signature. * Add a mechanism for testing test results

* clarify e2e on firebase

…n. (flutter#2903) This change tweaks slightly the core maps plugin and the platform interface package to make the web implementation possible. The most important changes are two: * The core plugin now passes a constant identifier to the buildView platform call, so the web version can cache effectively the contents of the platform view, so it doesn't repaint. This might go away once Scenelets for web come online. * The platform interface now encodes the (optional) width and height of custom Icons for Markers, so the web can render High DPI assets at the correct size. The rest are some examples to the 'example' app so it can be run on web.

…atcher (flutter#2906)

…#2908) This method gives the plugin writers a chance to release the resources that they've acquired throughout the operation of the plugin (think of it as an "inverse" of the "init" method).

…lutter#2848)

(To be moved to flutter_test)

…version (flutter#2924)

… mode (flutter#2927)

(This is preparation for the federation of the plugin)

package:platform required a breaking change in the behavior of FakePlatform in order to enable null safety, but there will be no other breaking changes in 3.X Since this does not affect path provider or local_auth, the pubspec constraint can be increased.

…#2938) This reverts commit 77fbfcd.

…lutter#2938)" (flutter#2939) This reverts commit d4750ea.

* Use shard variables correctly in incremental_build.sh * Add more shards for the apk tasks.

This is the platform interface package of the federated device_info plugin.

This package introduces the first version of the google_maps_flutter_web plugin. See README for installation instructions. Co-authored-by: chung2012 <[email protected]>

* e2e -> integration_test and associated version bumps

…r#2945)

googlebot · 2020-08-20T23:58:37Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

jarrodcolburn · 2020-08-21T00:10:19Z

@ditman I tried. Can you check that it looks right? Not used to rebasing on large projects.

It pulled in a bunch of stuff and looks either 100% right or 100% wrong, but I can't tell. If wrong, let me know and I'll take another swing at it. thanks

ditman · 2020-08-23T23:01:04Z

This is looking a bit weird. How did you rebase your branch?

fluttergithubbot · 2020-12-16T16:18:10Z

This pull request is not suitable for automatic merging in its current state.

Please get at least one approved review before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.
The status or check suite cla/google has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite format has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite build_all_plugins_apk has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite build-apks+java-test+firebase-test-lab has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite build-linux+drive-examples has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite build_all_plugins_ipa has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite lint_darwin_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite build-ipas+drive-examples has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite build-apps+drive-examples has failed. Please fix the issues identified (or deflake) before re-applying this label.

cyanglaz · 2021-01-14T19:48:45Z

I'm going to close the PR because the CLA is not signed. Feel free to ping me when the CLA is signed and I'll re-open the PR. Or you can open a new PR after signing the CLA.

[plugin_platform_interface] typo in link

9d126ab

The link for federated flutter plugins https://fluter.dev/go/federated-plugins, fluter.dev is missing second 't'. `fluter` vs `flutter`

googlebot added the cla: yes label Jul 21, 2020

jarrodcolburn mentioned this pull request Jul 21, 2020

[plugin_platform_interface]fix:GoLink inaccessible #2880

Closed

13 tasks

jarrodcolburn added 3 commits July 21, 2020 17:56

Update changelog 1.0.2+1

b9a6be4

Typo: Fix homepage

0a5fd3d

bump version

8480743

ditman added 2 commits August 19, 2020 13:55

Update CHANGELOG.md

4a28a75

Update pubspec.yaml

92c0bbc

ditman self-requested a review August 19, 2020 20:56

ditman added the waiting for test harness label Aug 19, 2020

dnfield and others added 14 commits August 20, 2020 19:57

Make package:e2e a relative reference (flutter#2889)

db07cd3

* Make package:e2e a relative reference

Clarify e2e readme for running on firebase test lab (flutter#2898)

b2766ba

* clarify e2e on firebase

Fixed typo manuelly for manually (flutter#2902)

3e7cca2

[e2e] Add new e2e_driver for handling response data and performance w…

22f31a4

…atcher (flutter#2906)

[google_maps_flutter_platform_interface] Add dispose method. (flutter…

17cf861

…#2908) This method gives the plugin writers a chance to release the resources that they've acquired throughout the operation of the plugin (think of it as an "inverse" of the "init" method).

[camera] Improving handling when camera permissions are not granted. (f…

05f45da

…lutter#2848)

[e2e] Revert performance tracker utilities (flutter#2917)

8dd2c6c

(To be moved to flutter_test)

[google_maps_flutter] Pin GoogleMaps cocoapod dep to last good known …

7de16cd

…version (flutter#2924)

[google_maps_flutter] Call platform.dispose from widget. (flutter#2909)

2bc253a

[video_player_platform_interface] Add interface changes for audio mix…

a789e4e

… mode (flutter#2927)

[device_info] Moved device_info to a subdir (flutter#2923)

503b567

(This is preparation for the federation of the plugin)

wwwdata and others added 11 commits August 20, 2020 19:57

[video_player] Set audio mix options (flutter#2922)

cee1e0a

Revert "[video_player] Set audio mix options (flutter#2922)" (flutter…

9e01f9c

…#2938) This reverts commit 77fbfcd.

Revert "Revert "[video_player] Set audio mix options (flutter#2922)" (f…

b6c4e0b

…lutter#2938)" (flutter#2939) This reverts commit d4750ea.

Fix sharding and shard count on apk tests (flutter#2936)

dad123c

* Use shard variables correctly in incremental_build.sh * Add more shards for the apk tasks.

[device_info_platform_interface] Introduce package (flutter#2929)

570ffd6

This is the platform interface package of the federated device_info plugin.

[google_maps_flutter_web] First version of the plugin. (flutter#2933)

7feea75

This package introduces the first version of the google_maps_flutter_web plugin. See README for installation instructions. Co-authored-by: chung2012 <[email protected]>

[e2e] Update code onwer. (flutter#2915)

a075d4c

Rename e2e -> integration_test (flutter#2918)

6bd2999

* e2e -> integration_test and associated version bumps

[device_info] Port device_info to use platform interface (flutter#2942)

5461bb4

[google_maps_flutter_web] Move e2e tests to integration_test. (flutte…

bf8fd44

…r#2945)

jarrodcolburn requested review from amirh, bkonyi, bparrishMines, cyanglaz, dnfield, LHLL, matthew-carroll and mklim as code owners August 20, 2020 23:58

googlebot added cla: no and removed cla: yes labels Aug 20, 2020

fluttergithubbot removed the waiting for test harness label Dec 16, 2020

cyanglaz added the waiting for test harness label Dec 16, 2020

cyanglaz closed this Jan 14, 2021

kamimoo mentioned this pull request Jul 8, 2021

[plugin_platform_interface] Fix README broken link #4143

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[plugin_platform_interface] typo in link #2888

[plugin_platform_interface] typo in link #2888

Uh oh!

jarrodcolburn commented Jul 21, 2020 •

edited

Loading

Uh oh!

ditman commented Jul 21, 2020

Uh oh!

jarrodcolburn commented Jul 21, 2020 •

edited

Loading

Uh oh!

ditman commented Jul 21, 2020

Uh oh!

jarrodcolburn commented Jul 21, 2020

Uh oh!

ditman commented Aug 19, 2020

Uh oh!

ditman commented Aug 20, 2020

Uh oh!

googlebot commented Aug 20, 2020

Uh oh!

jarrodcolburn commented Aug 21, 2020 •

edited

Loading

Uh oh!

ditman commented Aug 23, 2020

Uh oh!

fluttergithubbot commented Dec 16, 2020

Uh oh!

cyanglaz commented Jan 14, 2021

Uh oh!

Uh oh!

[plugin_platform_interface] typo in link #2888

[plugin_platform_interface] typo in link #2888

Uh oh!

Conversation

jarrodcolburn commented Jul 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Checklist

Breaking Change

Uh oh!

ditman commented Jul 21, 2020

Uh oh!

jarrodcolburn commented Jul 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ditman commented Jul 21, 2020

Uh oh!

jarrodcolburn commented Jul 21, 2020

Uh oh!

ditman commented Aug 19, 2020

Uh oh!

ditman commented Aug 20, 2020

Uh oh!

googlebot commented Aug 20, 2020

Uh oh!

jarrodcolburn commented Aug 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ditman commented Aug 23, 2020

Uh oh!

fluttergithubbot commented Dec 16, 2020

Uh oh!

cyanglaz commented Jan 14, 2021

Uh oh!

Uh oh!

jarrodcolburn commented Jul 21, 2020 •

edited

Loading

jarrodcolburn commented Jul 21, 2020 •

edited

Loading

jarrodcolburn commented Aug 21, 2020 •

edited

Loading