Skip to content

feat(select): support multiple values in the popover interface #22303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 107 commits into from
Closed

feat(select): support multiple values in the popover interface #22303

wants to merge 107 commits into from

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Oct 12, 2020 •
edited
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: fixes #12310

What is the new behavior?

  • Enables support for multiple in a select to work with the popover interface
  • Updates the MD UI to remove the radios and match the MD spec

Does this introduce a breaking change?

  • Yes
  • No
  • Probably

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Oct 12, 2020
@brandyscarney brandyscarney added this to the 6.0.0 milestone Nov 30, 2020
liamdebeasi and others added 22 commits January 20, 2021 14:02
@liamdebeasi
breaking(config): remove experimentalTransitionShadow config option (#…
6f2cbe6 
…22797)
@liamdebeasi
chore(): update next with latest from main branch
bfbc1f5
@liamdebeasi
refactor(toast): whitespace variable now defaults to normal (#22866)
9b78689 
BREAKING CHANGE: The `--white-space` CSS Variable now defaults to `normal`.
@liamdebeasi
refactor(header): removed border from last toolbar when using collaps…
c72bc5d 
…ible large title (#22891)

resolves #22777

BREAKING CHANGE: The last toolbar in the header with a collapsible large title no longer has a border.
@liamdebeasi
chore(): sync with master branch
acf0422
@liamdebeasi
refactor(ios): update toolbar and tabbar default background colors (#…
3d615cb 
…22852)

resolves #22780

BREAKING CHANGE: The tab bar and toolbar default background colors have been updated to better reflect the latest iOS styles.
@EinfachHans @liamdebeasi
feat(spinner): add lines-sharp, lines-sharp-small, update styles for …
2a5b272 
…ios 14 (#22397)

Co-authored-by: Liam DeBeasi <[email protected]>
@liamdebeasi
chore(): sync with master
7246623
@liamdebeasi
refactor(angular): remove Config.set() method (#22918)
9e05891 
BREAKING CHANGE: The `Config.set()` method has been removed. See https://ionicframework.com/docs/angular/config for examples on how to set config globally, per-component, and per-platform.
@liamdebeasi
refactor(vue): remove support for child routes nested inside of tabs (#…
75458ac 
…22919)

BREAKING CHANGE: Support for child routes nested inside of tabs has been removed to better conform to Vue Router's best practices. Additional routes should be written as sibling routes with the parent tab as the path prefix.
@EinfachHans @liamdebeasi
refactor(refresher): add new ios 14 pull to refresh style (#22398)
84d8639 
resolves #22783

Co-authored-by: Liam DeBeasi <[email protected]>
@liamdebeasi
chore(): sync next with master
96abe22 
chore(): sync next with master
@liamdebeasi
chore(): sync vue tabs changes with master
4cbf610
@liamdebeasi
chore(): sync next with master
2c53363
@liamdebeasi
feat(accordion): add accordion and accordion-group components (#22865)
073883a 
resolves #17094
@liamdebeasi
chore(): sync with master
4fb81b7
@liamdebeasi
chore(): sync with master
d4e7736
@liamdebeasi
chore(): resolve merge conflicts
aede8e6
@liamdebeasi
chore(): sync with master
51c62fa 
chore(): sync with master
@liamdebeasi
refactor(vue): drop support for "on" prefixed overlay events and bump…
6fcb3a6 
… minimum required version of vue to 3.0.6 (#23229)

refactor(vue): drop support for "on" prefixed overlay events and bump minimum required version of vue to 3.0.6

BREAKING CHANGE:

- Dropped support for prefixed overlay events in favor of non prefixed events (I.e. `@onDidDismiss` becomes `@didDismiss`).
- Minimum required version of Vue is now Vue v3.0.6 or newer.
@liamdebeasi
feat(popover): popover can now be used inline (#23231)
308fa1c 
BREAKING CHANGE: Converted `ion-popover` to use the Shadow DOM.
@willmartian
fix(modal): add additional padding to toolbars in iOS modal (#23262)
a037b65 
Resolves #22778
liamdebeasi and others added 27 commits June 30, 2021 14:27
@liamdebeasi
fix(popover): update animation to better match MD spec (#23541)
bdb95b7
@brandyscarney
fix(item): move label and highlight item when focused with tab
eb6f93b
@brandyscarney
fix(select): design updates to match spec and cover on popover
70f14bb
@brandyscarney
Merge branch 'next' into feat-select-popover-multiple
c544f70
@brandyscarney
fix(select-popover): padding should be in md
630cf84
@liamdebeasi
fix(datetime): scroll position no longer gets reset when using dateti…
b735b58 
…me in overlay (#23543)
@liamdebeasi
fix merge conflicts
1bb01c7
@liamdebeasi
chore(): sync next with 5.6.11 changes
873284a 
chore(): sync next with 5.6.11 changes
@liamdebeasi
chore(): fix merge conflict
2e30ad8
@liamdebeasi
6.0.0-beta.1
9037103
@liamdebeasi
merge release-6.0.0-beta.1
de6c024 
6.0.0-beta.1
@liamdebeasi
docs(datetime): add correct angular usage example in a modal (#23564)
be4f89e
@liamdebeasi
fix(angular): modal and popover now have correct props defined on ang…
e5a7b34 
…ular component (#23565)
@brandyscarney
fix(popover): ignore body padding when the size is cover
2df47cb
@brandyscarney
fix(select): highlight and rotate dropdown arrow for other labels
4eaf809
@brandyscarney
Merge branch 'next' into feat-select-popover-multiple
a11e698
@brandyscarney
style: lint
f3df2f8
@liamdebeasi
fix margin with ios cover popover
afbadd6
@liamdebeasi
arrow rotation is now correct
a161e8e
@liamdebeasi
fix alignment for other selects
1b817de
@liamdebeasi
ensure select is adjusted for floating label
9663413
@liamdebeasi
arrow is now positioned correctly with stacked labels
34f045f
@liamdebeasi
lint
e08a65f
@liamdebeasi
improve arrow positioning logic
9132706
@liamdebeasi
pass focus
8be9ae1
@liamdebeasi
update test
4c2739d
@liamdebeasi
improve readability
f47e203
@liamdebeasi
Copy link
Contributor

Closing in favor of #23474.

@liamdebeasi liamdebeasi deleted the feat-select-popover-multiple branch July 22, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: angular @ionic/angular package package: core @ionic/core package package: react @ionic/react package package: vue @ionic/vue package
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

get rid of radio buttons in ion-select popover.
8 participants
@brandyscarney @liamdebeasi @mxlle @SpraylnlPray @EinfachHans @willmartian @ltm @devinshoemaker