Skip to content

[0.66] Handle "Escape" key for TextInput #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 26 commits into from
Closed

[0.66] Handle "Escape" key for TextInput #1048

wants to merge 26 commits into from

Conversation

Saadnajmi
Copy link
Collaborator

Cherry pick #1044 into 0.66-stable

amgleitman and others added 26 commits February 5, 2022 14:06
@amgleitman
fix (iOS): Only try to make the alert window key if the app recognize…
2732ea2 
…s it (microsoft#1008) (microsoft#1010)
@rnbot
Applying package update to 0.66.9 ***NO_CI***
0b58ac1
@amgleitman
Remove duplicate RCTDevSettingsInspectable
504349e
@amgleitman
Mark new RCTEventEmitter properties as nullable
e9cc8e8
@amgleitman
Merge pull request microsoft#1013 from amgleitman/amgleitman/0.66-sta…
040118c 
…ble-cherry-pick-1004

Cherry pick microsoft#1004 into 0.66-stable
@rnbot
Applying package update to 0.66.10 ***NO_CI***
fc957e7
@tido64
fix: Hermes no longer builds without Exception.cpp (microsoft#982) (m…
bb08860 
…icrosoft#1021)
@mganandraj
Adding patches required for running RN66 in Office apps (microsoft#1023)
fc720c2
@rnbot
Applying package update to 0.66.11 ***NO_CI***
9e17bf4
@amgleitman
Make RCTBundleManager's bundleURL a strong property
8862ef5
@amgleitman
Merge pull request microsoft#1027 from amgleitman/amgleitman/0.66-sta…
4bed389 
…ble-cherry-pick-1025

[0.66-stable cherry pick microsoft#1025] Make RCTBundleManager's bundleURL a strong property
@rnbot
Applying package update to 0.66.12 ***NO_CI***
2291936
@Saadnajmi @pull
@ryanlntn @ntre @mganandraj
[0.66] Backport a few of 10.15+ changes to 0.66 stable (microsoft#1030)
7b6aa55 
* RCTSwitch: Use NSSwitch instead of NSButton (microsoft#924)

* add pull yml

* match handleOpenURLNotification event payload with iOS (microsoft#755) (#2)

Co-authored-by: Ryan Linton <[email protected]>

* [pull] master from microsoft:master (#11)

* Deprecated api (microsoft#853)

* Remove deprecated/unused context param
* Update a few Mac deprecated APIs

* Packing RN dependencies, hermes and ignoring javadoc failure,  (microsoft#852)

* Ignore javadoc failure

* Bringing few more changes from 0.63-stable

* Fixing a patch in engine selection

* Fixing a patch in nuget spec

* Fixing the output directory of nuget pack

* Packaging dependencies in the nuget

* Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (microsoft#855)

* add pull yml

* match handleOpenURLNotification event payload with iOS (microsoft#755) (#2)

Co-authored-by: Ryan Linton <[email protected]>

* fix mouse evetns on pressable

* delete extra yml from this branch

* Add macOS tags

* reorder props to have onMouseEnter/onMouseLeave always be before onPress

Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <[email protected]>

* Grammar fixes. (microsoft#856)

Updates simple grammar issues.

Co-authored-by: Nick Trescases <[email protected]>
Co-authored-by: Anandraj <[email protected]>
Co-authored-by: Saad Najmi <[email protected]>
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <[email protected]>
Co-authored-by: Muhammad Hamza Zaman <[email protected]>

* Use NSSwitch

* remove change from my fork

Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <[email protected]>
Co-authored-by: Nick Trescases <[email protected]>
Co-authored-by: Anandraj <[email protected]>
Co-authored-by: Muhammad Hamza Zaman <[email protected]>

* DynamicColorMacOS fixes (microsoft#1028)

* Use initWithDynamicProvider + Add HC Support

* Update log error

* replace all references to 10.14 (microsoft#938)

* Replace currentAppearance with currentDrawingAppearance on macOS 11+ (microsoft#1029)

* Manually cherry-pick microsoft#1012

Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Ryan Linton <[email protected]>
Co-authored-by: Nick Trescases <[email protected]>
Co-authored-by: Anandraj <[email protected]>
Co-authored-by: Muhammad Hamza Zaman <[email protected]>
@rnbot
Applying package update to 0.66.13 ***NO_CI***
449e1d0
@rasaha91
Adding patch to ensure rn-tester for android builds successfully
a5459c8
@rasaha91
Adding step to build rn-tester app for android in PR pipeline
4a59492
@HeyImChris
[0.66] Enable ASAN and clang static analyzer (microsoft#1033)
42b57b3
@rnbot
Applying package update to 0.66.14 ***NO_CI***
90858ec
@rasaha91
Merge pull request microsoft#1031 from rasaha91/0.66-cherry-pick-andr…
76d768f 
…oid-patch-fix

Adding patch to ensure rn-tester for android builds successfully
@rnbot
Applying package update to 0.66.15 ***NO_CI***
f2506ad
@rasaha91
Merge pull request microsoft#1032 from rasaha91/0.66-cherry-pick-buil…
3b9c086 
…d-rntester-pr

Adding step to build rn-tester app for android in PR pipeline
@rnbot
Applying package update to 0.66.16 ***NO_CI***
f755f9b
@rasaha91
Cleaning up parts of android-pr.yml
d395dcd
@rasaha91
Merge pull request microsoft#1039 from rasaha91/cherry-pick-pr-cleanup
a30f37b 
Cleaning up parts of android-pr.yml
@rnbot
Applying package update to 0.66.17 ***NO_CI***
b758848
@Saadnajmi
Handle "Escape" key for TextInput (microsoft#1044)
dcbab49 
* wip

* onKeyPress works

* Minor cleanup

* spaces not tabs
@Saadnajmi Saadnajmi requested a review from a team as a code owner February 24, 2022 05:30
@pull-bot
Copy link

Fails
🚫

❔ This pull request needs a description.
Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against dcbab49

@Saadnajmi Saadnajmi closed this Feb 24, 2022
@Saadnajmi Saadnajmi deleted the textinput-66 branch February 24, 2022 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Saadnajmi @pull-bot @amgleitman @rnbot @tido64 @mganandraj @rasaha91 @HeyImChris