url: replaced slice with at

[Connormiha]

I replaced slice(-1) with at(-1) to avoid creating a new collection, since at() directly accesses the element without copying the array.
I did the same for a string in another place — replaced slice(-1) with at(-1) for consistency and simplicity.

[nodejs-github-bot]

Review requested:

• @nodejs/url

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.03%. Comparing base (5e70d83) to head (c983dcd).
⚠️ Report is 382 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #59181      +/-   ##
==========================================
- Coverage   90.05%   90.03%   -0.02%     
==========================================
  Files         648      648              
  Lines      190978   190980       +2     
  Branches    37431    37433       +2     
==========================================
- Hits       171979   171958      -21     
- Misses      11616    11653      +37     
+ Partials     7383     7369      -14     

Files with missing lines	Coverage Δ
lib/url.js	100.00% <100.00%> (ø)

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[gurgunday]

lgtm

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/68163/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/68911/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/68922/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/68956/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/59181
✔  Done loading data for nodejs/node/pull/59181
----------------------------------- PR info ------------------------------------
Title      url: replaced slice with at (#59181)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     Connormiha:optimize-liburl-strings -> nodejs:main
Labels     url, author ready, needs-ci
Commits    4
 - url: replaced slice with at
 - url: use primordials for safe method
 - url: fix array sstring primordials method
 - url: array length instead of ArrayPrototypeAt
Committers 1
 - Mikhail Bodrov <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/59181
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Daniel Lemire <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/59181
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Daniel Lemire <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 23 Jul 2025 09:20:41 GMT
   ✔  Approvals: 4
   ✔  - Jordan Harband (@ljharb): https://github.com/nodejs/node/pull/59181#pullrequestreview-3047845591
   ✔  - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/59181#pullrequestreview-3049431139
   ✔  - Daniel Lemire (@lemire): https://github.com/nodejs/node/pull/59181#pullrequestreview-3050319030
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/59181#pullrequestreview-3053156183
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-08-29T08:47:23Z: https://ci.nodejs.org/job/node-test-pull-request/68956/
- Querying data for job/node-test-pull-request/68956/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 59181
From https://github.com/nodejs/node
 * branch                  refs/pull/59181/merge -> FETCH_HEAD
✔  Fetched commits as cbabdbf3f246..c983dcdba5ce
--------------------------------------------------------------------------------
[main 8573be56e9] url: replaced slice with at
 Author: Mikhail Bodrov <[email protected]>
 Date: Wed Jul 23 12:16:09 2025 +0300
 1 file changed, 2 insertions(+), 2 deletions(-)
[main 7395156fb4] url: use primordials for safe method
 Author: Mikhail Bodrov <[email protected]>
 Date: Wed Jul 23 17:58:02 2025 +0300
 1 file changed, 4 insertions(+), 2 deletions(-)
[main 9bcdaef089] url: fix array sstring primordials method
 Author: Mikhail Bodrov <[email protected]>
 Date: Wed Jul 23 18:02:56 2025 +0300
 1 file changed, 2 insertions(+), 1 deletion(-)
[main ea032247aa] url: array length instead of ArrayPrototypeAt
 Author: Mikhail Bodrov <[email protected]>
 Date: Wed Jul 23 21:38:29 2025 +0300
 1 file changed, 1 insertion(+), 2 deletions(-)
   ✔  Patches applied
There are 4 commits in the PR. Attempting autorebase.
Rebasing (2/8)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
url: replaced slice with at
PR-URL: #59181

Reviewed-By: Jordan Harband <[email protected]>

Reviewed-By: Zeyu "Alex" Yang <[email protected]>

Reviewed-By: Daniel Lemire <[email protected]>

Reviewed-By: Luigi Pinca <[email protected]>
[detached HEAD ef81653286] url: replaced slice with at

Author: Mikhail Bodrov <[email protected]>

Date: Wed Jul 23 12:16:09 2025 +0300

1 file changed, 2 insertions(+), 2 deletions(-)

Rebasing (3/8)

Rebasing (4/8)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

url: use primordials for safe method
PR-URL: #59181

Reviewed-By: Jordan Harband <[email protected]>

Reviewed-By: Zeyu "Alex" Yang <[email protected]>

Reviewed-By: Daniel Lemire <[email protected]>

Reviewed-By: Luigi Pinca <[email protected]>
[detached HEAD 5cf1508481] url: use primordials for safe method

Author: Mikhail Bodrov <[email protected]>

Date: Wed Jul 23 17:58:02 2025 +0300

1 file changed, 4 insertions(+), 2 deletions(-)

Rebasing (5/8)

Rebasing (6/8)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

url: fix array sstring primordials method
PR-URL: #59181

Reviewed-By: Jordan Harband <[email protected]>

Reviewed-By: Zeyu "Alex" Yang <[email protected]>

Reviewed-By: Daniel Lemire <[email protected]>

Reviewed-By: Luigi Pinca <[email protected]>
[detached HEAD 0b5cea79ed] url: fix array sstring primordials method

Author: Mikhail Bodrov <[email protected]>

Date: Wed Jul 23 18:02:56 2025 +0300

1 file changed, 2 insertions(+), 1 deletion(-)

Rebasing (7/8)

Rebasing (8/8)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

url: array length instead of ArrayPrototypeAt
PR-URL: #59181

Reviewed-By: Jordan Harband <[email protected]>

Reviewed-By: Zeyu "Alex" Yang <[email protected]>

Reviewed-By: Daniel Lemire <[email protected]>

Reviewed-By: Luigi Pinca <[email protected]>
[detached HEAD ce09455c44] url: array length instead of ArrayPrototypeAt

Author: Mikhail Bodrov <[email protected]>

Date: Wed Jul 23 21:38:29 2025 +0300

1 file changed, 1 insertion(+), 2 deletions(-)

Successfully rebased and updated refs/heads/main.
ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/17334803380

[nodejs-github-bot]

Landed in 1442023