url: add type checking to urlToHttpOptions()

[simon-id]

When calling net.urlToHttpOptions() with an unexpected input (for example by someone like me who thought it would accept a string instead of an URL instance), instead of returning a neutral value like null, or throwing an error, it returns a completely bogus object.

> url.urlToHttpOptions('http://127.0.0.1')
[Object: null prototype] {
  '0': 'h',
  '1': 't',
  '2': 't',
  '3': 'p',
  '4': ':',
  '5': '/',
  '6': '/',
  '7': '1',
  '8': '2',
  '9': '7',
  '10': '.',
  '11': '0',
  '12': '.',
  '13': '0',
  '14': '.',
  '15': '1',
  protocol: undefined,
  hostname: undefined,
  hash: undefined,
  search: [Function: search],
  pathname: undefined,
  path: 'function search() { [native code] }',
  href: undefined,
  port: NaN
}

The most unhinged part is the path property, which will be set to the stringified version of the search method:

  path: 'function search() { [native code] }',

I thus propose to add some lenient type-checking to the function.

To the reviewers: should I update the docs too ? if so, what should I add ?

Possible Alternative:

If it's been decided that this method should always accept anything, and return an "empty" (ie: most fields are undefined) http options object when passed an unparsable argument, or if we want to dodge the breaking-ish change of this PR, I could instead return an empty options object instead of throwing an error?

[nodejs-github-bot]

Review requested:

• @nodejs/url

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.95%. Comparing base (737b42e) to head (cdf27c3).
⚠️ Report is 85 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #59753      +/-   ##
==========================================
- Coverage   89.95%   89.95%   -0.01%     
==========================================
  Files         667      669       +2     
  Lines      196776   197476     +700     
  Branches    38409    38593     +184     
==========================================
+ Hits       177006   177635     +629     
- Misses      12198    12241      +43     
- Partials     7572     7600      +28     

Files with missing lines	Coverage Δ
lib/internal/url.js	93.58% <100.00%> (+0.24%)	⬆️

... and 52 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jasnell]

Technically speaking, adding a new thrown error would ordinarily be a semver-major, but this was obviously already broken on these kinds of inputs so we can treat this as a semver-patch bug fix. Great find, and good job with the fix and test.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/69111/

[BridgeAR]

CITGM https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3632/

[nodejs-github-bot]

Landed in 95ab4eb