build: do not include custom ESLint rules testing in tarball

[aduh95]

Currently we have a workaround in build-tarball.yml to download from the GH repo the necessary files to run those tests. IMO that's backwards, we should not include those tests in the tarball:

• folks using the tarball do not care about our internal tooling, they only need to know if the node binary they have built does work, which those files do not reflect.
• it feels cleaner to have the tarball self-sufficient for building and testing.

[nodejs-github-bot]

Review requested:

• @nodejs/actions

[richardlau]

cc FYI @nodejs/distros

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.76%. Comparing base (861d624) to head (6a46f31).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #59809      +/-   ##
==========================================
- Coverage   88.26%   87.76%   -0.51%     
==========================================
  Files         701      701              
  Lines      206774   206774              
  Branches    39778    39692      -86     
==========================================
- Hits       182514   181477    -1037     
- Misses      16298    17288     +990     
- Partials     7962     8009      +47     

see 108 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/59809
✔  Done loading data for nodejs/node/pull/59809
----------------------------------- PR info ------------------------------------
Title      build: do not include custom ESLint rules testing in tarball (#59809)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:no-eslint-test-in-tarball -> nodejs:main
Labels     build, meta, author ready, needs-ci
Commits    1
 - build: do not include custom ESLint rules testing in tarball
Committers 1
 - Antoine du Hamel <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/59809
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/59809
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 08 Sep 2025 15:27:48 GMT
   ✔  Approvals: 3
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/59809#pullrequestreview-3197098337
   ✔  - Tierney Cyren (@bnb): https://github.com/nodejs/node/pull/59809#pullrequestreview-3197771039
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/59809#pullrequestreview-3200534662
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/17618812960

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/69171/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/69173/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/69175/

[aduh95]

Landed in 6a46f31