sqlite: fix crash session extension callbacks with workers #59848

louwers · 2025-09-10T21:31:15Z

This PR fixes the problem that static std::function variables are used to store callbacks. This causes problems when SQLite is used (also) used from a worker and can result in a crash.

This PR stack allocates the callbacks and passes it along to sqlite3changeset_apply via the context argument.

It also adds a regression test which crashes out before this change.

Lastly some functionality that is uses in test/parallel/test-sqlite.js is now also needed in test/parallel/test-sqlite-session.js so I factored that out to a different file.

nodejs-github-bot · 2025-09-10T21:31:20Z

Review requested:

@nodejs/sqlite

codecov · 2025-09-10T22:59:32Z

Codecov Report

❌ Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.63%. Comparing base (861d624) to head (5ae2b74).
⚠️ Report is 78 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	85.00%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #59848      +/-   ##
==========================================
+ Coverage   88.26%   88.63%   +0.37%     
==========================================
  Files         701      703       +2     
  Lines      206774   212129    +5355     
  Branches    39778    45065    +5287     
==========================================
+ Hits       182514   188030    +5516     
+ Misses      16298    16114     -184     
- Partials     7962     7985      +23

Files with missing lines	Coverage Δ
src/node_sqlite.cc	`86.56% <85.00%> (+5.04%)`	⬆️

... and 125 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

src/node_sqlite.cc

Co-authored-by: Anna Henningsen <[email protected]>

louwers · 2025-09-11T09:02:43Z

@addaleax Could you trigger a CI run?

nodejs-github-bot · 2025-09-11T10:07:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/69179/

nodejs-github-bot · 2025-09-16T11:39:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/69246/

louwers · 2025-09-17T18:05:30Z

@addaleax Could you merge it?

louwers · 2025-09-19T20:41:57Z

@nodejs/sqlite

nodejs-github-bot · 2025-09-19T21:05:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/69286/

louwers · 2025-09-21T18:14:04Z

@nodejs/sqlite Any blockers?

nodejs-github-bot · 2025-09-23T11:23:19Z

Commit Queue failed

- Loading data for nodejs/node/pull/59848
✔  Done loading data for nodejs/node/pull/59848
----------------------------------- PR info ------------------------------------
Title      sqlite: fix crash session extension callbacks with workers (#59848)
Author     Bart Louwers <[email protected]> (@louwers)
Branch     louwers:fix-crash-sqlite -> nodejs:main
Labels     c++, author ready, needs-ci, sqlite
Commits    6
 - sqlite: fix crash session extension callbacks with workers
 - test: fix inclusion of common module
 - Update src/node_sqlite.cc
 - Update src/node_sqlite.cc
 - sqlite: fix compilation
 - sqlite: run formatter
Committers 2
 - Bart Louwers <[email protected]>
 - GitHub <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/59848
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Edy Silva <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/59848
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Edy Silva <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 10 Sep 2025 21:31:15 GMT
   ✔  Approvals: 3
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/59848#pullrequestreview-3210402428
   ✔  - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/59848#pullrequestreview-3247082140
   ✔  - Edy Silva (@geeksilva97): https://github.com/nodejs/node/pull/59848#pullrequestreview-3247086754
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-09-19T21:05:02Z: https://ci.nodejs.org/job/node-test-pull-request/69286/
- Querying data for job/node-test-pull-request/69286/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 59848
From https://github.com/nodejs/node
 * branch                  refs/pull/59848/merge -> FETCH_HEAD
✔  Fetched commits as 0a72b2cd7b5f..5ae2b741a506
--------------------------------------------------------------------------------
Auto-merging src/node_sqlite.cc
[main 708684e395] sqlite: fix crash session extension callbacks with workers
 Author: Bart Louwers <[email protected]>
 Date: Wed Sep 10 23:21:19 2025 +0200
 5 files changed, 128 insertions(+), 22 deletions(-)
 create mode 100644 test/sqlite/next-db.js
 create mode 100644 test/sqlite/worker.js
[main af6bc0b143] test: fix inclusion of common module
 Author: Bart Louwers <[email protected]>
 Date: Thu Sep 11 00:03:02 2025 +0200
 2 files changed, 2 insertions(+), 2 deletions(-)
Auto-merging src/node_sqlite.cc
[main b0dc4b31d4] Update src/node_sqlite.cc
 Author: Bart Louwers <[email protected]>
 Date: Thu Sep 11 02:00:32 2025 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)
Auto-merging src/node_sqlite.cc
[main eb31476ac6] Update src/node_sqlite.cc
 Author: Bart Louwers <[email protected]>
 Date: Thu Sep 11 02:00:44 2025 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)
Auto-merging src/node_sqlite.cc
[main ba64b2a1e4] sqlite: fix compilation
 Author: Bart Louwers <[email protected]>
 Date: Thu Sep 11 02:23:30 2025 +0200
 1 file changed, 3 insertions(+), 2 deletions(-)
Auto-merging src/node_sqlite.cc
[main 2c17b89167] sqlite: run formatter
 Author: Bart Louwers <[email protected]>
 Date: Thu Sep 11 10:55:33 2025 +0200
 1 file changed, 8 insertions(+), 6 deletions(-)
   ✔  Patches applied
There are 6 commits in the PR. Attempting autorebase.
Rebasing (2/12)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
sqlite: fix crash session extension callbacks with workers
PR-URL: #59848

Reviewed-By: Anna Henningsen <[email protected]>

Reviewed-By: Zeyu "Alex" Yang <[email protected]>

Reviewed-By: Edy Silva <[email protected]>
[detached HEAD 2a75159701] sqlite: fix crash session extension callbacks with workers

Author: Bart Louwers <[email protected]>

Date: Wed Sep 10 23:21:19 2025 +0200

5 files changed, 128 insertions(+), 22 deletions(-)

create mode 100644 test/sqlite/next-db.js

create mode 100644 test/sqlite/worker.js

Rebasing (3/12)

Rebasing (4/12)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

test: fix inclusion of common module
PR-URL: #59848

Reviewed-By: Anna Henningsen <[email protected]>

Reviewed-By: Zeyu "Alex" Yang <[email protected]>

Reviewed-By: Edy Silva <[email protected]>
[detached HEAD 44cc0b74ae] test: fix inclusion of common module

Author: Bart Louwers <[email protected]>

Date: Thu Sep 11 00:03:02 2025 +0200

2 files changed, 2 insertions(+), 2 deletions(-)

Rebasing (5/12)

Rebasing (6/12)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

Update src/node_sqlite.cc
Co-authored-by: Anna Henningsen <[email protected]>

PR-URL: #59848

Reviewed-By: Anna Henningsen <[email protected]>

Reviewed-By: Zeyu "Alex" Yang <[email protected]>

Reviewed-By: Edy Silva <[email protected]>
[detached HEAD 8834d16dfc] Update src/node_sqlite.cc

Author: Bart Louwers <[email protected]>

Date: Thu Sep 11 02:00:32 2025 +0200

1 file changed, 1 insertion(+), 1 deletion(-)

Rebasing (7/12)

Rebasing (8/12)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

Update src/node_sqlite.cc
Co-authored-by: Anna Henningsen <[email protected]>

PR-URL: #59848

Reviewed-By: Anna Henningsen <[email protected]>

Reviewed-By: Zeyu "Alex" Yang <[email protected]>

Reviewed-By: Edy Silva <[email protected]>
[detached HEAD 7afec060ed] Update src/node_sqlite.cc

Author: Bart Louwers <[email protected]>

Date: Thu Sep 11 02:00:44 2025 +0200

1 file changed, 1 insertion(+), 1 deletion(-)

Rebasing (9/12)

Rebasing (10/12)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

sqlite: fix compilation
PR-URL: #59848

Reviewed-By: Anna Henningsen <[email protected]>

Reviewed-By: Zeyu "Alex" Yang <[email protected]>

Reviewed-By: Edy Silva <[email protected]>
[detached HEAD c917470917] sqlite: fix compilation

Author: Bart Louwers <[email protected]>

Date: Thu Sep 11 02:23:30 2025 +0200

1 file changed, 3 insertions(+), 2 deletions(-)

Rebasing (11/12)

Rebasing (12/12)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

sqlite: run formatter
PR-URL: #59848

Reviewed-By: Anna Henningsen <[email protected]>

Reviewed-By: Zeyu "Alex" Yang <[email protected]>

Reviewed-By: Edy Silva <[email protected]>
[detached HEAD 0d015e209c] sqlite: run formatter

Author: Bart Louwers <[email protected]>

Date: Thu Sep 11 10:55:33 2025 +0200

1 file changed, 8 insertions(+), 6 deletions(-)

Successfully rebased and updated refs/heads/main.
ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/17944566022

nodejs-github-bot · 2025-09-23T14:41:41Z

Landed in d2ff9da

PR-URL: #59848 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Edy Silva <[email protected]>

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [node](https://nodejs.org) ([source](https://github.com/nodejs/node)) | minor | `24.8.0` -> `24.9.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>nodejs/node (node)</summary> ### [`v24.9.0`](https://github.com/nodejs/node/releases/tag/v24.9.0): 2025-09-25, Version 24.9.0 (Current), @targos [Compare Source](nodejs/node@v24.8.0...v24.9.0) ##### Notable Changes - \[[`9b043a9096`](nodejs/node@9b043a9096)] - **(SEMVER-MINOR)** **http**: add shouldUpgradeCallback to let servers control HTTP upgrades (Tim Perry) [#59824](nodejs/node#59824) - \[[`a6456ab90a`](nodejs/node@a6456ab90a)] - **(SEMVER-MINOR)** **sqlite**: cleanup ERM support and export Session class (James M Snell) [#58378](nodejs/node#58378) - \[[`5563361d22`](nodejs/node@5563361d22)] - **(SEMVER-MINOR)** **sqlite**: add tagged template (0hm☘️) [#58748](nodejs/node#58748) - \[[`04013ee933`](nodejs/node@04013ee933)] - **(SEMVER-MINOR)** **worker**: add heap profile API (theanarkh) [#59846](nodejs/node#59846) ##### Commits - \[[`cbec4fd6de`](nodejs/node@cbec4fd6de)] - **benchmark**: calibrate config dgram multi-buffer (Bruno Rodrigues) [#59696](nodejs/node#59696) - \[[`9a4bbdc3c5`](nodejs/node@9a4bbdc3c5)] - **benchmark**: calibrate config cluster/echo.js (Nam Yooseong) [#59836](nodejs/node#59836) - \[[`0b284d86e8`](nodejs/node@0b284d86e8)] - **build**: add the missing macro definitions for OpenHarmony (hqzing) [#59804](nodejs/node#59804) - \[[`43e6e54d66`](nodejs/node@43e6e54d66)] - **build**: do not include custom ESLint rules testing in tarball (Antoine du Hamel) [#59809](nodejs/node#59809) - \[[`039ac19154`](nodejs/node@039ac19154)] - **crypto**: expose signatureAlgorithm on X509Certificate (Patrick Costa) [#59235](nodejs/node#59235) - \[[`647c332704`](nodejs/node@647c332704)] - **crypto**: use `return await` when returning Promises from async functions (Renegade334) [#59841](nodejs/node#59841) - \[[`8ed4587cf0`](nodejs/node@8ed4587cf0)] - **crypto**: use async functions for non-stub Promise-returning functions (Renegade334) [#59841](nodejs/node#59841) - \[[`bb051c56ef`](nodejs/node@bb051c56ef)] - **crypto**: avoid calls to `promise.catch()` (Renegade334) [#59841](nodejs/node#59841) - \[[`05e560dd25`](nodejs/node@05e560dd25)] - **deps**: update googletest to [`50b8600`](nodejs/node@50b8600) (Node.js GitHub Bot) [#59955](nodejs/node#59955) - \[[`fa40d3a785`](nodejs/node@fa40d3a785)] - **deps**: update archs files for openssl-3.5.3 (Node.js GitHub Bot) [#59901](nodejs/node#59901) - \[[`8c85570d18`](nodejs/node@8c85570d18)] - **deps**: upgrade openssl sources to openssl-3.5.3 (Node.js GitHub Bot) [#59901](nodejs/node#59901) - \[[`b71125664e`](nodejs/node@b71125664e)] - **deps**: update undici to 7.16.0 (Node.js GitHub Bot) [#59830](nodejs/node#59830) - \[[`dea5dd7077`](nodejs/node@dea5dd7077)] - **dgram**: restore buffer optimization in fixBufferList (Yoo) [#59934](nodejs/node#59934) - \[[`b0c1e67532`](nodejs/node@b0c1e67532)] - **diagnostics\_channel**: fix race condition with diagnostics\_channel and GC (Ugaitz Urien) [#59910](nodejs/node#59910) - \[[`0b37b594c3`](nodejs/node@0b37b594c3)] - **doc**: use "WebAssembly" instead of "Web Assembly" (Tobias Nießen) [#59954](nodejs/node#59954) - \[[`1e723f9c6b`](nodejs/node@1e723f9c6b)] - **doc**: fix typo in section on microtask order (Tobias Nießen) [#59932](nodejs/node#59932) - \[[`a28962a85c`](nodejs/node@a28962a85c)] - **doc**: update V8 fast API guidance (René) [#58999](nodejs/node#58999) - \[[`bd767c5d1b`](nodejs/node@bd767c5d1b)] - **doc**: add security escalation policy (Ulises Gascón) [#59806](nodejs/node#59806) - \[[`9df91e59e1`](nodejs/node@9df91e59e1)] - **doc**: type improvement of file `http.md` (yusheng chen) [#58189](nodejs/node#58189) - \[[`e4f571680b`](nodejs/node@e4f571680b)] - **doc**: deprecate closing `fs.Dir` on garbage collection (Livia Medeiros) [#59839](nodejs/node#59839) - \[[`e9cb986fa5`](nodejs/node@e9cb986fa5)] - **doc**: rephrase dynamic import() description (Nam Yooseong) [#59224](nodejs/node#59224) - \[[`026d4e33f7`](nodejs/node@026d4e33f7)] - **doc,crypto**: update subtle.generateKey and subtle.importKey (Filip Skokan) [#59851](nodejs/node#59851) - \[[`2b2591db52`](nodejs/node@2b2591db52)] - **esm**: make hasAsyncGraph non-enumerable (Joyee Cheung) [#59905](nodejs/node#59905) - \[[`993f05d323`](nodejs/node@993f05d323)] - **fs,win**: do not add a second trailing slash in readdir (Gerhard Stöbich) [#59847](nodejs/node#59847) - \[[`7aec53b607`](nodejs/node@7aec53b607)] - **(SEMVER-MINOR)** **http**: add shouldUpgradeCallback to let servers control HTTP upgrades (Tim Perry) [#59824](nodejs/node#59824) - \[[`83ae6102e7`](nodejs/node@83ae6102e7)] - **http**: optimize checkIsHttpToken for short strings (방진혁) [#59832](nodejs/node#59832) - \[[`6695067636`](nodejs/node@6695067636)] - **http,https**: handle IPv6 with proxies (Joyee Cheung) [#59894](nodejs/node#59894) - \[[`c5d910a0a9`](nodejs/node@c5d910a0a9)] - **http2**: fix allowHttp1+Upgrade, broken by shouldUpgradeCallback (Tim Perry) [#59924](nodejs/node#59924) - \[[`acada1fb82`](nodejs/node@acada1fb82)] - **inspector**: ensure adequate memory allocation for `Binary::toBase64` (René) [#59870](nodejs/node#59870) - \[[`396cc8ec65`](nodejs/node@396cc8ec65)] - **lib**: update inspect output format for subclasses (Miguel Marcondes Filho) [#59687](nodejs/node#59687) - \[[`fed1dac8de`](nodejs/node@fed1dac8de)] - **lib**: update isDeepStrictEqual to support options (Miguel Marcondes Filho) [#59762](nodejs/node#59762) - \[[`d785929fd7`](nodejs/node@d785929fd7)] - **lib**: add source map support for assert messages (Chengzhong Wu) [#59751](nodejs/node#59751) - \[[`ff13d1d61e`](nodejs/node@ff13d1d61e)] - **lib,src**: cache ModuleWrap.hasAsyncGraph (Chengzhong Wu) [#59703](nodejs/node#59703) - \[[`b200cd8470`](nodejs/node@b200cd8470)] - **lib,src**: refactor assert to load error source from memory (Chengzhong Wu) [#59751](nodejs/node#59751) - \[[`e94c57301b`](nodejs/node@e94c57301b)] - **meta**: add .npmrc with ignore-scripts=true (Joyee Cheung) [#59914](nodejs/node#59914) - \[[`728472a57b`](nodejs/node@728472a57b)] - **module**: only put directly require-d ESM into require.cache (Joyee Cheung) [#59874](nodejs/node#59874) - \[[`be48760b93`](nodejs/node@be48760b93)] - **node-api**: added SharedArrayBuffer api (Mert Can Altin) [#59071](nodejs/node#59071) - \[[`f006a14522`](nodejs/node@f006a14522)] - **node-api**: make napi\_delete\_reference use node\_api\_basic\_env (Jeetu Suthar) [#59684](nodejs/node#59684) - \[[`0f46c1c3b0`](nodejs/node@0f46c1c3b0)] - **repl**: fix cpu overhead pasting big strings to the REPL (Ruben Bridgewater) [#59857](nodejs/node#59857) - \[[`3eeb7b47ea`](nodejs/node@3eeb7b47ea)] - **sqlite**: fix crash session extension callbacks with workers (Bart Louwers) [#59848](nodejs/node#59848) - \[[`0fe53375ec`](nodejs/node@0fe53375ec)] - **(SEMVER-MINOR)** **sqlite**: cleanup ERM support and export Session class (James M Snell) [#58378](nodejs/node#58378) - \[[`9a3e58a007`](nodejs/node@9a3e58a007)] - **(SEMVER-MINOR)** **sqlite**: add tagged template (0hm☘️) [#58748](nodejs/node#58748) - \[[`f14ed5ab7b`](nodejs/node@f14ed5ab7b)] - **src**: simplify watchdog instantiations via `std::optional` (Anna Henningsen) [#59960](nodejs/node#59960) - \[[`e330f03f84`](nodejs/node@e330f03f84)] - **src**: update crypto objects to use DictionaryTemplate (James M Snell) [#59942](nodejs/node#59942) - \[[`69b5607cf4`](nodejs/node@69b5607cf4)] - **src**: simplify is\_callable by making it a concept (Tobias Nießen) [#58169](nodejs/node#58169) - \[[`86150f3401`](nodejs/node@86150f3401)] - **src**: rename private fields to follow naming convention (Moonki Choi) [#59923](nodejs/node#59923) - \[[`d17f299539`](nodejs/node@d17f299539)] - **src**: use DictionaryTemplate more in URLPattern (James M Snell) [#59892](nodejs/node#59892) - \[[`ac784912ac`](nodejs/node@ac784912ac)] - **src**: reduce the nearest parent package JSON cache size (Michael Smith) [#59888](nodejs/node#59888) - \[[`abecdcb536`](nodejs/node@abecdcb536)] - **src**: replace FIXED\_ONE\_BYTE\_STRING with Environment-cached strings (Moonki Choi) [#59891](nodejs/node#59891) - \[[`2bb152500b`](nodejs/node@2bb152500b)] - **src**: create strings in `FIXED_ONE_BYTE_STRING` as internalized (Anna Henningsen) [#59826](nodejs/node#59826) - \[[`03116a7cd8`](nodejs/node@03116a7cd8)] - **src**: remove `std::array` overload of `FIXED_ONE_BYTE_STRING` (Anna Henningsen) [#59826](nodejs/node#59826) - \[[`8a5325d6e3`](nodejs/node@8a5325d6e3)] - **src**: ensure `v8::Eternal` is empty before setting it (Anna Henningsen) [#59825](nodejs/node#59825) - \[[`f0c20ccd81`](nodejs/node@f0c20ccd81)] - **src**: remove unnecessary `Environment::GetCurrent()` calls (Moonki Choi) [#59814](nodejs/node#59814) - \[[`213188e491`](nodejs/node@213188e491)] - **stream**: use new AsyncResource instead of bind (Matteo Collina) [#59867](nodejs/node#59867) - \[[`ce8435b003`](nodejs/node@ce8435b003)] - **test**: testcase demonstrating issue 59541 (Eric Rannaud) [#59801](nodejs/node#59801) - \[[`8f32746142`](nodejs/node@8f32746142)] - **test**: guard write to proxy client if proxy connection is ended (Joyee Cheung) [#59742](nodejs/node#59742) - \[[`6790093fcb`](nodejs/node@6790093fcb)] - **tls**: load bundled and extra certificates off-thread (Joyee Cheung) [#59856](nodejs/node#59856) - \[[`f5d3f919d8`](nodejs/node@f5d3f919d8)] - **tls**: only do off-thread certificate loading on loading tls (Joyee Cheung) [#59856](nodejs/node#59856) - \[[`87bbaa23a0`](nodejs/node@87bbaa23a0)] - **tools**: fix `tools/make-v8.sh` for clang (Richard Lau) [#59893](nodejs/node#59893) - \[[`0d23fd525b`](nodejs/node@0d23fd525b)] - **tools**: skip test-internet workflow for draft MRs (Michaël Zasso) [#59817](nodejs/node#59817) - \[[`e17c73731a`](nodejs/node@e17c73731a)] - **tools**: copyedit `build-tarball.yml` (Antoine du Hamel) [#59808](nodejs/node#59808) - \[[`97c4e1bac9`](nodejs/node@97c4e1bac9)] - **typings**: remove unused imports (Nam Yooseong) [#59880](nodejs/node#59880) - \[[`8b29bbca76`](nodejs/node@8b29bbca76)] - **url**: replaced slice with at (Mikhail) [#59181](nodejs/node#59181) - \[[`6458867a6b`](nodejs/node@6458867a6b)] - **url**: add type checking to urlToHttpOptions() (simon-id) [#59753](nodejs/node#59753) - \[[`3c62b3886f`](nodejs/node@3c62b3886f)] - **util**: inspect objects with throwing Symbol.toStringTag (Ruben Bridgewater) [#59860](nodejs/node#59860) - \[[`6133a82875`](nodejs/node@6133a82875)] - **util**: fix debuglog.enabled not being present with callback logger (Ruben Bridgewater) [#59858](nodejs/node#59858) - \[[`9347ddddf4`](nodejs/node@9347ddddf4)] - **vm**: explain how to share promises between contexts w/ afterEvaluate (Eric Rannaud) [#59801](nodejs/node#59801) - \[[`44ce971619`](nodejs/node@44ce971619)] - **vm**: "afterEvaluate", evaluate() return a promise from the outer context (Eric Rannaud) [#59801](nodejs/node#59801) - \[[`6e586a1409`](nodejs/node@6e586a1409)] - **vm**: expose hasTopLevelAwait on SourceTextModule (Chengzhong Wu) [#59865](nodejs/node#59865) - \[[`49747a58a3`](nodejs/node@49747a58a3)] - **(SEMVER-MINOR)** **worker**: add heap profile API (theanarkh) [#59846](nodejs/node#59846) - \[[`b970c0bbc2`](nodejs/node@b970c0bbc2)] - **zlib**: reduce code duplication (jhofstee) [#57810](nodejs/node#57810) - \[[`9782ca2b1b`](nodejs/node@9782ca2b1b)] - **zlib**: implement fast path for crc32 (Gürgün Dayıoğlu) [#59813](nodejs/node#59813) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

sqlite: fix crash session extension callbacks with workers

e31c90e

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Sep 10, 2025

test: fix inclusion of common module

d19c293

addaleax approved these changes Sep 10, 2025

View reviewed changes

src/node_sqlite.cc Outdated Show resolved Hide resolved

src/node_sqlite.cc Outdated Show resolved Hide resolved

louwers and others added 4 commits September 11, 2025 02:00

Update src/node_sqlite.cc

46b18f4

Co-authored-by: Anna Henningsen <[email protected]>

Update src/node_sqlite.cc

6ebd672

Co-authored-by: Anna Henningsen <[email protected]>

sqlite: fix compilation

d0dc60a

sqlite: run formatter

5ae2b74

addaleax approved these changes Sep 11, 2025

View reviewed changes

addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 11, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 11, 2025

himself65 approved these changes Sep 19, 2025

View reviewed changes

geeksilva97 approved these changes Sep 19, 2025

View reviewed changes

geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2025

louwers closed this Sep 21, 2025

louwers reopened this Sep 21, 2025

jakecastelli added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 23, 2025

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 23, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 23, 2025

nodejs-github-bot merged commit d2ff9da into nodejs:main Sep 23, 2025
100 of 101 checks passed

targos pushed a commit that referenced this pull request Sep 24, 2025

sqlite: fix crash session extension callbacks with workers

e292249

PR-URL: #59848 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Edy Silva <[email protected]>

github-actions bot mentioned this pull request Sep 24, 2025

2025-09-25, Version 24.9.0 (Current) #59997

Merged

targos pushed a commit that referenced this pull request Sep 24, 2025

sqlite: fix crash session extension callbacks with workers

3eeb7b4

PR-URL: #59848 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Edy Silva <[email protected]>

louwers mentioned this pull request Sep 28, 2025

sqlite: handle exceptions in filter callback database.applyChangeset() #56903

Closed

Uh oh!

sqlite: fix crash session extension callbacks with workers #59848

sqlite: fix crash session extension callbacks with workers #59848

Conversation

louwers commented Sep 10, 2025

Uh oh!

nodejs-github-bot commented Sep 10, 2025

Uh oh!

codecov bot commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

louwers commented Sep 11, 2025

Uh oh!

nodejs-github-bot commented Sep 11, 2025

Uh oh!

nodejs-github-bot commented Sep 16, 2025

Uh oh!

louwers commented Sep 17, 2025

Uh oh!

louwers commented Sep 19, 2025

Uh oh!

nodejs-github-bot commented Sep 19, 2025

Uh oh!

louwers commented Sep 21, 2025

Uh oh!

nodejs-github-bot commented Sep 23, 2025

PR-URL: #59848 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Edy Silva <[email protected]>

PR-URL: #59848 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Edy Silva <[email protected]>

Co-authored-by: Anna Henningsen <[email protected]> PR-URL: #59848 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Edy Silva <[email protected]>

Co-authored-by: Anna Henningsen <[email protected]> PR-URL: #59848 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Edy Silva <[email protected]>

PR-URL: #59848 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Edy Silva <[email protected]>

PR-URL: #59848 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Edy Silva <[email protected]>

[detached HEAD 0d015e209c] sqlite: run formatter Author: Bart Louwers <[email protected]> Date: Thu Sep 11 10:55:33 2025 +0200 1 file changed, 8 insertions(+), 6 deletions(-) Successfully rebased and updated refs/heads/main.

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 23, 2025

Uh oh!

Uh oh!

codecov bot commented Sep 10, 2025 •

edited

Loading

PR-URL: #59848
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Edy Silva <[email protected]>

PR-URL: #59848
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Edy Silva <[email protected]>

Co-authored-by: Anna Henningsen <[email protected]>
PR-URL: #59848
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Edy Silva <[email protected]>

Co-authored-by: Anna Henningsen <[email protected]>
PR-URL: #59848
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Edy Silva <[email protected]>

PR-URL: #59848
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Edy Silva <[email protected]>

PR-URL: #59848
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Edy Silva <[email protected]>

[detached HEAD 0d015e209c] sqlite: run formatter
Author: Bart Louwers <[email protected]>
Date: Thu Sep 11 10:55:33 2025 +0200
1 file changed, 8 insertions(+), 6 deletions(-)
Successfully rebased and updated refs/heads/main.