feat: add ability to retrieve policy resources by id or name #1901

strantalis · 2025-02-03T19:30:15Z

Proposed Changes

The pull request introduces the concept of an identifier on a set of Get rpc's opening up the ability get a resource by more than it's id.

On the new ListPublicKeys and ListPublicKeyMappings rpc's a new oneof field was added so a user could filter by kas id, name or uri. This presents as a proto breaking change but because we haven't released these new features it is okay to bypass this check.

Checklist

I have added or updated unit tests
I have added or updated integration tests (if appropriate)
I have added or updated documentation

Testing Instructions

update Makefile to show lint failures in all modules

service/policy/kasregistry/key_access_server_registry.proto

…ings

service/policy/attributes/attributes.go

service/policy/attributes/attributes.proto

service/policy/attributes/attributes_test.go

service/policy/db/attribute_values.go

Makefile

service/go.mod

service/integration/attribute_values_test.go

service/policy/db/key_access_server_registry.go

service/policy/db/namespaces.go

service/policy/objects.proto

service/policy/db/query.sql

service/policy/objects.proto

jrschumacher

Approving to satisfy requirement. We will be addressing codeowners issues.

🤖 I have created a release *beep* *boop* --- ## [0.2.26](protocol/go/v0.2.25...protocol/go/v0.2.26) (2025-02-14) ### Features * add ability to retrieve policy resources by id or name ([#1901](#1901)) ([deb4455](deb4455)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [0.4.39](service/v0.4.38...service/v0.4.39) (2025-02-27) ### Features * add ability to retrieve policy resources by id or name ([#1901](#1901)) ([deb4455](deb4455)) * **core:** EXPERIMENTAL: EC-wrapped key support ([#1902](#1902)) ([652266f](652266f)) * **policy:** adds new public keys table ([#1836](#1836)) ([cad5048](cad5048)) ### Bug Fixes * add pagination to list public key mappings response ([#1889](#1889)) ([9898fbd](9898fbd)) * cleanup kas public key create error messages ([#1887](#1887)) ([59f7d0e](59f7d0e)) * **core:** Autobump service ([#1875](#1875)) ([4b6c335](4b6c335)) * **core:** Autobump service ([#1895](#1895)) ([08a2048](08a2048)) * **core:** Autobump service ([#1919](#1919)) ([f902295](f902295)) * **core:** Autobump service ([#1945](#1945)) ([d2e37ca](d2e37ca)) * **core:** Autobump service ([#1950](#1950)) ([7270080](7270080)) * **core:** Autobump service ([#1952](#1952)) ([b20123e](b20123e)) * **core:** Fixes for ec-wrapped from js client ([#1923](#1923)) ([3a66485](3a66485)) * **core:** Fixes protoJSON parse bug on ec rewrap ([#1943](#1943)) ([9bebfd0](9bebfd0)) * **core:** improve logging and errors on rewrap ([#1906](#1906)) ([84339d6](84339d6)) * **core:** Requires unique kids ([#1905](#1905)) ([c1b380c](c1b380c)) * filter total count on list public key operations ([#1884](#1884)) ([8df0adc](8df0adc)) * **sdk:** Fix compatibility between bulk and non-bulk rewrap ([#1914](#1914)) ([74abbb6](74abbb6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [0.7.0](protocol/go/v0.6.2...protocol/go/v0.7.0) (2025-08-08) ### ⚠ BREAKING CHANGES * **policy:** disable kas grants in favor of key mappings ([#2220](#2220)) * **core:** Require go 1.23+ ([#1979](#1979)) ### Features * add ability to retrieve policy resources by id or name ([#1901](#1901)) ([deb4455](deb4455)) * **authz:** authz v2, ers v2 protos and gencode for ABAC with actions & registered resource ([#2124](#2124)) ([ea7992a](ea7992a)) * **authz:** improve v2 request proto validation ([#2357](#2357)) ([f927b99](f927b99)) * **authz:** sensible request limit upper bounds ([#2526](#2526)) ([b3093cc](b3093cc)) * **core:** adds bulk rewrap to sdk and service ([#1835](#1835)) ([11698ae](11698ae)) * **core:** EXPERIMENTAL: EC-wrapped key support ([#1902](#1902)) ([652266f](652266f)) * **core:** Require go 1.23+ ([#1979](#1979)) ([164c922](164c922)) * **core:** v2 ERS with proto updates ([#2210](#2210)) ([a161ef8](a161ef8)) * **policy:** add enhanced standard/custom actions protos ([#2020](#2020)) ([bbac53f](bbac53f)) * **policy:** Add legacy keys. ([#2613](#2613)) ([57370b0](57370b0)) * **policy:** Add list key mappings rpc. ([#2533](#2533)) ([fbc2724](fbc2724)) * **policy:** add obligation protos ([#2579](#2579)) ([50882e1](50882e1)) * **policy:** Add validation to delete keys ([#2576](#2576)) ([cc169d9](cc169d9)) * **policy:** add values to CreateObligationRequest ([#2614](#2614)) ([94535cc](94535cc)) * **policy:** adds new public keys table ([#1836](#1836)) ([cad5048](cad5048)) * **policy:** Allow the deletion of a key. ([#2575](#2575)) ([82b96f0](82b96f0)) * **policy:** cache SubjectConditionSet selectors in dedicated column maintained via trigger ([#2320](#2320)) ([215791f](215791f)) * **policy:** Change return type for delete key proto. ([#2566](#2566)) ([c1ae924](c1ae924)) * **policy:** Default Platform Keys ([#2254](#2254)) ([d7447fe](d7447fe)) * **policy:** disable kas grants in favor of key mappings ([#2220](#2220)) ([30f8cf5](30f8cf5)) * **policy:** DSPX-1018 NDR retrieval by FQN support ([#2131](#2131)) ([0001041](0001041)) * **policy:** DSPX-1057 registered resource action attribute values (protos only) ([#2217](#2217)) ([6375596](6375596)) * **policy:** DSPX-893 NDR define crud protos ([#2056](#2056)) ([55a5c27](55a5c27)) * **policy:** DSPX-902 NDR service crud protos only (1/2) ([#2092](#2092)) ([24b6cb5](24b6cb5)) * **policy:** Finish resource mapping groups ([#2224](#2224)) ([5ff754e](5ff754e)) * **policy:** key management crud ([#2110](#2110)) ([4c3d53d](4c3d53d)) * **policy:** Key management proto ([#2115](#2115)) ([561f853](561f853)) * **policy:** Modify get request to search for keys by kasid with keyid. ([#2147](#2147)) ([780d2e4](780d2e4)) * **policy:** Return KAS Key structure ([#2172](#2172)) ([7f97b99](7f97b99)) * **policy:** Return Simple Kas Keys from non-Key RPCs ([#2387](#2387)) ([5113e0e](5113e0e)) * **policy:** rotate keys rpc ([#2180](#2180)) ([0d00743](0d00743)) * **policy:** Update key status's and UpdateKey rpc. ([#2315](#2315)) ([7908db9](7908db9)) * **policy:** Update simple kas key ([#2378](#2378)) ([09d8239](09d8239)) ### Bug Fixes * add pagination to list public key mappings response ([#1889](#1889)) ([9898fbd](9898fbd)) * **core:** Allow 521 curve to be used ([#2485](#2485)) ([aaf43dc](aaf43dc)) * **core:** Fixes protoJSON parse bug on ec rewrap ([#1943](#1943)) ([9bebfd0](9bebfd0)) * **core:** Update fixtures and flattening in sdk and service ([#1827](#1827)) ([d6d6a7a](d6d6a7a)) * **deps:** bump toolchain in /lib/fixtures and /examples to resolve CVE GO-2025-3563 ([#2061](#2061)) ([9c16843](9c16843)) * **policy:** protovalidate deprecated action types and removal of gRPC gateway in subject mappings svc ([#2377](#2377)) ([54a6de0](54a6de0)) * **policy:** remove gRPC gateway in policy except where needed ([#2382](#2382)) ([1937acb](1937acb)) * **policy:** remove new public keys rpc's ([#1962](#1962)) ([5049bab](5049bab)) * **policy:** remove predefined rules in actions protos ([#2069](#2069)) ([060f059](060f059)) * **policy:** return kas uri on keys for definition, namespace and values ([#2186](#2186)) ([6c55fb8](6c55fb8)) * **sdk:** Fix compatibility between bulk and non-bulk rewrap ([#1914](#1914)) ([74abbb6](74abbb6)) * update key_mode to provide more context ([#2226](#2226)) ([44d0805](44d0805)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com> Co-authored-by: Krish Suchak <[email protected]>

strantalis added 4 commits February 3, 2025 14:27

feat: add ability to retrieve policy resources by id or name

a0525d8

fix lint issues

8e7a9e6

fix unit tests and lint issues

014d492

fix final lint issue

df43a41

update Makefile to show lint failures in all modules

strantalis marked this pull request as ready for review February 3, 2025 21:00

strantalis requested review from a team as code owners February 3, 2025 21:00

strantalis commented Feb 3, 2025

View reviewed changes

service/policy/kasregistry/key_access_server_registry.proto Outdated Show resolved Hide resolved

strantalis added 2 commits February 3, 2025 16:09

add tests to filter list public key mappings by kas name or uri

0babe21

check public key is associated with right kas in list public key mapp…

4827b2b

…ings

jrschumacher reviewed Feb 3, 2025

View reviewed changes

service/policy/attributes/attributes.go Show resolved Hide resolved

jakedoublev reviewed Feb 3, 2025

View reviewed changes

service/policy/attributes/attributes.proto Show resolved Hide resolved

jakedoublev reviewed Feb 3, 2025

View reviewed changes

service/policy/attributes/attributes_test.go Outdated Show resolved Hide resolved

jakedoublev reviewed Feb 3, 2025

View reviewed changes

service/policy/db/attribute_values.go Outdated Show resolved Hide resolved

strantalis added 3 commits February 6, 2025 14:26

feedback updates

1cf32b8

remove required oneof on kas get

0a668be

mod and test fixes

f86b381

strantalis requested a review from a team as a code owner February 10, 2025 21:46

strantalis added 3 commits February 11, 2025 12:38

fix query namespace by name

665400d

fix tdf-roundtrip test

168b6f7

fix policy service bats tests

0df6853

strantalis requested review from jakedoublev and jrschumacher February 11, 2025 19:25

strantalis enabled auto-merge February 12, 2025 00:48

strantalis disabled auto-merge February 12, 2025 00:48

dmihalcik-virtru reviewed Feb 12, 2025

View reviewed changes

strantalis added 3 commits February 12, 2025 12:54

update makefile go-lint based on feedback

2cec996

fix importing of wrong errors pkg

02ae5e2

update max_len for pem field on KasPublicKey

965e174

dmihalcik-virtru approved these changes Feb 13, 2025

View reviewed changes

service/policy/objects.proto Show resolved Hide resolved

jrschumacher approved these changes Feb 13, 2025

View reviewed changes

Merge branch 'main' into dsp-499/add-fqn-field-on-gets

d634ce7

strantalis merged commit deb4455 into opentdf:main Feb 14, 2025
20 of 22 checks passed

This was referenced Feb 7, 2025

chore(main): release service 0.4.39 #1871

Merged

chore(main): release protocol/go 0.2.26 #1916

Merged

opentdf-automation bot mentioned this pull request Apr 29, 2025

chore(main): release protocol/go 0.4.0 #2127

Closed

opentdf-automation bot mentioned this pull request Jul 25, 2025

chore(main): release protocol/go 0.7.0 #2567

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add ability to retrieve policy resources by id or name #1901

feat: add ability to retrieve policy resources by id or name #1901

Uh oh!

strantalis commented Feb 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jrschumacher left a comment

Uh oh!

Uh oh!

Uh oh!

feat: add ability to retrieve policy resources by id or name #1901

feat: add ability to retrieve policy resources by id or name #1901

Uh oh!

Conversation

strantalis commented Feb 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Checklist

Testing Instructions

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jrschumacher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

strantalis commented Feb 3, 2025 •

edited

Loading