-
Notifications
You must be signed in to change notification settings - Fork 304
Add process tags to dynamic instrumentation intake payload #8779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 5 performance regressions! Performance is the same for 4 metrics, 6 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (319.967 µs) : 282, 358
. : milestone, 320,
basic (311.372 µs) : 302, 321
. : milestone, 311,
loop (10.36 ms) : 10301, 10418
. : milestone, 10360,
section candidate
noprobe (316.236 µs) : 283, 349
. : milestone, 316,
basic (307.033 µs) : 297, 317
. : milestone, 307,
loop (11.5 ms) : 11481, 11519
. : milestone, 11500,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 13 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~599fb5d600, baseline=1.50.0-SNAPSHOT~13eba48d61
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1018508
Total [baseline] (8.668 s) : 0, 8667986
Agent [candidate] (1.02 s) : 0, 1020466
Total [candidate] (8.662 s) : 0, 8661553
section iast
Agent [baseline] (1.164 s) : 0, 1163919
Total [baseline] (9.249 s) : 0, 9248809
Agent [candidate] (1.161 s) : 0, 1161433
Total [candidate] (9.315 s) : 0, 9314564
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.154 s) : 0, 1153930
Total [baseline] (9.262 s) : 0, 9262233
Agent [candidate] (1.147 s) : 0, 1147177
Total [candidate] (9.203 s) : 0, 9202770
section iast_TELEMETRY_OFF
Agent [baseline] (1.142 s) : 0, 1141516
Total [baseline] (9.224 s) : 0, 9224249
Agent [candidate] (1.144 s) : 0, 1143990
Total [candidate] (9.251 s) : 0, 9250592
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~599fb5d600, baseline=1.50.0-SNAPSHOT~13eba48d61
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.598 ms) : 0, 681598
BytebuddyAgent [candidate] (682.081 ms) : 0, 682081
GlobalTracer [baseline] (239.434 ms) : 0, 239434
GlobalTracer [candidate] (240.18 ms) : 0, 240180
AppSec [baseline] (55.19 ms) : 0, 55190
AppSec [candidate] (54.808 ms) : 0, 54808
Debugger [baseline] (9.132 ms) : 0, 9132
Debugger [candidate] (8.525 ms) : 0, 8525
Remote Config [baseline] (688.544 µs) : 0, 689
Remote Config [candidate] (715.715 µs) : 0, 716
Telemetry [baseline] (9.019 ms) : 0, 9019
Telemetry [candidate] (10.712 ms) : 0, 10712
section iast
BytebuddyAgent [baseline] (813.454 ms) : 0, 813454
BytebuddyAgent [candidate] (811.098 ms) : 0, 811098
GlobalTracer [baseline] (232.635 ms) : 0, 232635
GlobalTracer [candidate] (232.868 ms) : 0, 232868
IAST [baseline] (29.609 ms) : 0, 29609
IAST [candidate] (30.316 ms) : 0, 30316
AppSec [baseline] (49.938 ms) : 0, 49938
AppSec [candidate] (49.099 ms) : 0, 49099
Debugger [baseline] (5.962 ms) : 0, 5962
Debugger [candidate] (5.994 ms) : 0, 5994
Remote Config [baseline] (591.299 µs) : 0, 591
Remote Config [candidate] (606.653 µs) : 0, 607
Telemetry [baseline] (7.981 ms) : 0, 7981
Telemetry [candidate] (7.956 ms) : 0, 7956
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (805.315 ms) : 0, 805315
BytebuddyAgent [candidate] (800.748 ms) : 0, 800748
GlobalTracer [baseline] (231.298 ms) : 0, 231298
GlobalTracer [candidate] (230.365 ms) : 0, 230365
IAST [baseline] (25.409 ms) : 0, 25409
IAST [candidate] (22.7 ms) : 0, 22700
AppSec [baseline] (53.94 ms) : 0, 53940
AppSec [candidate] (54.804 ms) : 0, 54804
Debugger [baseline] (5.985 ms) : 0, 5985
Debugger [candidate] (5.925 ms) : 0, 5925
Remote Config [baseline] (601.217 µs) : 0, 601
Remote Config [candidate] (584.588 µs) : 0, 585
Telemetry [baseline] (7.999 ms) : 0, 7999
Telemetry [candidate] (7.834 ms) : 0, 7834
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (795.729 ms) : 0, 795729
BytebuddyAgent [candidate] (798.121 ms) : 0, 798121
GlobalTracer [baseline] (229.769 ms) : 0, 229769
GlobalTracer [candidate] (229.87 ms) : 0, 229870
IAST [baseline] (23.919 ms) : 0, 23919
IAST [candidate] (23.263 ms) : 0, 23263
AppSec [baseline] (54.458 ms) : 0, 54458
AppSec [candidate] (55.003 ms) : 0, 55003
Debugger [baseline] (5.952 ms) : 0, 5952
Debugger [candidate] (5.974 ms) : 0, 5974
Remote Config [baseline] (604.252 µs) : 0, 604
Remote Config [candidate] (599.337 µs) : 0, 599
Telemetry [baseline] (7.78 ms) : 0, 7780
Telemetry [candidate] (7.779 ms) : 0, 7779
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~599fb5d600, baseline=1.50.0-SNAPSHOT~13eba48d61
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.02 s) : 0, 1020032
Total [baseline] (10.55 s) : 0, 10550276
Agent [candidate] (1.025 s) : 0, 1025381
Total [candidate] (10.48 s) : 0, 10479584
section appsec
Agent [baseline] (1.164 s) : 0, 1164006
Total [baseline] (10.705 s) : 0, 10704895
Agent [candidate] (1.161 s) : 0, 1160810
Total [candidate] (10.695 s) : 0, 10695424
section iast
Agent [baseline] (1.158 s) : 0, 1157935
Total [baseline] (10.953 s) : 0, 10952958
Agent [candidate] (1.15 s) : 0, 1149954
Total [candidate] (10.909 s) : 0, 10909230
section profiling
Agent [baseline] (1.287 s) : 0, 1287013
Total [baseline] (10.933 s) : 0, 10933007
Agent [candidate] (1.278 s) : 0, 1278124
Total [candidate] (10.882 s) : 0, 10881604
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~599fb5d600, baseline=1.50.0-SNAPSHOT~13eba48d61
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.154 ms) : 0, 684154
BytebuddyAgent [candidate] (686.912 ms) : 0, 686912
GlobalTracer [baseline] (240.427 ms) : 0, 240427
GlobalTracer [candidate] (240.986 ms) : 0, 240986
AppSec [baseline] (54.433 ms) : 0, 54433
AppSec [candidate] (54.844 ms) : 0, 54844
Debugger [baseline] (7.805 ms) : 0, 7805
Debugger [candidate] (10.019 ms) : 0, 10019
Remote Config [baseline] (697.14 µs) : 0, 697
Remote Config [candidate] (702.187 µs) : 0, 702
Telemetry [baseline] (9.078 ms) : 0, 9078
Telemetry [candidate] (8.417 ms) : 0, 8417
section appsec
BytebuddyAgent [baseline] (702.579 ms) : 0, 702579
BytebuddyAgent [candidate] (700.294 ms) : 0, 700294
GlobalTracer [baseline] (237.136 ms) : 0, 237136
GlobalTracer [candidate] (236.663 ms) : 0, 236663
IAST [baseline] (21.628 ms) : 0, 21628
IAST [candidate] (21.631 ms) : 0, 21631
AppSec [baseline] (175.661 ms) : 0, 175661
AppSec [candidate] (175.686 ms) : 0, 175686
Debugger [baseline] (6.338 ms) : 0, 6338
Debugger [candidate] (5.917 ms) : 0, 5917
Remote Config [baseline] (629.416 µs) : 0, 629
Remote Config [candidate] (619.433 µs) : 0, 619
Telemetry [baseline] (7.41 ms) : 0, 7410
Telemetry [candidate] (7.401 ms) : 0, 7401
section iast
BytebuddyAgent [baseline] (808.48 ms) : 0, 808480
BytebuddyAgent [candidate] (802.451 ms) : 0, 802451
GlobalTracer [baseline] (231.88 ms) : 0, 231880
GlobalTracer [candidate] (230.828 ms) : 0, 230828
IAST [baseline] (27.925 ms) : 0, 27925
IAST [candidate] (24.44 ms) : 0, 24440
AppSec [baseline] (50.715 ms) : 0, 50715
AppSec [candidate] (54.517 ms) : 0, 54517
Debugger [baseline] (6.0 ms) : 0, 6000
Debugger [candidate] (5.914 ms) : 0, 5914
Remote Config [baseline] (595.321 µs) : 0, 595
Remote Config [candidate] (595.421 µs) : 0, 595
Telemetry [baseline] (7.986 ms) : 0, 7986
Telemetry [candidate] (7.834 ms) : 0, 7834
section profiling
BytebuddyAgent [baseline] (679.827 ms) : 0, 679827
BytebuddyAgent [candidate] (673.653 ms) : 0, 673653
GlobalTracer [baseline] (381.32 ms) : 0, 381320
GlobalTracer [candidate] (380.443 ms) : 0, 380443
AppSec [baseline] (55.481 ms) : 0, 55481
AppSec [candidate] (54.314 ms) : 0, 54314
Debugger [baseline] (6.226 ms) : 0, 6226
Debugger [candidate] (6.191 ms) : 0, 6191
Remote Config [baseline] (655.024 µs) : 0, 655
Remote Config [candidate] (658.74 µs) : 0, 659
Telemetry [baseline] (8.192 ms) : 0, 8192
Telemetry [candidate] (8.184 ms) : 0, 8184
ProfilingAgent [baseline] (104.511 ms) : 0, 104511
ProfilingAgent [candidate] (104.323 ms) : 0, 104323
Profiling [baseline] (104.536 ms) : 0, 104536
Profiling [candidate] (104.348 ms) : 0, 104348
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~599fb5d600, baseline=1.50.0-SNAPSHOT~13eba48d61
dateFormat X
axisFormat %s
section baseline
no_agent (383.071 µs) : 364, 403
. : milestone, 383,
iast (522.188 µs) : 500, 544
. : milestone, 522,
iast_FULL (743.293 µs) : 721, 765
. : milestone, 743,
iast_GLOBAL (574.571 µs) : 552, 597
. : milestone, 575,
iast_HARDCODED_SECRET_DISABLED (516.281 µs) : 495, 538
. : milestone, 516,
iast_INACTIVE (472.683 µs) : 451, 494
. : milestone, 473,
iast_TELEMETRY_OFF (514.087 µs) : 491, 538
. : milestone, 514,
tracing (467.623 µs) : 445, 490
. : milestone, 468,
section candidate
no_agent (380.294 µs) : 360, 400
. : milestone, 380,
iast (521.581 µs) : 498, 545
. : milestone, 522,
iast_FULL (735.639 µs) : 714, 758
. : milestone, 736,
iast_GLOBAL (568.442 µs) : 546, 591
. : milestone, 568,
iast_HARDCODED_SECRET_DISABLED (518.364 µs) : 495, 541
. : milestone, 518,
iast_INACTIVE (469.614 µs) : 448, 491
. : milestone, 470,
iast_TELEMETRY_OFF (506.746 µs) : 484, 530
. : milestone, 507,
tracing (467.668 µs) : 445, 490
. : milestone, 468,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~599fb5d600, baseline=1.50.0-SNAPSHOT~13eba48d61
dateFormat X
axisFormat %s
section baseline
no_agent (1.356 ms) : 1337, 1376
. : milestone, 1356,
appsec (1.74 ms) : 1716, 1764
. : milestone, 1740,
appsec_no_iast (1.75 ms) : 1727, 1773
. : milestone, 1750,
code_origins (1.707 ms) : 1680, 1734
. : milestone, 1707,
iast (1.526 ms) : 1502, 1550
. : milestone, 1526,
profiling (1.589 ms) : 1564, 1614
. : milestone, 1589,
tracing (1.497 ms) : 1472, 1522
. : milestone, 1497,
section candidate
no_agent (1.38 ms) : 1360, 1399
. : milestone, 1380,
appsec (1.742 ms) : 1717, 1766
. : milestone, 1742,
appsec_no_iast (1.726 ms) : 1703, 1749
. : milestone, 1726,
code_origins (1.672 ms) : 1645, 1699
. : milestone, 1672,
iast (1.511 ms) : 1487, 1534
. : milestone, 1511,
profiling (1.5 ms) : 1477, 1523
. : milestone, 1500,
tracing (1.511 ms) : 1486, 1535
. : milestone, 1511,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~599fb5d600, baseline=1.50.0-SNAPSHOT~13eba48d61
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (2.386 ms) : 2339, 2433
. : milestone, 2386,
iast (2.157 ms) : 2098, 2216
. : milestone, 2157,
iast_GLOBAL (2.207 ms) : 2147, 2266
. : milestone, 2207,
profiling (2.49 ms) : 2308, 2673
. : milestone, 2490,
tracing (2.002 ms) : 1956, 2048
. : milestone, 2002,
section candidate
no_agent (1.483 ms) : 1471, 1494
. : milestone, 1483,
appsec (2.394 ms) : 2346, 2441
. : milestone, 2394,
iast (2.16 ms) : 2100, 2219
. : milestone, 2160,
iast_GLOBAL (2.218 ms) : 2158, 2278
. : milestone, 2218,
profiling (2.043 ms) : 1994, 2092
. : milestone, 2043,
tracing (1.983 ms) : 1937, 2029
. : milestone, 1983,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~599fb5d600, baseline=1.50.0-SNAPSHOT~13eba48d61
dateFormat X
axisFormat %s
section baseline
no_agent (15.606 s) : 15606000, 15606000
. : milestone, 15606000,
appsec (15.001 s) : 15001000, 15001000
. : milestone, 15001000,
iast (18.79 s) : 18790000, 18790000
. : milestone, 18790000,
iast_GLOBAL (17.859 s) : 17859000, 17859000
. : milestone, 17859000,
profiling (15.479 s) : 15479000, 15479000
. : milestone, 15479000,
tracing (14.983 s) : 14983000, 14983000
. : milestone, 14983000,
section candidate
no_agent (15.538 s) : 15538000, 15538000
. : milestone, 15538000,
appsec (15.074 s) : 15074000, 15074000
. : milestone, 15074000,
iast (18.956 s) : 18956000, 18956000
. : milestone, 18956000,
iast_GLOBAL (17.552 s) : 17552000, 17552000
. : milestone, 17552000,
profiling (15.089 s) : 15089000, 15089000
. : milestone, 15089000,
tracing (15.013 s) : 15013000, 15013000
. : milestone, 15013000,
|
599fb5d
to
9533184
Compare
Datadog Summary✅ Code Quality ✅ Code Security ✅ Dependencies Was this helpful? Give us feedback! |
What Does This Do
Adds process tag collection to dynamic instrumentation payload. It will be put in the intake request in the
process_tags
field in the same location than the service name field.The
process_tag
field will contain the process tags encoded as a comma separated list. Each entry is encoded using thekey:value
format. The values are tag normalized according our standards.Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: AIDM-628