Skip to content

Fix error mark on http status for IBM liberty #8822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 16, 2025
Merged

Fix error mark on http status for IBM liberty #8822

merged 3 commits into from
May 16, 2025
+2 −20

Conversation

amarziali
Copy link
Collaborator

@amarziali amarziali commented May 14, 2025 •
edited by jira bot
Loading

What Does This Do

The libery decorator does not take into account flagging the span as errored depending on the http status code.
In fact the code on the HttpServerDecorator that handles that was not called so that logic was skipped.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: APMS-15737

@amarziali amarziali requested a review from a team as a code owner May 14, 2025 09:58
@github-actions GitHub Actions
Copy link
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

vandonr
vandonr approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@vandonr vandonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@amarziali amarziali enabled auto-merge (squash) May 14, 2025 10:02
@amarziali amarziali added type: bug inst: others All other instrumentations labels May 14, 2025
@pr-commenter
Copy link

pr-commenter bot commented May 14, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/liberty-fix
git_commit_date 1747404747 1747404897
git_commit_sha b4aebf8 3b7aba2
release_version 1.50.0-SNAPSHOT~b4aebf8b31 1.50.0-SNAPSHOT~3b7aba26a8
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1747407209 1747407209
ci_job_id 941799654 941799654
ci_pipeline_id 65330223 65330223
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-xnwlpqwj-project-304-concurrent-1-tznwxtyj 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-xnwlpqwj-project-304-concurrent-1-tznwxtyj 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 14 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~3b7aba26a8, baseline=1.50.0-SNAPSHOT~b4aebf8b31

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1019124
Total [baseline] (10.462 s) : 0, 10461641
Agent [candidate] (1.02 s) : 0, 1019961
Total [candidate] (10.439 s) : 0, 10439394
section appsec
Agent [baseline] (1.16 s) : 0, 1160163
Total [baseline] (10.648 s) : 0, 10648487
Agent [candidate] (1.167 s) : 0, 1166973
Total [candidate] (10.682 s) : 0, 10682270
section iast
Agent [baseline] (1.156 s) : 0, 1155936
Total [baseline] (10.86 s) : 0, 10859600
Agent [candidate] (1.148 s) : 0, 1147670
Total [candidate] (10.888 s) : 0, 10888173
section profiling
Agent [baseline] (1.279 s) : 0, 1279072
Total [baseline] (10.837 s) : 0, 10836890
Agent [candidate] (1.277 s) : 0, 1277456
Total [candidate] (10.77 s) : 0, 10769992
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.019 s -
Agent appsec 1.16 s 141.039 ms (13.8%)
Agent iast 1.156 s 136.811 ms (13.4%)
Agent profiling 1.279 s 259.947 ms (25.5%)
Total tracing 10.462 s -
Total appsec 10.648 s 186.846 ms (1.8%)
Total iast 10.86 s 397.959 ms (3.8%)
Total profiling 10.837 s 375.249 ms (3.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.02 s -
Agent appsec 1.167 s 147.012 ms (14.4%)
Agent iast 1.148 s 127.709 ms (12.5%)
Agent profiling 1.277 s 257.496 ms (25.2%)
Total tracing 10.439 s -
Total appsec 10.682 s 242.876 ms (2.3%)
Total iast 10.888 s 448.779 ms (4.3%)
Total profiling 10.77 s 330.598 ms (3.2%) 
gantt
    title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~3b7aba26a8, baseline=1.50.0-SNAPSHOT~b4aebf8b31

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.471 ms) : 0, 682471
BytebuddyAgent [candidate] (682.201 ms) : 0, 682201
GlobalTracer [baseline] (240.489 ms) : 0, 240489
GlobalTracer [candidate] (240.426 ms) : 0, 240426
AppSec [baseline] (54.493 ms) : 0, 54493
AppSec [candidate] (54.718 ms) : 0, 54718
Debugger [baseline] (9.083 ms) : 0, 9083
Debugger [candidate] (8.442 ms) : 0, 8442
Remote Config [baseline] (707.078 µs) : 0, 707
Remote Config [candidate] (703.82 µs) : 0, 704
Telemetry [baseline] (8.358 ms) : 0, 8358
Telemetry [candidate] (9.84 ms) : 0, 9840
section appsec
BytebuddyAgent [baseline] (699.688 ms) : 0, 699688
BytebuddyAgent [candidate] (705.369 ms) : 0, 705369
GlobalTracer [baseline] (236.465 ms) : 0, 236465
GlobalTracer [candidate] (237.421 ms) : 0, 237421
AppSec [baseline] (175.738 ms) : 0, 175738
AppSec [candidate] (175.721 ms) : 0, 175721
Debugger [baseline] (5.948 ms) : 0, 5948
Debugger [candidate] (5.928 ms) : 0, 5928
Remote Config [baseline] (630.325 µs) : 0, 630
Remote Config [candidate] (617.731 µs) : 0, 618
Telemetry [baseline] (7.431 ms) : 0, 7431
Telemetry [candidate] (7.397 ms) : 0, 7397
IAST [baseline] (21.588 ms) : 0, 21588
IAST [candidate] (21.668 ms) : 0, 21668
section iast
BytebuddyAgent [baseline] (807.052 ms) : 0, 807052
BytebuddyAgent [candidate] (801.217 ms) : 0, 801217
GlobalTracer [baseline] (231.633 ms) : 0, 231633
GlobalTracer [candidate] (230.403 ms) : 0, 230403
AppSec [baseline] (51.458 ms) : 0, 51458
AppSec [candidate] (49.283 ms) : 0, 49283
Debugger [baseline] (5.95 ms) : 0, 5950
Debugger [candidate] (5.827 ms) : 0, 5827
Remote Config [baseline] (597.654 µs) : 0, 598
Remote Config [candidate] (587.144 µs) : 0, 587
Telemetry [baseline] (7.928 ms) : 0, 7928
Telemetry [candidate] (7.79 ms) : 0, 7790
IAST [baseline] (27.776 ms) : 0, 27776
IAST [candidate] (29.221 ms) : 0, 29221
section profiling
BytebuddyAgent [baseline] (673.084 ms) : 0, 673084
BytebuddyAgent [candidate] (672.592 ms) : 0, 672592
GlobalTracer [baseline] (374.8 ms) : 0, 374800
GlobalTracer [candidate] (374.078 ms) : 0, 374078
AppSec [baseline] (61.817 ms) : 0, 61817
AppSec [candidate] (61.713 ms) : 0, 61713
Debugger [baseline] (6.298 ms) : 0, 6298
Debugger [candidate] (6.299 ms) : 0, 6299
Remote Config [baseline] (651.83 µs) : 0, 652
Remote Config [candidate] (657.438 µs) : 0, 657
Telemetry [baseline] (8.159 ms) : 0, 8159
Telemetry [candidate] (8.186 ms) : 0, 8186
ProfilingAgent [baseline] (103.47 ms) : 0, 103470
ProfilingAgent [candidate] (103.07 ms) : 0, 103070
Profiling [baseline] (103.495 ms) : 0, 103495
Profiling [candidate] (103.093 ms) : 0, 103093
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~3b7aba26a8, baseline=1.50.0-SNAPSHOT~b4aebf8b31

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.02 s) : 0, 1019649
Total [baseline] (8.654 s) : 0, 8653657
Agent [candidate] (1.019 s) : 0, 1018869
Total [candidate] (8.629 s) : 0, 8628707
section iast
Agent [baseline] (1.154 s) : 0, 1154239
Total [baseline] (9.226 s) : 0, 9225680
Agent [candidate] (1.167 s) : 0, 1167353
Total [candidate] (9.261 s) : 0, 9261259
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.149 s) : 0, 1148555
Total [baseline] (9.207 s) : 0, 9207140
Agent [candidate] (1.147 s) : 0, 1146995
Total [candidate] (9.209 s) : 0, 9208797
section iast_TELEMETRY_OFF
Agent [baseline] (1.15 s) : 0, 1150191
Total [baseline] (9.259 s) : 0, 9259237
Agent [candidate] (1.144 s) : 0, 1144487
Total [candidate] (9.243 s) : 0, 9243397
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.02 s -
Agent iast 1.154 s 134.59 ms (13.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.149 s 128.906 ms (12.6%)
Agent iast_TELEMETRY_OFF 1.15 s 130.542 ms (12.8%)
Total tracing 8.654 s -
Total iast 9.226 s 572.023 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.207 s 553.483 ms (6.4%)
Total iast_TELEMETRY_OFF 9.259 s 605.58 ms (7.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.019 s -
Agent iast 1.167 s 148.484 ms (14.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.147 s 128.126 ms (12.6%)
Agent iast_TELEMETRY_OFF 1.144 s 125.618 ms (12.3%)
Total tracing 8.629 s -
Total iast 9.261 s 632.552 ms (7.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.209 s 580.09 ms (6.7%)
Total iast_TELEMETRY_OFF 9.243 s 614.689 ms (7.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~3b7aba26a8, baseline=1.50.0-SNAPSHOT~b4aebf8b31

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.026 ms) : 0, 682026
BytebuddyAgent [candidate] (681.69 ms) : 0, 681690
GlobalTracer [baseline] (239.69 ms) : 0, 239690
GlobalTracer [candidate] (240.168 ms) : 0, 240168
AppSec [baseline] (54.592 ms) : 0, 54592
AppSec [candidate] (54.708 ms) : 0, 54708
Debugger [baseline] (8.377 ms) : 0, 8377
Debugger [candidate] (7.59 ms) : 0, 7590
Remote Config [baseline] (702.924 µs) : 0, 703
Remote Config [candidate] (718.792 µs) : 0, 719
Telemetry [baseline] (10.707 ms) : 0, 10707
Telemetry [candidate] (10.522 ms) : 0, 10522
section iast
BytebuddyAgent [baseline] (806.101 ms) : 0, 806101
BytebuddyAgent [candidate] (815.125 ms) : 0, 815125
GlobalTracer [baseline] (231.495 ms) : 0, 231495
GlobalTracer [candidate] (233.838 ms) : 0, 233838
AppSec [baseline] (48.593 ms) : 0, 48593
AppSec [candidate] (50.264 ms) : 0, 50264
Debugger [baseline] (5.878 ms) : 0, 5878
Debugger [candidate] (6.023 ms) : 0, 6023
Remote Config [baseline] (599.73 µs) : 0, 600
Remote Config [candidate] (617.419 µs) : 0, 617
Telemetry [baseline] (7.865 ms) : 0, 7865
Telemetry [candidate] (8.017 ms) : 0, 8017
IAST [baseline] (29.348 ms) : 0, 29348
IAST [candidate] (29.704 ms) : 0, 29704
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (801.237 ms) : 0, 801237
BytebuddyAgent [candidate] (799.836 ms) : 0, 799836
GlobalTracer [baseline] (230.724 ms) : 0, 230724
GlobalTracer [candidate] (230.548 ms) : 0, 230548
AppSec [baseline] (49.39 ms) : 0, 49390
AppSec [candidate] (49.404 ms) : 0, 49404
Debugger [baseline] (5.87 ms) : 0, 5870
Debugger [candidate] (5.877 ms) : 0, 5877
Remote Config [baseline] (604.33 µs) : 0, 604
Remote Config [candidate] (591.087 µs) : 0, 591
Telemetry [baseline] (7.906 ms) : 0, 7906
Telemetry [candidate] (7.929 ms) : 0, 7929
IAST [baseline] (29.249 ms) : 0, 29249
IAST [candidate] (29.232 ms) : 0, 29232
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (802.438 ms) : 0, 802438
BytebuddyAgent [candidate] (796.825 ms) : 0, 796825
GlobalTracer [baseline] (231.302 ms) : 0, 231302
GlobalTracer [candidate] (231.365 ms) : 0, 231365
AppSec [baseline] (54.433 ms) : 0, 54433
AppSec [candidate] (55.24 ms) : 0, 55240
Debugger [baseline] (5.948 ms) : 0, 5948
Debugger [candidate] (5.983 ms) : 0, 5983
Remote Config [baseline] (608.202 µs) : 0, 608
Remote Config [candidate] (598.197 µs) : 0, 598
Telemetry [baseline] (7.812 ms) : 0, 7812
Telemetry [candidate] (7.824 ms) : 0, 7824
IAST [baseline] (24.029 ms) : 0, 24029
IAST [candidate] (23.229 ms) : 0, 23229
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-05-16T14:25:49 2025-05-16T14:33:33
git_branch master andrea.marziali/liberty-fix
git_commit_date 1747404747 1747404897
git_commit_sha b4aebf8 3b7aba2
release_version 1.50.0-SNAPSHOT~b4aebf8b31 1.50.0-SNAPSHOT~3b7aba26a8
start_time 2025-05-16T14:25:35 2025-05-16T14:33:19
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1747406411 1747406411
ci_job_id 941799655 941799655
ci_pipeline_id 65330223 65330223
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-6ae23wjf-project-304-concurrent-1-rqfz4iqf 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-6ae23wjf-project-304-concurrent-1-rqfz4iqf 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~3b7aba26a8, baseline=1.50.0-SNAPSHOT~b4aebf8b31
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.369 ms) : 1349, 1388
.   : milestone, 1369,
appsec (1.732 ms) : 1708, 1756
.   : milestone, 1732,
appsec_no_iast (1.731 ms) : 1707, 1755
.   : milestone, 1731,
code_origins (1.654 ms) : 1627, 1681
.   : milestone, 1654,
iast (1.511 ms) : 1488, 1535
.   : milestone, 1511,
profiling (1.508 ms) : 1484, 1532
.   : milestone, 1508,
tracing (1.509 ms) : 1484, 1534
.   : milestone, 1509,
section candidate
no_agent (1.372 ms) : 1352, 1391
.   : milestone, 1372,
appsec (1.736 ms) : 1713, 1760
.   : milestone, 1736,
appsec_no_iast (1.744 ms) : 1721, 1767
.   : milestone, 1744,
code_origins (1.684 ms) : 1657, 1712
.   : milestone, 1684,
iast (1.536 ms) : 1511, 1560
.   : milestone, 1536,
profiling (1.541 ms) : 1517, 1564
.   : milestone, 1541,
tracing (1.496 ms) : 1472, 1521
.   : milestone, 1496,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.369 ms [1.349 ms, 1.388 ms] -
appsec 1.732 ms [1.708 ms, 1.756 ms] 363.253 µs (26.5%)
appsec_no_iast 1.731 ms [1.707 ms, 1.755 ms] 362.755 µs (26.5%)
code_origins 1.654 ms [1.627 ms, 1.681 ms] 285.086 µs (20.8%)
iast 1.511 ms [1.488 ms, 1.535 ms] 142.83 µs (10.4%)
profiling 1.508 ms [1.484 ms, 1.532 ms] 139.6 µs (10.2%)
tracing 1.509 ms [1.484 ms, 1.534 ms] 140.442 µs (10.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.372 ms [1.352 ms, 1.391 ms] -
appsec 1.736 ms [1.713 ms, 1.76 ms] 364.706 µs (26.6%)
appsec_no_iast 1.744 ms [1.721 ms, 1.767 ms] 372.159 µs (27.1%)
code_origins 1.684 ms [1.657 ms, 1.712 ms] 312.676 µs (22.8%)
iast 1.536 ms [1.511 ms, 1.56 ms] 163.871 µs (11.9%)
profiling 1.541 ms [1.517 ms, 1.564 ms] 168.856 µs (12.3%)
tracing 1.496 ms [1.472 ms, 1.521 ms] 124.312 µs (9.1%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~3b7aba26a8, baseline=1.50.0-SNAPSHOT~b4aebf8b31
    dateFormat X
    axisFormat %s
section baseline
no_agent (382.533 µs) : 362, 403
.   : milestone, 383,
iast (521.871 µs) : 500, 544
.   : milestone, 522,
iast_FULL (738.751 µs) : 717, 761
.   : milestone, 739,
iast_GLOBAL (569.816 µs) : 548, 592
.   : milestone, 570,
iast_HARDCODED_SECRET_DISABLED (520.488 µs) : 498, 543
.   : milestone, 520,
iast_INACTIVE (469.725 µs) : 447, 493
.   : milestone, 470,
iast_TELEMETRY_OFF (502.466 µs) : 479, 526
.   : milestone, 502,
tracing (468.563 µs) : 446, 491
.   : milestone, 469,
section candidate
no_agent (379.364 µs) : 359, 399
.   : milestone, 379,
iast (516.96 µs) : 495, 539
.   : milestone, 517,
iast_FULL (737.292 µs) : 715, 759
.   : milestone, 737,
iast_GLOBAL (571.373 µs) : 549, 594
.   : milestone, 571,
iast_HARDCODED_SECRET_DISABLED (526.774 µs) : 504, 549
.   : milestone, 527,
iast_INACTIVE (469.967 µs) : 447, 493
.   : milestone, 470,
iast_TELEMETRY_OFF (512.687 µs) : 490, 536
.   : milestone, 513,
tracing (461.492 µs) : 439, 484
.   : milestone, 461,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 382.533 µs [362.441 µs, 402.624 µs] -
iast 521.871 µs [499.654 µs, 544.089 µs] 139.339 µs (36.4%)
iast_FULL 738.751 µs [716.778 µs, 760.725 µs] 356.219 µs (93.1%)
iast_GLOBAL 569.816 µs [547.771 µs, 591.86 µs] 187.283 µs (49.0%)
iast_HARDCODED_SECRET_DISABLED 520.488 µs [497.519 µs, 543.458 µs] 137.956 µs (36.1%)
iast_INACTIVE 469.725 µs [446.783 µs, 492.667 µs] 87.192 µs (22.8%)
iast_TELEMETRY_OFF 502.466 µs [479.244 µs, 525.688 µs] 119.933 µs (31.4%)
tracing 468.563 µs [445.716 µs, 491.411 µs] 86.031 µs (22.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 379.364 µs [359.324 µs, 399.405 µs] -
iast 516.96 µs [495.344 µs, 538.577 µs] 137.596 µs (36.3%)
iast_FULL 737.292 µs [715.303 µs, 759.281 µs] 357.928 µs (94.3%)
iast_GLOBAL 571.373 µs [548.607 µs, 594.139 µs] 192.008 µs (50.6%)
iast_HARDCODED_SECRET_DISABLED 526.774 µs [504.108 µs, 549.44 µs] 147.41 µs (38.9%)
iast_INACTIVE 469.967 µs [447.303 µs, 492.63 µs] 90.602 µs (23.9%)
iast_TELEMETRY_OFF 512.687 µs [489.569 µs, 535.805 µs] 133.322 µs (35.1%)
tracing 461.492 µs [439.156 µs, 483.828 µs] 82.127 µs (21.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/liberty-fix
git_commit_date 1747404747 1747404897
git_commit_sha b4aebf8 3b7aba2
release_version 1.50.0-SNAPSHOT~b4aebf8b31 1.50.0-SNAPSHOT~3b7aba26a8
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1747406932 1747406932
ci_job_id 941799656 941799656
ci_pipeline_id 65330223 65330223
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-xnwlpqwj-project-304-concurrent-2-sqe17nq5 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-xnwlpqwj-project-304-concurrent-2-sqe17nq5 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~3b7aba26a8, baseline=1.50.0-SNAPSHOT~b4aebf8b31
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.079 s) : 15079000, 15079000
.   : milestone, 15079000,
appsec (15.285 s) : 15285000, 15285000
.   : milestone, 15285000,
iast (18.54 s) : 18540000, 18540000
.   : milestone, 18540000,
iast_GLOBAL (17.7 s) : 17700000, 17700000
.   : milestone, 17700000,
profiling (15.189 s) : 15189000, 15189000
.   : milestone, 15189000,
tracing (15.093 s) : 15093000, 15093000
.   : milestone, 15093000,
section candidate
no_agent (15.242 s) : 15242000, 15242000
.   : milestone, 15242000,
appsec (15.0 s) : 15000000, 15000000
.   : milestone, 15000000,
iast (18.448 s) : 18448000, 18448000
.   : milestone, 18448000,
iast_GLOBAL (17.844 s) : 17844000, 17844000
.   : milestone, 17844000,
profiling (15.115 s) : 15115000, 15115000
.   : milestone, 15115000,
tracing (15.037 s) : 15037000, 15037000
.   : milestone, 15037000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.079 s [15.079 s, 15.079 s] -
appsec 15.285 s [15.285 s, 15.285 s] 206.0 ms (1.4%)
iast 18.54 s [18.54 s, 18.54 s] 3.461 s (23.0%)
iast_GLOBAL 17.7 s [17.7 s, 17.7 s] 2.621 s (17.4%)
profiling 15.189 s [15.189 s, 15.189 s] 110.0 ms (0.7%)
tracing 15.093 s [15.093 s, 15.093 s] 14.0 ms (0.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.242 s [15.242 s, 15.242 s] -
appsec 15.0 s [15.0 s, 15.0 s] -242.0 ms (-1.6%)
iast 18.448 s [18.448 s, 18.448 s] 3.206 s (21.0%)
iast_GLOBAL 17.844 s [17.844 s, 17.844 s] 2.602 s (17.1%)
profiling 15.115 s [15.115 s, 15.115 s] -127.0 ms (-0.8%)
tracing 15.037 s [15.037 s, 15.037 s] -205.0 ms (-1.3%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~3b7aba26a8, baseline=1.50.0-SNAPSHOT~b4aebf8b31
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
.   : milestone, 1474,
appsec (2.393 ms) : 2344, 2442
.   : milestone, 2393,
iast (2.185 ms) : 2123, 2247
.   : milestone, 2185,
iast_GLOBAL (2.232 ms) : 2169, 2295
.   : milestone, 2232,
profiling (2.045 ms) : 1994, 2096
.   : milestone, 2045,
tracing (2.0 ms) : 1952, 2048
.   : milestone, 2000,
section candidate
no_agent (1.467 ms) : 1456, 1479
.   : milestone, 1467,
appsec (2.402 ms) : 2352, 2451
.   : milestone, 2402,
iast (2.173 ms) : 2111, 2235
.   : milestone, 2173,
iast_GLOBAL (2.224 ms) : 2161, 2287
.   : milestone, 2224,
profiling (2.038 ms) : 1988, 2089
.   : milestone, 2038,
tracing (2.014 ms) : 1966, 2062
.   : milestone, 2014,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.462 ms, 1.485 ms] -
appsec 2.393 ms [2.344 ms, 2.442 ms] 918.957 µs (62.4%)
iast 2.185 ms [2.123 ms, 2.247 ms] 711.302 µs (48.3%)
iast_GLOBAL 2.232 ms [2.169 ms, 2.295 ms] 758.627 µs (51.5%)
profiling 2.045 ms [1.994 ms, 2.096 ms] 570.863 µs (38.7%)
tracing 2.0 ms [1.952 ms, 2.048 ms] 525.999 µs (35.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.456 ms, 1.479 ms] -
appsec 2.402 ms [2.352 ms, 2.451 ms] 934.268 µs (63.7%)
iast 2.173 ms [2.111 ms, 2.235 ms] 705.94 µs (48.1%)
iast_GLOBAL 2.224 ms [2.161 ms, 2.287 ms] 756.457 µs (51.5%)
profiling 2.038 ms [1.988 ms, 2.089 ms] 570.744 µs (38.9%)
tracing 2.014 ms [1.966 ms, 2.062 ms] 546.422 µs (37.2%)

@amarziali amarziali force-pushed the andrea.marziali/liberty-fix branch from 04d2bea to e2f2c9a Compare May 14, 2025 13:53
@amarziali amarziali merged commit 2dab68d into master May 16, 2025
529 of 587 checks passed
@amarziali amarziali deleted the andrea.marziali/liberty-fix branch May 16, 2025 14:57
@github-actions github-actions bot added this to the 1.50.0 milestone May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vandonr vandonr vandonr approved these changes

Assignees
No one assigned
Labels
inst: others All other instrumentations type: bug
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.
2 participants
@amarziali @vandonr