Use constructor as fallback for ExecutionRequest creation in JUnit5 instrumentation #8871

daniel-mohedano · 2025-05-23T08:26:05Z

What Does This Do

Changes the fallback method to create org.junit.platform.engine.ExecutionRequest from create to the constructor, as it was originally implemented in the instrumentation.

Motivation

Fixes a bug introduced in #8865. It would only fail on the earliest version of org.junit.platform:junit-platform-engine, in which the create method is not available.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2025-05-23T09:07:40Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	daniel.mohedano/junit5-execution-request-constructor
git_commit_date	1746789389	1748019215
git_commit_sha	`ad6d5fe`	`a30b565`
release_version	1.50.0-SNAPSHOT~ad6d5fef42	1.50.0-SNAPSHOT~a30b565046

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1748021465	1748021465
ci_job_id	952628243	952628243
ci_pipeline_id	66006351	66006351
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-xffk-g1f-project-304-concurrent-0-zyhlogwh 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-xffk-g1f-project-304-concurrent-0-zyhlogwh 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 3 performance improvements and 1 performance regressions! Performance is the same for 51 metrics, 16 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:startup:petclinic:profiling:ProfilingAgent	better [-10.498ms; -2.923ms] or [-9.473%; -2.638%]	104.112ms	110.823ms
scenario:startup:petclinic:profiling:GlobalTracer	better [-24.580ms; -12.685ms] or [-6.450%; -3.329%]	362.469ms	381.101ms
scenario:startup:petclinic:profiling:AppSec	worse [+5.318ms; +9.401ms] or [+9.655%; +17.067%]	62.442ms	55.082ms
scenario:startup:petclinic:profiling:Profiling	better [-10.501ms; -2.925ms] or [-9.473%; -2.639%]	104.136ms	110.849ms

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~a30b565046, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1022068
Total [baseline] (10.487 s) : 0, 10486890
Agent [candidate] (1.023 s) : 0, 1023032
Total [candidate] (10.475 s) : 0, 10475427
section appsec
Agent [baseline] (1.168 s) : 0, 1167529
Total [baseline] (10.709 s) : 0, 10709480
Agent [candidate] (1.169 s) : 0, 1169384
Total [candidate] (10.732 s) : 0, 10731541
section iast
Agent [baseline] (1.15 s) : 0, 1150051
Total [baseline] (10.875 s) : 0, 10875182
Agent [candidate] (1.152 s) : 0, 1152427
Total [candidate] (10.931 s) : 0, 10931201
section profiling
Agent [baseline] (1.292 s) : 0, 1292116
Total [baseline] (11.005 s) : 0, 11004618
Agent [candidate] (1.275 s) : 0, 1274739
Total [candidate] (10.828 s) : 0, 10828183

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.022 s	-
Agent	appsec	1.168 s	145.461 ms (14.2%)
Agent	iast	1.15 s	127.983 ms (12.5%)
Agent	profiling	1.292 s	270.048 ms (26.4%)
Total	tracing	10.487 s	-
Total	appsec	10.709 s	222.59 ms (2.1%)
Total	iast	10.875 s	388.292 ms (3.7%)
Total	profiling	11.005 s	517.728 ms (4.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.023 s	-
Agent	appsec	1.169 s	146.352 ms (14.3%)
Agent	iast	1.152 s	129.395 ms (12.6%)
Agent	profiling	1.275 s	251.707 ms (24.6%)
Total	tracing	10.475 s	-
Total	appsec	10.732 s	256.114 ms (2.4%)
Total	iast	10.931 s	455.775 ms (4.4%)
Total	profiling	10.828 s	352.756 ms (3.4%)

gantt
    title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~a30b565046, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.929 ms) : 0, 683929
BytebuddyAgent [candidate] (683.541 ms) : 0, 683541
GlobalTracer [baseline] (240.208 ms) : 0, 240208
GlobalTracer [candidate] (241.105 ms) : 0, 241105
AppSec [baseline] (54.297 ms) : 0, 54297
AppSec [candidate] (54.572 ms) : 0, 54572
Debugger [baseline] (9.002 ms) : 0, 9002
Debugger [candidate] (9.661 ms) : 0, 9661
Remote Config [baseline] (682.986 µs) : 0, 683
Remote Config [candidate] (732.521 µs) : 0, 733
Telemetry [baseline] (10.371 ms) : 0, 10371
Telemetry [candidate] (9.849 ms) : 0, 9849
section appsec
BytebuddyAgent [baseline] (704.751 ms) : 0, 704751
BytebuddyAgent [candidate] (705.247 ms) : 0, 705247
GlobalTracer [baseline] (237.853 ms) : 0, 237853
GlobalTracer [candidate] (238.393 ms) : 0, 238393
IAST [baseline] (21.754 ms) : 0, 21754
IAST [candidate] (21.805 ms) : 0, 21805
AppSec [baseline] (176.022 ms) : 0, 176022
AppSec [candidate] (177.09 ms) : 0, 177090
Debugger [baseline] (6.316 ms) : 0, 6316
Debugger [candidate] (6.004 ms) : 0, 6004
Remote Config [baseline] (620.8 µs) : 0, 621
Remote Config [candidate] (626.764 µs) : 0, 627
Telemetry [baseline] (7.412 ms) : 0, 7412
Telemetry [candidate] (7.474 ms) : 0, 7474
section iast
BytebuddyAgent [baseline] (802.868 ms) : 0, 802868
BytebuddyAgent [candidate] (804.409 ms) : 0, 804409
GlobalTracer [baseline] (231.046 ms) : 0, 231046
GlobalTracer [candidate] (231.729 ms) : 0, 231729
IAST [baseline] (26.438 ms) : 0, 26438
IAST [candidate] (29.755 ms) : 0, 29755
AppSec [baseline] (49.36 ms) : 0, 49360
AppSec [candidate] (48.432 ms) : 0, 48432
Debugger [baseline] (5.89 ms) : 0, 5890
Debugger [candidate] (5.929 ms) : 0, 5929
Remote Config [baseline] (598.425 µs) : 0, 598
Remote Config [candidate] (704.753 µs) : 0, 705
Telemetry [baseline] (7.875 ms) : 0, 7875
Telemetry [candidate] (7.923 ms) : 0, 7923
section profiling
BytebuddyAgent [baseline] (678.981 ms) : 0, 678981
BytebuddyAgent [candidate] (679.178 ms) : 0, 679178
GlobalTracer [baseline] (381.101 ms) : 0, 381101
GlobalTracer [candidate] (362.469 ms) : 0, 362469
AppSec [baseline] (55.082 ms) : 0, 55082
AppSec [candidate] (62.442 ms) : 0, 62442
Debugger [baseline] (6.156 ms) : 0, 6156
Debugger [candidate] (6.248 ms) : 0, 6248
Remote Config [baseline] (672.006 µs) : 0, 672
Remote Config [candidate] (654.346 µs) : 0, 654
Telemetry [baseline] (8.182 ms) : 0, 8182
Telemetry [candidate] (8.255 ms) : 0, 8255
ProfilingAgent [baseline] (110.823 ms) : 0, 110823
ProfilingAgent [candidate] (104.112 ms) : 0, 104112
Profiling [baseline] (110.849 ms) : 0, 110849
Profiling [candidate] (104.136 ms) : 0, 104136

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~a30b565046, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.033 s) : 0, 1032774
Total [baseline] (8.689 s) : 0, 8689224
Agent [candidate] (1.024 s) : 0, 1023761
Total [candidate] (8.65 s) : 0, 8650277
section iast
Agent [baseline] (1.154 s) : 0, 1153608
Total [baseline] (9.279 s) : 0, 9278810
Agent [candidate] (1.151 s) : 0, 1150849
Total [candidate] (9.237 s) : 0, 9237173
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.148 s) : 0, 1148381
Total [baseline] (9.215 s) : 0, 9214683
Agent [candidate] (1.151 s) : 0, 1151132
Total [candidate] (9.192 s) : 0, 9191697
section iast_TELEMETRY_OFF
Agent [baseline] (1.153 s) : 0, 1153429
Total [baseline] (9.227 s) : 0, 9227159
Agent [candidate] (1.146 s) : 0, 1146483
Total [candidate] (9.245 s) : 0, 9244507

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.033 s	-
Agent	iast	1.154 s	120.834 ms (11.7%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.148 s	115.607 ms (11.2%)
Agent	iast_TELEMETRY_OFF	1.153 s	120.655 ms (11.7%)
Total	tracing	8.689 s	-
Total	iast	9.279 s	589.586 ms (6.8%)
Total	iast_HARDCODED_SECRET_DISABLED	9.215 s	525.458 ms (6.0%)
Total	iast_TELEMETRY_OFF	9.227 s	537.935 ms (6.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.024 s	-
Agent	iast	1.151 s	127.087 ms (12.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.151 s	127.371 ms (12.4%)
Agent	iast_TELEMETRY_OFF	1.146 s	122.722 ms (12.0%)
Total	tracing	8.65 s	-
Total	iast	9.237 s	586.896 ms (6.8%)
Total	iast_HARDCODED_SECRET_DISABLED	9.192 s	541.419 ms (6.3%)
Total	iast_TELEMETRY_OFF	9.245 s	594.23 ms (6.9%)

gantt
    title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~a30b565046, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (692.477 ms) : 0, 692477
BytebuddyAgent [candidate] (684.56 ms) : 0, 684560
GlobalTracer [baseline] (241.647 ms) : 0, 241647
GlobalTracer [candidate] (241.469 ms) : 0, 241469
AppSec [baseline] (55.689 ms) : 0, 55689
AppSec [candidate] (56.048 ms) : 0, 56048
Debugger [baseline] (7.765 ms) : 0, 7765
Debugger [candidate] (8.371 ms) : 0, 8371
Remote Config [baseline] (700.792 µs) : 0, 701
Remote Config [candidate] (694.809 µs) : 0, 695
Telemetry [baseline] (10.719 ms) : 0, 10719
Telemetry [candidate] (9.033 ms) : 0, 9033
section iast
BytebuddyAgent [baseline] (804.448 ms) : 0, 804448
BytebuddyAgent [candidate] (803.107 ms) : 0, 803107
GlobalTracer [baseline] (232.057 ms) : 0, 232057
GlobalTracer [candidate] (231.355 ms) : 0, 231355
IAST [baseline] (27.792 ms) : 0, 27792
IAST [candidate] (28.263 ms) : 0, 28263
AppSec [baseline] (50.524 ms) : 0, 50524
AppSec [candidate] (50.196 ms) : 0, 50196
Debugger [baseline] (5.965 ms) : 0, 5965
Debugger [candidate] (5.908 ms) : 0, 5908
Remote Config [baseline] (597.827 µs) : 0, 598
Remote Config [candidate] (593.969 µs) : 0, 594
Telemetry [baseline] (7.906 ms) : 0, 7906
Telemetry [candidate] (7.914 ms) : 0, 7914
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (801.395 ms) : 0, 801395
BytebuddyAgent [candidate] (802.743 ms) : 0, 802743
GlobalTracer [baseline] (230.744 ms) : 0, 230744
GlobalTracer [candidate] (232.081 ms) : 0, 232081
IAST [baseline] (29.7 ms) : 0, 29700
IAST [candidate] (29.143 ms) : 0, 29143
AppSec [baseline] (48.656 ms) : 0, 48656
AppSec [candidate] (49.237 ms) : 0, 49237
Debugger [baseline] (5.927 ms) : 0, 5927
Debugger [candidate] (5.89 ms) : 0, 5890
Remote Config [baseline] (594.502 µs) : 0, 595
Remote Config [candidate] (595.851 µs) : 0, 596
Telemetry [baseline] (7.907 ms) : 0, 7907
Telemetry [candidate] (7.922 ms) : 0, 7922
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (805.147 ms) : 0, 805147
BytebuddyAgent [candidate] (799.137 ms) : 0, 799137
GlobalTracer [baseline] (231.833 ms) : 0, 231833
GlobalTracer [candidate] (230.904 ms) : 0, 230904
IAST [baseline] (23.321 ms) : 0, 23321
IAST [candidate] (23.152 ms) : 0, 23152
AppSec [baseline] (55.22 ms) : 0, 55220
AppSec [candidate] (55.373 ms) : 0, 55373
Debugger [baseline] (5.959 ms) : 0, 5959
Debugger [candidate] (5.969 ms) : 0, 5969
Remote Config [baseline] (624.206 µs) : 0, 624
Remote Config [candidate] (606.663 µs) : 0, 607
Telemetry [baseline] (7.746 ms) : 0, 7746
Telemetry [candidate] (7.849 ms) : 0, 7849

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-05-23T17:03:21	2025-05-23T17:11:05
git_branch	master	daniel.mohedano/junit5-execution-request-constructor
git_commit_date	1746789389	1748019215
git_commit_sha	`ad6d5fe`	`a30b565`
release_version	1.50.0-SNAPSHOT~ad6d5fef42	1.50.0-SNAPSHOT~a30b565046
start_time	2025-05-23T17:03:07	2025-05-23T17:10:51

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1748020665	1748020665
ci_job_id	952628245	952628245
ci_pipeline_id	66006351	66006351
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-xffk-g1f-project-304-concurrent-1-17su4oxa 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-xffk-g1f-project-304-concurrent-1-17su4oxa 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~a30b565046, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (402.015 µs) : 364, 440
.   : milestone, 402,
iast (516.439 µs) : 493, 540
.   : milestone, 516,
iast_FULL (738.644 µs) : 717, 761
.   : milestone, 739,
iast_GLOBAL (561.746 µs) : 540, 584
.   : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (518.353 µs) : 496, 540
.   : milestone, 518,
iast_INACTIVE (466.52 µs) : 446, 488
.   : milestone, 467,
iast_TELEMETRY_OFF (508.11 µs) : 485, 531
.   : milestone, 508,
tracing (466.052 µs) : 444, 488
.   : milestone, 466,
section candidate
no_agent (385.836 µs) : 366, 406
.   : milestone, 386,
iast (535.452 µs) : 514, 557
.   : milestone, 535,
iast_FULL (738.357 µs) : 716, 760
.   : milestone, 738,
iast_GLOBAL (580.202 µs) : 557, 604
.   : milestone, 580,
iast_HARDCODED_SECRET_DISABLED (531.008 µs) : 508, 554
.   : milestone, 531,
iast_INACTIVE (476.494 µs) : 454, 499
.   : milestone, 476,
iast_TELEMETRY_OFF (510.533 µs) : 487, 534
.   : milestone, 511,
tracing (467.914 µs) : 445, 491
.   : milestone, 468,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	402.015 µs [363.602 µs, 440.427 µs]	-
iast	516.439 µs [493.196 µs, 539.682 µs]	114.424 µs (28.5%)
iast_FULL	738.644 µs [716.63 µs, 760.659 µs]	336.63 µs (83.7%)
iast_GLOBAL	561.746 µs [539.583 µs, 583.91 µs]	159.731 µs (39.7%)
iast_HARDCODED_SECRET_DISABLED	518.353 µs [496.458 µs, 540.248 µs]	116.338 µs (28.9%)
iast_INACTIVE	466.52 µs [445.532 µs, 487.507 µs]	64.505 µs (16.0%)
iast_TELEMETRY_OFF	508.11 µs [484.808 µs, 531.411 µs]	106.095 µs (26.4%)
tracing	466.052 µs [443.636 µs, 488.468 µs]	64.037 µs (15.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	385.836 µs [365.664 µs, 406.008 µs]	-
iast	535.452 µs [513.523 µs, 557.381 µs]	149.616 µs (38.8%)
iast_FULL	738.357 µs [716.261 µs, 760.453 µs]	352.521 µs (91.4%)
iast_GLOBAL	580.202 µs [556.672 µs, 603.731 µs]	194.366 µs (50.4%)
iast_HARDCODED_SECRET_DISABLED	531.008 µs [508.294 µs, 553.723 µs]	145.172 µs (37.6%)
iast_INACTIVE	476.494 µs [454.059 µs, 498.928 µs]	90.658 µs (23.5%)
iast_TELEMETRY_OFF	510.533 µs [487.164 µs, 533.903 µs]	124.698 µs (32.3%)
tracing	467.914 µs [445.231 µs, 490.596 µs]	82.078 µs (21.3%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~a30b565046, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.364 ms) : 1344, 1384
.   : milestone, 1364,
appsec (1.721 ms) : 1697, 1745
.   : milestone, 1721,
appsec_no_iast (1.739 ms) : 1715, 1763
.   : milestone, 1739,
code_origins (1.654 ms) : 1626, 1682
.   : milestone, 1654,
iast (1.517 ms) : 1493, 1542
.   : milestone, 1517,
profiling (1.506 ms) : 1483, 1530
.   : milestone, 1506,
tracing (1.49 ms) : 1465, 1514
.   : milestone, 1490,
section candidate
no_agent (1.354 ms) : 1335, 1373
.   : milestone, 1354,
appsec (1.742 ms) : 1718, 1765
.   : milestone, 1742,
appsec_no_iast (1.736 ms) : 1713, 1759
.   : milestone, 1736,
code_origins (1.656 ms) : 1628, 1683
.   : milestone, 1656,
iast (1.51 ms) : 1486, 1534
.   : milestone, 1510,
profiling (1.504 ms) : 1480, 1527
.   : milestone, 1504,
tracing (1.5 ms) : 1474, 1525
.   : milestone, 1500,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.364 ms [1.344 ms, 1.384 ms]	-
appsec	1.721 ms [1.697 ms, 1.745 ms]	356.924 µs (26.2%)
appsec_no_iast	1.739 ms [1.715 ms, 1.763 ms]	374.667 µs (27.5%)
code_origins	1.654 ms [1.626 ms, 1.682 ms]	290.101 µs (21.3%)
iast	1.517 ms [1.493 ms, 1.542 ms]	153.161 µs (11.2%)
profiling	1.506 ms [1.483 ms, 1.53 ms]	142.19 µs (10.4%)
tracing	1.49 ms [1.465 ms, 1.514 ms]	125.667 µs (9.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.354 ms [1.335 ms, 1.373 ms]	-
appsec	1.742 ms [1.718 ms, 1.765 ms]	387.51 µs (28.6%)
appsec_no_iast	1.736 ms [1.713 ms, 1.759 ms]	382.235 µs (28.2%)
code_origins	1.656 ms [1.628 ms, 1.683 ms]	301.513 µs (22.3%)
iast	1.51 ms [1.486 ms, 1.534 ms]	155.719 µs (11.5%)
profiling	1.504 ms [1.48 ms, 1.527 ms]	149.844 µs (11.1%)
tracing	1.5 ms [1.474 ms, 1.525 ms]	145.634 µs (10.8%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	daniel.mohedano/junit5-execution-request-constructor
git_commit_date	1746789389	1748019215
git_commit_sha	`ad6d5fe`	`a30b565`
release_version	1.50.0-SNAPSHOT~ad6d5fef42	1.50.0-SNAPSHOT~a30b565046

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1748021239	1748021239
ci_job_id	952628246	952628246
ci_pipeline_id	66006351	66006351
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-pag4cts-project-304-concurrent-2-dvnjsnnn 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-pag4cts-project-304-concurrent-2-dvnjsnnn 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~a30b565046, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.915 s) : 14915000, 14915000
.   : milestone, 14915000,
appsec (14.993 s) : 14993000, 14993000
.   : milestone, 14993000,
iast (18.618 s) : 18618000, 18618000
.   : milestone, 18618000,
iast_GLOBAL (17.977 s) : 17977000, 17977000
.   : milestone, 17977000,
profiling (15.022 s) : 15022000, 15022000
.   : milestone, 15022000,
tracing (14.797 s) : 14797000, 14797000
.   : milestone, 14797000,
section candidate
no_agent (14.692 s) : 14692000, 14692000
.   : milestone, 14692000,
appsec (14.997 s) : 14997000, 14997000
.   : milestone, 14997000,
iast (18.237 s) : 18237000, 18237000
.   : milestone, 18237000,
iast_GLOBAL (17.919 s) : 17919000, 17919000
.   : milestone, 17919000,
profiling (15.025 s) : 15025000, 15025000
.   : milestone, 15025000,
tracing (14.852 s) : 14852000, 14852000
.   : milestone, 14852000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.915 s [14.915 s, 14.915 s]	-
appsec	14.993 s [14.993 s, 14.993 s]	78.0 ms (0.5%)
iast	18.618 s [18.618 s, 18.618 s]	3.703 s (24.8%)
iast_GLOBAL	17.977 s [17.977 s, 17.977 s]	3.062 s (20.5%)
profiling	15.022 s [15.022 s, 15.022 s]	107.0 ms (0.7%)
tracing	14.797 s [14.797 s, 14.797 s]	-118.0 ms (-0.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.692 s [14.692 s, 14.692 s]	-
appsec	14.997 s [14.997 s, 14.997 s]	305.0 ms (2.1%)
iast	18.237 s [18.237 s, 18.237 s]	3.545 s (24.1%)
iast_GLOBAL	17.919 s [17.919 s, 17.919 s]	3.227 s (22.0%)
profiling	15.025 s [15.025 s, 15.025 s]	333.0 ms (2.3%)
tracing	14.852 s [14.852 s, 14.852 s]	160.0 ms (1.1%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~a30b565046, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
.   : milestone, 1473,
appsec (2.398 ms) : 2349, 2446
.   : milestone, 2398,
iast (2.174 ms) : 2114, 2235
.   : milestone, 2174,
iast_GLOBAL (2.218 ms) : 2156, 2279
.   : milestone, 2218,
profiling (2.035 ms) : 1985, 2084
.   : milestone, 2035,
tracing (2.018 ms) : 1971, 2066
.   : milestone, 2018,
section candidate
no_agent (1.48 ms) : 1468, 1491
.   : milestone, 1480,
appsec (2.391 ms) : 2343, 2440
.   : milestone, 2391,
iast (2.175 ms) : 2114, 2237
.   : milestone, 2175,
iast_GLOBAL (2.213 ms) : 2152, 2274
.   : milestone, 2213,
profiling (2.032 ms) : 1982, 2082
.   : milestone, 2032,
tracing (2.015 ms) : 1967, 2063
.   : milestone, 2015,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.462 ms, 1.485 ms]	-
appsec	2.398 ms [2.349 ms, 2.446 ms]	924.191 µs (62.7%)
iast	2.174 ms [2.114 ms, 2.235 ms]	700.988 µs (47.6%)
iast_GLOBAL	2.218 ms [2.156 ms, 2.279 ms]	744.254 µs (50.5%)
profiling	2.035 ms [1.985 ms, 2.084 ms]	561.228 µs (38.1%)
tracing	2.018 ms [1.971 ms, 2.066 ms]	545.018 µs (37.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.48 ms [1.468 ms, 1.491 ms]	-
appsec	2.391 ms [2.343 ms, 2.44 ms]	911.278 µs (61.6%)
iast	2.175 ms [2.114 ms, 2.237 ms]	695.548 µs (47.0%)
iast_GLOBAL	2.213 ms [2.152 ms, 2.274 ms]	733.078 µs (49.5%)
profiling	2.032 ms [1.982 ms, 2.082 ms]	552.013 µs (37.3%)
tracing	2.015 ms [1.967 ms, 2.063 ms]	534.783 µs (36.1%)

…onstructor

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.49.0` -> `1.50.0` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.50.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.50.0): 1.50.0 ### Deprecation Notice > \[!NOTE] > `DD_RUNTIME_ID_ENABLED` has been deprecated and will be removed in future releases. Please use `DD_RUNTIME_METRICS_RUNTIME_ID_ENABLED` instead. ### Components #### Application Security Management (WAF) - 🐛 Add String length truncation limit to ObjectIntrospector and update truncation metrics ([#8825](DataDog/dd-trace-java#8825) - [@jandro996](https://github.com/jandro996)) - 🐛 Adapt standalone ASM to support API Security ([#8804](DataDog/dd-trace-java#8804) - [@jandro996](https://github.com/jandro996)) - ✨ Add appsec.waf.input\_truncated metric ([#8791](DataDog/dd-trace-java#8791) - [@jandro996](https://github.com/jandro996)) - ✨ Extended appsec request body collection ([#8748](DataDog/dd-trace-java#8748) - [@jandro996](https://github.com/jandro996)) - ✨ Extended appsec request/response headers collection ([#8724](DataDog/dd-trace-java#8724) - [@jandro996](https://github.com/jandro996)) #### Build & Tooling - ✨ Add artifacts to public s3 bucket ([#8947](DataDog/dd-trace-java#8947) - [@randomanderson](https://github.com/randomanderson)) #### Continuous Integration Visibility - ✨ Improve PR information building ([#8908](DataDog/dd-trace-java#8908) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Truncate span stack traces when Test Optimization is enabled ([#8903](DataDog/dd-trace-java#8903) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Ensure auto-detected service name is the same for every process in the same build ([#8902](DataDog/dd-trace-java#8902) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Use tag as fallback in api requests if no branch is available ([#8876](DataDog/dd-trace-java#8876) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add support for JUnit 5.13-RC1 ([#8865](DataDog/dd-trace-java#8865), [#8871](DataDog/dd-trace-java#8871) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement attempt to fix v3 and v4 and bump capability version ([#8824](DataDog/dd-trace-java#8824) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - 🧹 Align retry logic for all test framework instrumentations ([#8803](DataDog/dd-trace-java#8803) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - 🐛 Always build ci workspace without trailing separator ([#8788](DataDog/dd-trace-java#8788) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add commit discrepancies telemetry when building repository git information ([#8763](DataDog/dd-trace-java#8763) - [@daniel-mohedano](https://github.com/daniel-mohedano)) #### Data Streams Monitoring - 💡 Surface process tags in dsm payloads and use them for base hash calculation ([#8836](DataDog/dd-trace-java#8836) - [@amarziali](https://github.com/amarziali)) #### Dynamic Instrumentation - ✨ Optimized allocations for collection filter functions ([#8896](DataDog/dd-trace-java#8896) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix SymDB upload size check ([#8887](DataDog/dd-trace-java#8887) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Add support for Set in filter function ([#8873](DataDog/dd-trace-java#8873) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Add support for isDefined in log template ([#8859](DataDog/dd-trace-java#8859) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix Max captured frames for Exception Replay ([#8856](DataDog/dd-trace-java#8856) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Remove static inherited fields collection ([#8832](DataDog/dd-trace-java#8832) - [@jpbempel](https://github.com/jpbempel)) - 💡 Add process tags to dynamic instrumentation intake payload ([#8779](DataDog/dd-trace-java#8779) - [@amarziali](https://github.com/amarziali)) #### GraalVM native-image - ✨ Add support for GraalVM Native GC metrics ([#8913](DataDog/dd-trace-java#8913) - [@ygree](https://github.com/ygree)) - ✨ Add JMXFetch support for GraalVM Native ([#8569](DataDog/dd-trace-java#8569) - [@ygree](https://github.com/ygree)) #### JMX fetch - ✨ Add support for GraalVM Native GC metrics ([#8913](DataDog/dd-trace-java#8913) - [@ygree](https://github.com/ygree)) #### Library Injection - ✨ Deny oracle db jvm based tools ([#8909](DataDog/dd-trace-java#8909) - [@bric3](https://github.com/bric3)) #### OpenTracing - 🐛 Fix OT packaging for exception replay ([#8912](DataDog/dd-trace-java#8912) - [@jpbempel](https://github.com/jpbempel)) #### Profiling - ✨ Bump ddprof to 1.27.0 ([#8893](DataDog/dd-trace-java#8893) - [@jbachorik](https://github.com/jbachorik)) - Properly handle the adaptive sampling interval overflow by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#213 - Fix [#200](DataDog/dd-trace-java#200) Crash related to aligned\_alloc and free in context by [@yanglong1010](https://github.com/yanglong1010) in DataDog/java-profiler#208 - Explicitly initialize empty context page by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#210 - Re-connect crash recursion protection with VM stackwalker by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#214 - ✨ Enable ZSTD compression for profiling ([#8862](DataDog/dd-trace-java#8862) - [@MattAlp](https://github.com/MattAlp)) - ✨ Extend JPS re-implementation to J9 family ([#8813](DataDog/dd-trace-java#8813) - [@MattAlp](https://github.com/MattAlp)) - 💡 Collect process tags for profiling upload requests ([#8780](DataDog/dd-trace-java#8780) - [@amarziali](https://github.com/amarziali)) #### Telemetry - 💡 Surface process tags on telemetry payloads ([#8837](DataDog/dd-trace-java#8837) - [@amarziali](https://github.com/amarziali)) #### Trace context propagation - ✨ Migrating all HttpClient Instrumentations to Inject Full Context ([#8826](DataDog/dd-trace-java#8826) - [@mhlidd](https://github.com/mhlidd)) - ✨ Migrating all HttpServer Instrumentations to Extract full Context ([#8820](DataDog/dd-trace-java#8820) - [@mhlidd](https://github.com/mhlidd)) - ✨ Add context API support OTel propagators ([#8770](DataDog/dd-trace-java#8770) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Tracer core - ✨⚡ Skip JAXB generated classes classloader ([#9003](DataDog/dd-trace-java#9003) - [@bric3](https://github.com/bric3)) - ✨ Add DD\_RUNTIME\_METRICS\_RUNTIME\_ID\_ENABLED alias for runtime id generation ([#8981](DataDog/dd-trace-java#8981) - [@amarziali](https://github.com/amarziali)) - 🐛 Use resolved address for peer.hostname when available without hitting the cache ([#8915](DataDog/dd-trace-java#8915) - [@amarziali](https://github.com/amarziali)) - 💡 Surface server name process tag for tomcat ([#8894](DataDog/dd-trace-java#8894) - [@amarziali](https://github.com/amarziali)) - 💡 Surface websphere cell and server name on process tags ([#8880](DataDog/dd-trace-java#8880) - [@amarziali](https://github.com/amarziali)) - ✨ Added special lightweight pre-main class that skips installation on incompatible JVMs. ([#8855](DataDog/dd-trace-java#8855) - [@AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD)) - 💡 Add entrypoint type to process tags ([#8839](DataDog/dd-trace-java#8839) - [@amarziali](https://github.com/amarziali)) - ✨ Extend JPS re-implementation to J9 family ([#8813](DataDog/dd-trace-java#8813) - [@MattAlp](https://github.com/MattAlp)) - ✨ Notify listeners when the scope top changes after switching scope stacks ([#8797](DataDog/dd-trace-java#8797) - [@mcculls](https://github.com/mcculls)) - ✨ Read hsperfdata for Java PIDs if jvmstat is unavailable ([#8792](DataDog/dd-trace-java#8792) - [@MattAlp](https://github.com/MattAlp)) - 🐛 Turn JDK socket support on by default ([#8752](DataDog/dd-trace-java#8752) - [@sarahchen6](https://github.com/sarahchen6)) - ✨ Simplify context propagation ([#8719](DataDog/dd-trace-java#8719) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Add JSON parsing support ([#8579](DataDog/dd-trace-java#8579) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Tracer internal logging - ✨ Fix printing format of span identifiers ([#8897](DataDog/dd-trace-java#8897) - [@vandonr](https://github.com/vandonr)) #### Tracer public API - 💡 Track the source of installation ([#8956](DataDog/dd-trace-java#8956) - [@mabdinur](https://github.com/mabdinur)) - ✨ Enforce size limit on application\_monitoring.yaml files ([#8789](DataDog/dd-trace-java#8789) - [@mtoffl01](https://github.com/mtoffl01)) - ✨ Enabling baggage cache to support limits and non-ascii characters ([#8713](DataDog/dd-trace-java#8713) - [@mhlidd](https://github.com/mhlidd)) ### Instrumentations #### AWS Lambda instrumentation - ✨ Pass Lambda Request ID to Extension ([#8814](DataDog/dd-trace-java#8814) - [@nhulston](https://github.com/nhulston)) #### Core Java language instrumentation - ✨ Ensure ClassloadingInstrumentation is always applied even with `DD_TRACE_ENABLED=false` ([#8863](DataDog/dd-trace-java#8863) - [@mcculls](https://github.com/mcculls)) #### Eclipse Vert.x instrumentation - 🐛 Do not override route with / in vertx instrumentation ([#8881](DataDog/dd-trace-java#8881) - [@vandonr](https://github.com/vandonr)) #### IBM Liberty - 🐛 Fix error mark on http status for IBM liberty ([#8822](DataDog/dd-trace-java#8822) - [@amarziali](https://github.com/amarziali)) #### JDBC instrumentation - 🐛 Do not prepend DBM <> APM trace comment in SQLCommenter if there is a pg plan hint ([#8864](DataDog/dd-trace-java#8864) - [@edengorevoy](https://github.com/edengorevoy)) #### JMS instrumentation - ✨ Add jms as an extra integration name where there is JMS involved ([#8933](DataDog/dd-trace-java#8933) - [@vandonr](https://github.com/vandonr)) #### Kotlin instrumentation - ✨ Enable kotlin\_coroutine integration by default ([#8848](DataDog/dd-trace-java#8848) - [@mcculls](https://github.com/mcculls)) - 🧹 Rework Kotlin coroutines instrumentation around coroutine context ([#8774](DataDog/dd-trace-java#8774) - [@mcculls](https://github.com/mcculls)) #### OpenTelemetry instrumentation - 🐛 Support WithSpan inheritContext attribute ([#8858](DataDog/dd-trace-java#8858) - [@amarziali](https://github.com/amarziali)) - ✨ Add context API support OTel propagators ([#8770](DataDog/dd-trace-java#8770) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Play Framework instrumentation - 🐛 Fix the Play Framework's span resource name priority so that the client JAX-RS 404 cannot override it ([#8591](DataDog/dd-trace-java#8591) - [@ygree](https://github.com/ygree)) #### Quarkus Instrumentation - 🐛 Ignore quarkus jaxrs stubs and cdi wrapper proxies ([#8891](DataDog/dd-trace-java#8891) - [@amarziali](https://github.com/amarziali)) #### ServiceTalk - ✨ Improve ServiceTalk Captured Context API Instrumentation for v0.42.56+ ([#8821](DataDog/dd-trace-java#8821) - [@ygree](https://github.com/ygree)) #### Spring instrumentation - ✨ Supporting Baggage for Instrumentations used in Weblog Tests ([#8773](DataDog/dd-trace-java#8773) - [@mhlidd](https://github.com/mhlidd)) #### WebSocket Instrumentation - 💡 Trace websocket for spring webflux reactive handlers ([#8831](DataDog/dd-trace-java#8831) - [@amarziali](https://github.com/amarziali)) - 💡:test\_tube: WebSocket support for Netty ([#8632](DataDog/dd-trace-java#8632) - [@ValentinZakharov](https://github.com/ValentinZakharov)) #### Zio Instrumentation - 🧹 Cleanup Zio fiber instrumentation to avoid repeated activation of continuation ([#8798](DataDog/dd-trace-java#8798) - [@mcculls](https://github.com/mcculls)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 9207366cdb6a1bd098082305d354a0a3c4622d7a

use constructor instead of create method as fallback

c66495a

daniel-mohedano added type: bug Bug report and fix comp: ci visibility Continuous Integration Visibility labels May 23, 2025

daniel-mohedano changed the title ~~Use constructor as fallback in ExecutionRequest creation in JUnit5 instrumentation~~ Use constructor as fallback for ExecutionRequest creation in JUnit5 instrumentation May 23, 2025

daniel-mohedano requested a review from nikita-tkachenko-datadog May 23, 2025 08:53

daniel-mohedano marked this pull request as ready for review May 23, 2025 08:53

daniel-mohedano requested a review from a team as a code owner May 23, 2025 08:53

nikita-tkachenko-datadog approved these changes May 23, 2025

View reviewed changes

Merge branch 'master' into daniel.mohedano/junit5-execution-request-c…

a30b565

…onstructor

daniel-mohedano enabled auto-merge (squash) May 23, 2025 16:54

daniel-mohedano disabled auto-merge May 23, 2025 18:18

daniel-mohedano merged commit 81ef2be into master May 23, 2025
523 of 524 checks passed

daniel-mohedano deleted the daniel.mohedano/junit5-execution-request-constructor branch May 23, 2025 19:23

github-actions bot added this to the 1.50.0 milestone May 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use constructor as fallback for ExecutionRequest creation in JUnit5 instrumentation #8871

Use constructor as fallback for ExecutionRequest creation in JUnit5 instrumentation #8871

Uh oh!

daniel-mohedano commented May 23, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented May 23, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Use constructor as fallback for ExecutionRequest creation in JUnit5 instrumentation #8871

Use constructor as fallback for ExecutionRequest creation in JUnit5 instrumentation #8871

Uh oh!

Conversation

daniel-mohedano commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenter bot commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

Uh oh!

daniel-mohedano commented May 23, 2025 •

edited

Loading

pr-commenter bot commented May 23, 2025 •

edited

Loading