Pulling master #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#6246) * GDTCORClock: use NSTimeZone to get a timezone with respect of daylight * Changelog
This turns out not to actually work because NSDate does not conform to Codable. Users can supply their own extensions that make NSDate conform to Codable and also supply an extension like this one to make NSDate conform to ServerTimestampWrappable. Add a test that verifies ServerTimestamps of Dates actually work. The equivalent test for NSDate does not compile.
`FirebaseFirestoreSwift` was already using synthesized `Equatable` and `Hashable` conformance which requires Swift 4.1.
… types (#6249) * Remove the extension that makes NSDate ServerTimestampWrappable. This turns out not to actually work because NSDate does not conform to Codable. Users can supply their own extensions that make NSDate conform to Codable and also supply an extension like this one to make NSDate conform to ServerTimestampWrappable. Add a test that verifies ServerTimestamps of Dates actually work. The equivalent test for NSDate does not compile. * Fix minimum Swift version for FirebaseFirestoreSwift FirebaseFirestoreSwift was already using synthesized Equatable and Hashable conformance which requires Swift 4.1. * Add conditional conformance to Hashable to Firestore property wrapper types Mark these types as conforming to Hashable if the underlying type itself conforms to hashable. This implementation relies on synthesized Equatable and Hashable conformance that shipped as a part of Swift 4.1. * Fix lint/style * Changelog
…es (#6255) Show new build alert when version (or build) changes
…ess (#6127) * Update Dangerfile, Firebase.h, and Firebase.podspec for launch readiness * Add appDistribution to FirebasePods.swift * Update versions to match what we expect for launch * Add FirebaseAppDistribution to FirebasePodTest/Podfile Co-authored-by: Jeremy Durham <[email protected]>
* watchOS support for FirebaseAuth. This is a redo of #5585, which was a re-implementation of #4632. This ignores any changes to GoogleUtilities, those will be done in a later PR to create a common KeyedArchiver utility. Co-authored-by: Harri Hohteri <[email protected]> * Fixed lint errors, added GHA tests. * Enabled GHA for PRs as well. Co-authored-by: Harri Hohteri <[email protected]>
* Intentional formatting error * Run swiftformat via mint run This avoids users needing to bootstrap manually and avoids permission problems with installation in /usr/local. * Update documentation * Adjust setup_check.sh * Intentional formatting error * Fix copyright and typo * Review feedback * GitHub Actions * Remove version check for swiftformat The output of mint run includes details on which versions it is installing so there's no ambiguity in CI logs. * explicit bootstrap * style.sh generated changes
* update nanopb from 0.3.9.5 to 0.3.9.6 This fixes issues building firestore SDK with Python3. Interestingly, latest version 0.4.2 still errors during the build but 0.3.9.6 works. The git commit for this fix in nanopb nanopb/nanopb@63f8e5e * Update generated sources * updating just nanopb dependency version nanopb updated from 0.3.9.5 to 0.3.9.6 (pod version 1.30905.0 to 1.30906.0) * Add missing source specifier * Generated files for protos using nanopb 0.3.9.6 * removed unnecessary whitespaces in files generated by protoc * using more qualified relative paths for header includes * Changelog Co-authored-by: Marek Gilbert <[email protected]> Co-authored-by: Paul Beusterien <[email protected]>
Stop using typedefs for completion blocks in public APIs so that Xcode is more usable in Swift:
* Remove runtime checks for NSURLSession * Remove FIRCLSURLSession * fix style * Fix build * Update changelog * Fix deprecation warning
* Testing generating archives on GHA
* Removed unnecessary quotes.
* Fix arguments again.
* Attempt to archive macOS and tvOS too
* Fix naming
* arg parsing
* Fix parentheses style.
* End case for bash script.
* Try Catalyst support, too.
* Try Catalyst support, too for real.
* Catalyst again
* Revert Catalyst build.
This was wrong (scheme should have been App-iOS) but then that failed
with a different error:
```
firebase-ios-sdk/gen/FirebaseCore/Target Support Files/nanopb/nanopb-prefix.pch:2:9: fatal error: 'UIKit/UIKit.h' file not found
^~~~~~~~~~~~~~~
1 error generated.
```
I'll revert it for now and address later.
* Add ALL THE SDKS
* Run on cron job only
* Removed Installations test.
* Remove uploading of archive, print size on disk
* Temporarily run Core on PRs for testing.
* Re-enable cron only for Core.
* Restore Firebase.h now that SPM supports same public header path as CocoaPods
redact UDID information from binary image data
This option doesn't work with C++, and even though the clang compiler ignores it, clangd does not, and this causes syntax highlighting failures in CLion.
* Fix clang-tidy warnings in FieldValue * Update clang-tidy exclusions for CLion 2020.2
This is left-over from the migration completed in #5323 (as part of b/152883646). Briefly, we used have much more complex self-contained rules that tried to manage sources, dependencies, and everything in a single rule like firebase_ios_cc_library. The migration added functions like firebase_ios_add_library that more closely matched builtin CMake primitives. I should have sent this PR as the final one in that sequence.
* FIRMessagingInterop introduced * Typo fix * Use FIRMessagingInterop in functions * Functions tests fix * Delete FUNInstanceIDProxy * InstanceID cleanup * ./scripts/style.sh * Reduce FIRMessagingInterop to required minimum * Cleanup * Functions changelog * Fix FIRMessagingInteropFake.h import * Update integration tests * Fix start.sh script * GHA: add FCM interop to funstions paths
* Add SwiftPM instructions to base README.md This matches other package managers. * Capitalized Beta
* Update versions for Release 6.32.0 * Add Analytics for 6.32.0 SPM (#6397) * Fix SwiftPM versioning (#6399) (#6400) Co-authored-by: Paul Beusterien <[email protected]>
Removing client id usage in api call and respective checks FDL SDK was using client id passed in FIROptions to make API calls. From backend side, we no longer needs client id to be sent. So removing the client id usage in FDL SDK along with parameter no null checks. -Removed the usage of Client id from FIROptions. -Removed non null parameter checks for client id. -Deprecated 1p API method setUpWithLaunchOptions::apiKey:clientID:urlScheme:userDefaults: and added setUpWithLaunchOptions::apiKey:urlScheme:userDefaults: -Removed Client id usage in Unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in a feature request so that we
can discuss it together.