Merge master into googledatatransport #2828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes the new index and all internals for collection group queries, but the public API will not be exposed until backend support is ready.
… which will be remove soon. (#2501)
Rather than delete, which technically results in undefined behaviour.
FIRDynamicLink: preserve all parameters passed to initializer (#2478)
This is official image notification support for FCM. Now an image can be rendered in notification when user enable service extension and calling the extensionHelper API.
…ow to size the UIWindow for in-app message display (#2518)
Allow Bundle IDs that have a valid prefix - strict validation
* Only assign regex helper once. This fixes an internal error (b/128359839) that causes tests to crash. * Re-add unused param.
Only seems to impact the mac cmake build (not the xcode build). Linux build is unaffected since there's an ifdef objc at the top of the file.
* Release notes for M45 * Better words in change log * Add issue number
* Update Firestore project to Xcode 10.1 defaults * Fix NSUInteger in format strings warning * Fix implicit conversion warning in FSTLevelDB * Fix BOOL/bool mismatch * Fix erroneous comparison This failure shows up on 32-bit targets. I have no idea why this succeeds on 64-bit targets. * Fix incorrect type inference with explicit cast clang is inferring the type of the key in these maps is `NSString *` and then complaining that `FIRFieldValue *` doesn't match that type, despite the underlying method taking `NSDictionary<id, id>`. Explicitly casting to `id` prevents the warning. * Remove reliance on representation in FSTFieldValue tests On *some* platforms [NSNumber numberWithChar:1] ends up with a "c" (signed char) objcType, but apparently on 32-bit platforms this ends up as "i" (signed int). Rather than relying on this working properly just test that [NSNumber numberWithBool:] does the right thing. * Fix field_value_test on 32-bit targets When sizeof(void*) is 4 the test failed :-(. * Rephrase testWritesWithLargeNumbersFail in terms of fixed size types The prior definition only worked on LP64. Switching to LLONG_MAX would have also fixed this, but Firestore's data model is independent of C's data model, so rewriting this in terms of fixed size types more closely models what's actually an invalid value. * Fix implicit retain self warnings
* Moving FIRAnalyticsConfiguration calls to Analytics. These APIS are specific to the Analytics SDK and have been moved there. The instance methods have become static methods on the `FIRAnalytics` class. * Ignore more clang warnings. * Added more context in the changelog. * Updated CHANGELOG.
…2542) * extract errorMessage directly from response in case of returnIDPCredential=YES Fix #2522. In this case, the server returns an 200 without an error like the following: ``` [response data:] { "error": { "code": 400, "message": "FEDERATED_USER_ID_ALREADY_LINKED", "errors": [ { "message": "FEDERATED_USER_ID_ALREADY_LINKED", "domain": "global", "reason": "invalid" } ] } } ``` Rather, it is directly enclosed in the response with an errorMessage without a structure: ``` [response data:] { key: value ... "errorMessage": "FEDERATED_USER_ID_ALREADY_LINKED", "kind": "identitytoolkit#VerifyAssertionResponse" } ``` * Update Changelog
...and add placeholders for numeric transform tests
Added some instructions to build the zip. Will expand further with releasing information.
We currently tag it locally but don't push it to remote like we do with the other tags.
* Update FirebaseSDKs.textproto with new fields. * Update message about strip_32bits flag.
This reverts commit 9d0f07b.
This reverts commit 279a095.
* Tunnel underlying NSErrors through Status * Make FIRFirestoreErrorDomain available to CMake builds The prior state was actually semi-broken. The firebase_credentials_provider_apple definition wasn't extern "C" so it was defining the value in addition to whatever FIRFirestore was doing. FIRFirestore's value isn't available to straight C++ though, so this change pushes the definition down into error_apple.mm so that it can be shared by the Objective-C API and MakeNSError. Pushing MakeNSError up into the API layer isn't practical yet so this change is a compromise that makes things work
* Proposed improvements to space checking (#2824)
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
paulb777
approved these changes
Apr 12, 2019
|
Please investigate the travis failure. I'm not sure why Firestore would check differently on this branch than master. |
|
Seems to be gone in #2829 |
|
It's on the googledatatransport branch travis run but not the PR travis run. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.