Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchases] fixed typo #2812

Closed
wants to merge 32 commits into from
Closed

[in_app_purchases] fixed typo #2812

wants to merge 32 commits into from

Conversation

MauScheff
Copy link
Contributor

Description

Fixed typo 'manuelly' for 'manually'

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

ditman and others added 11 commits June 3, 2020 16:41
By ensuring that flutter widget bindings are initialized. The current version fails on startup.
Once the switch to GTK lands, libgtk-3-dev will be needed for building.
…esting (#2815)

The recent federation of the Linux path provider might break tests, this updates the README.md to address those changes and direct the users how to mock the plugin in their tests.
Add a note about encoding URLs passed to the url_launcher in the packages README.
…ates. (#2834)

* Allow all transactions except for purchasing ones to be passed back to the Flutter side.

* Restore transactions shouldn't block transaction updates
* Fix e2e device pixel ratio

* Update changelog and version

* Formatting
ditman and others added 14 commits June 29, 2020 20:23
Move the package formerly known as `experimental_connectivity_web` to flutter/plugins master, as `connectivity_for_web`.
Adds shared_preferences support for Linux.

Part of flutter/flutter#41720
Expose a `Future` for `testResults` instead.

This works better for internal use cases.
This change adds small bugfixes to the following packages:

* video_player_web:
  * Prevent parsing Blob URLs so Safari can play from a PickedFile.
  * Allow users to 'mute' videos by setting their volume to 0.0 (this enables auto-play in most modern browsers)
* video_player:
  * Fix an issue where aspect ratio calculations failed when some of the video sizes were zero (happened in web for incorrect videos)
* image_picker (example app):
  * Start videos in web muted so they can auto-play
  * Dispose video controllers when they're really not needed. This fixes a fatal crash in Safari (not so fatal in other browsers).
Adds url_launcher_linux, the federated implementation of url_launcher.

Not yet endorsed by url_launcher

Part of flutter/flutter#41721
Adds an endorsement for url_launcher_linux, so that Linux is supported
automatically.

Part of flutter/flutter#41721
Add missing iOS stub to shared_preferences_linux
Endorses shared_preferences_linux.

Since shared_preferences_linux is pure Dart, this uses manual registration of the Linux implementation. It is similar to the solution used for path_provider, but improves on it by more narrowly tailoring the registration to cases where another registration hasn't already been done, and only checking the first time, thus avoiding the need for a variable to override it.

Updates shared_preferences_linux to depend on path_provider_linux rather than path_provider, to avoid adding unnecessary native plugin dependencies to other platforms.

Also adds a driver test for shared_preference_linux, which I missed in reviewing the initial shared_preferences_linux landing.
* Switch to dart:html window.navigator.connection instead of package:js JS-interop.
* Overwrite connection.onchange instead of listening to connection.onChange Stream (prevents multiple subscriptions after hot-reload).
* Cleaned up old code related to generating the JS facade.
Introduce the first version of the `extension_google_sign_in_as_googleapis_auth` package.

This package lets users of the `google_sign_in` plugin to create an authenticated HTTP clients (from `googleapis_auth`) that can access any APIs from the `googleapis` package.
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this. Could you please update the CHANGELOG and pubspec.yaml with a new version please?

@MauScheff
Copy link
Contributor Author

LGTM! Thanks for fixing this. Could you please update the CHANGELOG and pubspec.yaml with a new version please?

Sure! I'm not so experienced with this so I'm not sure exactly what you mean. Would you like me to download the latest CHANGELOG and pubspec.yaml into this branch and resubmit?

@MauScheff
Copy link
Contributor Author

Also @cyanglaz I'm not sure where is the best place to have a live chat about a suggestion to improve this package's documentation [in_app_purchase]? I recently spent a lot of time getting it up and running with the different stores and I took some notes. I figured it could be useful to somehow share this notes and collaborate to write a comprehensible guide that covers some of the subtleties to get this package up and running and test it. Not sure where how is the best way to go about this. Can you point me in the right direction?

@cyanglaz
Copy link
Contributor

@eldermao1 every time we update a plugin, we need to update the CHANGELOG.MD and pubspec.yaml.
You can take a look at https://github.com/flutter/plugins/pull/2739/files as an example.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@MauScheff
Copy link
Contributor Author

@googlebot I fixed it

@MauScheff MauScheff closed this Jul 20, 2020
@MauScheff MauScheff reopened this Jul 20, 2020
@MauScheff MauScheff closed this Jul 20, 2020
@MauScheff MauScheff reopened this Jul 20, 2020
@MauScheff
Copy link
Contributor Author

@googlebot i fixed this

@MauScheff
Copy link
Contributor Author

@googlebot i fixed it

@MauScheff
Copy link
Contributor Author

@googlebot I fixed it

@MauScheff
Copy link
Contributor Author

@googlebot I fixed it.

@MauScheff
Copy link
Contributor Author

@cyanglaz For some reason my fork picked up other commits that weren't mine and now it's complaining about CLA. Do you suggest I just do this again in a new branch and drop this commit since it's only a one letter typo I was fixing?

@cyanglaz
Copy link
Contributor

@eldermao1 Sure. Please ping me when the new PR is ready. :)

@digiter digiter removed their request for review August 31, 2020 20:33
@cyanglaz
Copy link
Contributor

This is fixed in #2902

@cyanglaz cyanglaz closed this Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.