-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Conversation
By ensuring that flutter widget bindings are initialized. The current version fails on startup.
Once the switch to GTK lands, libgtk-3-dev will be needed for building.
… more complex navigation (#2755)
…esting (#2815) The recent federation of the Linux path provider might break tests, this updates the README.md to address those changes and direct the users how to mock the plugin in their tests.
Add a note about encoding URLs passed to the url_launcher in the packages README.
…ates. (#2834) * Allow all transactions except for purchasing ones to be passed back to the Flutter side. * Restore transactions shouldn't block transaction updates
* Fix e2e device pixel ratio * Update changelog and version * Formatting
Move the package formerly known as `experimental_connectivity_web` to flutter/plugins master, as `connectivity_for_web`.
Adds shared_preferences support for Linux. Part of flutter/flutter#41720
Expose a `Future` for `testResults` instead. This works better for internal use cases.
Missed this earlier in #2854
This change adds small bugfixes to the following packages: * video_player_web: * Prevent parsing Blob URLs so Safari can play from a PickedFile. * Allow users to 'mute' videos by setting their volume to 0.0 (this enables auto-play in most modern browsers) * video_player: * Fix an issue where aspect ratio calculations failed when some of the video sizes were zero (happened in web for incorrect videos) * image_picker (example app): * Start videos in web muted so they can auto-play * Dispose video controllers when they're really not needed. This fixes a fatal crash in Safari (not so fatal in other browsers).
Adds url_launcher_linux, the federated implementation of url_launcher. Not yet endorsed by url_launcher Part of flutter/flutter#41721
Adds an endorsement for url_launcher_linux, so that Linux is supported automatically. Part of flutter/flutter#41721
Add missing iOS stub to shared_preferences_linux
Endorses shared_preferences_linux. Since shared_preferences_linux is pure Dart, this uses manual registration of the Linux implementation. It is similar to the solution used for path_provider, but improves on it by more narrowly tailoring the registration to cases where another registration hasn't already been done, and only checking the first time, thus avoiding the need for a variable to override it. Updates shared_preferences_linux to depend on path_provider_linux rather than path_provider, to avoid adding unnecessary native plugin dependencies to other platforms. Also adds a driver test for shared_preference_linux, which I missed in reviewing the initial shared_preferences_linux landing.
* Switch to dart:html window.navigator.connection instead of package:js JS-interop. * Overwrite connection.onchange instead of listening to connection.onChange Stream (prevents multiple subscriptions after hot-reload). * Cleaned up old code related to generating the JS facade.
Introduce the first version of the `extension_google_sign_in_as_googleapis_auth` package. This package lets users of the `google_sign_in` plugin to create an authenticated HTTP clients (from `googleapis_auth`) that can access any APIs from the `googleapis` package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for fixing this. Could you please update the CHANGELOG and pubspec.yaml with a new version please?
Sure! I'm not so experienced with this so I'm not sure exactly what you mean. Would you like me to download the latest CHANGELOG and pubspec.yaml into this branch and resubmit? |
Also @cyanglaz I'm not sure where is the best place to have a live chat about a suggestion to improve this package's documentation [in_app_purchase]? I recently spent a lot of time getting it up and running with the different stores and I took some notes. I figured it could be useful to somehow share this notes and collaborate to write a comprehensible guide that covers some of the subtleties to get this package up and running and test it. Not sure where how is the best way to go about this. Can you point me in the right direction? |
* add extra info report
@eldermao1 every time we update a plugin, we need to update the CHANGELOG.MD and pubspec.yaml. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I fixed it |
@googlebot i fixed this |
@googlebot i fixed it |
@googlebot I fixed it |
@googlebot I fixed it. |
@cyanglaz For some reason my fork picked up other commits that weren't mine and now it's complaining about CLA. Do you suggest I just do this again in a new branch and drop this commit since it's only a one letter typo I was fixing? |
@eldermao1 Sure. Please ping me when the new PR is ready. :) |
This is fixed in #2902 |
Description
Fixed typo 'manuelly' for 'manually'
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?