Skip to content

Added debugging functionality. #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 28, 2020
Merged

Added debugging functionality. #150

merged 5 commits into from
Feb 28, 2020

Conversation

gnikit
Copy link
Member

@gnikit gnikit commented Oct 4, 2019

Hi,
Not having the option to add breaking points for debugging has been bothering me for quite some time and I think it is unreasonable to have to install a completely new extension about this, so I took the liberty of adding them in the extension.
The implemented changes are trivial overall.

@gnikit
Copy link
Member Author

gnikit commented Oct 4, 2019

I guess this branch should be merged to master after the dependabot PRs.

@krvajal
Copy link
Collaborator

krvajal commented Feb 27, 2020

Hi @gnikit and thanks for contributing.
The PR looks good. Maybe add some info in the docs (Readme.md) about how to use this feature and also which OS does it support?

@pedro-ricardo pedro-ricardo mentioned this pull request Feb 27, 2020
13 tasks
As stated in issue #9037 in github.com/microsoft/vscode
is the way to go. Fortran does not do anything different from
the inhouse C++ debugger, hence we should only have the
extension allow breaking points and nothing else.
This of course means that we will be depending on
Microsoft's C++ extension for the debugger.
@gnikit
Copy link
Member Author

gnikit commented Feb 27, 2020

Hi @gnikit and thanks for contributing.
The PR looks good. Maybe add some info in the docs (Readme.md) about how to use this feature and also which OS does it support?

So I think this is done, I updated the README, I also updated the way we define the debugger, there is no need to specify the type of the debugger cppdb in package.json. My first attempt was actually using a deprecated way of doing it.

However, I feel that I should mention this to make things clear.
The only thing that I have added is the ability to set breaking points in Fortran files, nothing else.
By adding the dependency on Microsoft's C/C++ ms-vscode.cpptools we can ensure that the users will have the underlying infrastructure to launch C++-like programs, Fortran falls under this category, through the Debug console of VS Code. So there is no explicit dependence of the extension on ms-vscode.cpptools.

I personally don't think that is an issue, but given how this is your extension I feel that I should let you know.

@krvajal krvajal changed the base branch from master to release/2.2.0 February 28, 2020 21:03
@krvajal krvajal merged commit 1fd49fd into fortran-lang:release/2.2.0 Feb 28, 2020
pedro-ricardo added a commit that referenced this pull request May 15, 2020
### Check List
- Highlight
- [x] `select` keyword - *Merge #165 to fix #149*
- [x] `rank` keyword -  *Merge #165*
- [x] `forall` keyword - *Merge #170 to fix #169*
- Symbol List
- [x] Symbols bug in VSCode +1.40 - *Merge #161 to fix #154*
- [x] Symbols classification - *Merge #141 to fix #140*
- [x] Long named symbols - *Merge #151*
- Settings
- [x] Add more options - *Merge #152*
- Dependencies
- [x] Merge `dependabot` PR's
    - [x] lodash - *Merge #144*
    - [x] mixin-deep - *Merge #146*
    - [x] handlebars - *Merge #155* 
- Code Completion
- [x] Array constructor - *Fix #148*
- New Features
- [x] Breakpoints - *Merge #150*
@gnikit gnikit deleted the feature/debug-support branch May 21, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants