Skip to content

Fix blocking due to very slow regex execution in "parseFunction" #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

hansec
Copy link
Contributor

@hansec hansec commented Dec 4, 2019

With long function names the current regex is very slow, effectively blocking symbols from being displayed in the outline view. Below is a minimal example based on Fortran Intellisense issue #19.

subroutine longsubroutinenamesuchasthisname(pos1,pos2,pos3) ! function
integer, intent(in) :: pos1,pos2,pos3,longvarname
end subroutine

@pedro-ricardo pedro-ricardo mentioned this pull request Feb 24, 2020
12 tasks
@pedro-ricardo pedro-ricardo changed the base branch from master to release/2.1.2 February 24, 2020 19:19
@pedro-ricardo pedro-ricardo merged commit 9da7fa4 into fortran-lang:release/2.1.2 Feb 24, 2020
@pedro-ricardo pedro-ricardo mentioned this pull request Feb 27, 2020
13 tasks
pedro-ricardo added a commit that referenced this pull request May 15, 2020
### Check List
- Highlight
- [x] `select` keyword - *Merge #165 to fix #149*
- [x] `rank` keyword -  *Merge #165*
- [x] `forall` keyword - *Merge #170 to fix #169*
- Symbol List
- [x] Symbols bug in VSCode +1.40 - *Merge #161 to fix #154*
- [x] Symbols classification - *Merge #141 to fix #140*
- [x] Long named symbols - *Merge #151*
- Settings
- [x] Add more options - *Merge #152*
- Dependencies
- [x] Merge `dependabot` PR's
    - [x] lodash - *Merge #144*
    - [x] mixin-deep - *Merge #146*
    - [x] handlebars - *Merge #155* 
- Code Completion
- [x] Array constructor - *Fix #148*
- New Features
- [x] Breakpoints - *Merge #150*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants