Fix in-line forall highlighting #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
pedro-ricardo
added a commit
that referenced
this pull request
May 15, 2020
### Check List - Highlight - [x] `select` keyword - *Merge #165 to fix #149* - [x] `rank` keyword - *Merge #165* - [x] `forall` keyword - *Merge #170 to fix #169* - Symbol List - [x] Symbols bug in VSCode +1.40 - *Merge #161 to fix #154* - [x] Symbols classification - *Merge #141 to fix #140* - [x] Long named symbols - *Merge #151* - Settings - [x] Add more options - *Merge #152* - Dependencies - [x] Merge `dependabot` PR's - [x] lodash - *Merge #144* - [x] mixin-deep - *Merge #146* - [x] handlebars - *Merge #155* - Code Completion - [x] Array constructor - *Fix #148* - New Features - [x] Breakpoints - *Merge #150*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to fix issue #169, which reported that single-line
forallstatements have have incorrect highlighting. The error arrises because the existing patterns assume that allforallstatements end with anend forall. However, this is not true of single-line statements.This solution follows the already implemented patterns of the
wherestatement, which has a very similar syntax.Before Change
After change
Side note: an identical issue and resolution can be found in a Fortran highligter made for Atom (dparkins/language-fortran#90).