feat(bridge): confirm block based on "safe" and "finalized" tags #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
|
|
|
|
|
|
|
Thegaram
changed the title
|
|
ChuhanJin
reviewed
Jan 28, 2023
|
I guess This PR is to complicate a simple logic. |
|
|
0xmountaintop
approved these changes
Feb 8, 2023
NazariiDenha
approved these changes
Feb 9, 2023
ChuhanJin
pushed a commit
that referenced
this pull request
Mar 15, 2023
# This is the 1st commit message: feat: add monitor metrics (#262) Co-authored-by: colinlyguo <[email protected]> Co-authored-by: maskpp <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: Péter Garamvölgyi <[email protected]> # This is the commit message #2: refactor(bridge): remove layer1 client in in layer1 relayer constructor (#274) Co-authored-by: vincent <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> # This is the commit message #3: fix: add gas multiplier (#275) # This is the commit message #4: feat(libzkp): use dylib instead of staticlib (#266) Co-authored-by: maskpp <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: colin <[email protected]> Co-authored-by: colinlyguo <[email protected]> # This is the commit message #5: Revert "fix: add gas multiplier (#275)" (#279) # This is the commit message #6: build: add nightly-2022-12-10 rust-related builder image (#282) # This is the commit message #7: fix(bridge): compatible with DynamicFeeTxType not supported chain (#280) Co-authored-by: colinlyguo <[email protected]> # This is the commit message #8: feat(contract): enable whitelist relayer (#272) Co-authored-by: Péter Garamvölgyi <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> # This is the commit message #9: perf(bridge): execute relayer loops independently (#258) Co-authored-by: colin <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> # This is the commit message #10: feat(bridge): confirm block based on "safe" and "finalized" tags (#265) # This is the commit message #11: feat: allow to override L2 deployment when address is provided (#293) # This is the commit message #12: feat(contracts): Add fee vault (#223) # This is the commit message #13: feat(confirmations): Upgrade confirm (#291) # This is the commit message #14: feat(coordinator): Enable set ws compression level. (#292) # This is the commit message #15: feat(roller&coordinator): upgrade lizkp to zkevm-0215 version (#281) Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: xinran chen <[email protected]> Co-authored-by: Ubuntu <[email protected]> # This is the commit message #16: build: update version to `alpha-v1.0` (#301) # This is the commit message #17: feat: import genesis batch during startup (#299) Co-authored-by: HAOYUatHZ <[email protected]> # This is the commit message #18: feat(contracts): new bridge contracts (#288) Co-authored-by: Haichen Shen <[email protected]> Co-authored-by: Thegaram <[email protected]> Co-authored-by: colin <[email protected]> # This is the commit message #19: chore: upgrade l2geth dependency for trace type (#304)
ChuhanJin
pushed a commit
that referenced
this pull request
Mar 15, 2023
Co-authored-by: colinlyguo <[email protected]> Co-authored-by: maskpp <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: Péter Garamvölgyi <[email protected]> refactor(bridge): remove layer1 client in in layer1 relayer constructor (#274) Co-authored-by: vincent <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> fix: add gas multiplier (#275) feat(libzkp): use dylib instead of staticlib (#266) Co-authored-by: maskpp <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: colin <[email protected]> Co-authored-by: colinlyguo <[email protected]> Revert "fix: add gas multiplier (#275)" (#279) build: add nightly-2022-12-10 rust-related builder image (#282) fix(bridge): compatible with DynamicFeeTxType not supported chain (#280) Co-authored-by: colinlyguo <[email protected]> feat(contract): enable whitelist relayer (#272) Co-authored-by: Péter Garamvölgyi <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> perf(bridge): execute relayer loops independently (#258) Co-authored-by: colin <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> feat(bridge): confirm block based on "safe" and "finalized" tags (#265) feat: allow to override L2 deployment when address is provided (#293) feat(contracts): Add fee vault (#223) feat(confirmations): Upgrade confirm (#291) feat(coordinator): Enable set ws compression level. (#292) feat(roller&coordinator): upgrade lizkp to zkevm-0215 version (#281) Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: xinran chen <[email protected]> Co-authored-by: Ubuntu <[email protected]> build: update version to `alpha-v1.0` (#301) feat: import genesis batch during startup (#299) Co-authored-by: HAOYUatHZ <[email protected]> feat(contracts): new bridge contracts (#288) Co-authored-by: Haichen Shen <[email protected]> Co-authored-by: Thegaram <[email protected]> Co-authored-by: colin <[email protected]> chore: upgrade l2geth dependency for trace type (#304) feat(bridge): update the watcher and relayer based on the new contract (#305) Co-authored-by: colinlyguo <[email protected]> Co-authored-by: zimpha <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> fix incorrect block order during batch recovery (#311) fix(bridge): fix batch proposer (#312) Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: Péter Garamvölgyi <[email protected]> fix: Flush buffered writer (#314) fix(config): fix typos (#315) feat(bridge): only update gas price oracle for exceeding diff threshold (#319) fix(bridge): fix typos (#321) feat(batch proposer): add time limit to commit batches (#323) fix(db): fix `SetMaxOpenConns` (#328) Fix(zkevm): fix zkevm bug for goerli. (#334) fix(build): jenkinsfile tag job optimized and fix (#331) Co-authored-by: vincent <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> fix: reduce finalize batch tx frequency (#332) alpha inegration with multibin fix makefile fix lint fix lint try fix commit op fix lint goimports trigger ci bugfix(libzkp): fix difficulty (#343) fix(contract): forbid to call message queue and l2 messenger from l1 (#341) Co-authored-by: HAOYUatHZ <[email protected]> fix(roller): fix stack bug (#320) Co-authored-by: HAOYUatHZ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or design rationale of this PR
Post-merge Ethereum exposes the
"safe"and"finalized"block tags in many of its APIs. These offer more reliable confirmation tools than simply waiting for N number of blocks.After this PR, we will have 3 confirmation options to use in
config.json:"finalized","safe", and"number=N"(where N is a number between 0 and 1000).Does this PR involve a new deployment, and involve a new git tag & docker image tag? If so, has
tagincommon/version.gobeen updated?Yes.
Is this PR a breaking change? If so, have it been attached a
breaking-changelabel?Yes, this is a breaking configuration change.
Related l2geth change: scroll-tech/go-ethereum#202