Skip to content

feat(confirmations): Upgrade confirm #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 12, 2023
Merged

feat(confirmations): Upgrade confirm #291

merged 8 commits into from
Feb 12, 2023

Conversation

mask-pp
Copy link
Contributor

@mask-pp mask-pp commented Feb 10, 2023 •
edited
Loading

  1. Purpose or design rationale of this PR
    When the PR merged we can use finalized and safe in config file again.
    Simplify the usage of confirmations field by rpc.BlockNumber.

  2. Does this PR involve a new deployment, and involve a new git tag & docker image tag? If so, has tag in common/version.go been updated?
    Yes

  3. Is this PR a breaking change? If so, have it been attached a breaking-change label?
    Yes

@ChuhanJin
Copy link
Contributor

46% (-0.38%) vs master 47%

@ChuhanJin
Copy link
Contributor

46% (-0.38%) vs master 47%

@mask-pp mask-pp marked this pull request as draft February 10, 2023 07:36
@ChuhanJin
Copy link
Contributor

46% (-0.38%) vs master 47%

@mask-pp mask-pp marked this pull request as ready for review February 10, 2023 07:46
Thegaram
Thegaram reviewed Feb 10, 2023
View reviewed changes
Thegaram
Thegaram previously approved these changes Feb 10, 2023
View reviewed changes
@ChuhanJin
Copy link
Contributor

46% (-0.38%) vs master 47%

@mask-pp mask-pp requested a review from Thegaram February 10, 2023 09:31
Thegaram
Thegaram previously approved these changes Feb 10, 2023
View reviewed changes
colinlyguo
colinlyguo reviewed Feb 10, 2023
View reviewed changes
@ChuhanJin
Copy link
Contributor

46% (-0.38%) vs master 47%

colinlyguo
colinlyguo previously approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@colinlyguo colinlyguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ChuhanJin
Copy link
Contributor

46% (-0.38%) vs master 47%

@mask-pp mask-pp dismissed stale reviews from colinlyguo and Thegaram via 04bf064 February 10, 2023 10:01
@ChuhanJin
Copy link
Contributor

46% (-0.38%) vs master 47%

@mask-pp mask-pp merged commit fbcabcc into staging Feb 12, 2023
@mask-pp mask-pp deleted the maskpp/upgrade_confirm branch February 12, 2023 11:06
ChuhanJin pushed a commit that referenced this pull request Mar 15, 2023
@colinlyguo @JJVincentJJ
# This is a combination of 19 commits.
c9c148c 
# This is the 1st commit message:

feat: add monitor metrics (#262)

Co-authored-by: colinlyguo <[email protected]>
Co-authored-by: maskpp <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
Co-authored-by: Péter Garamvölgyi <[email protected]>
# This is the commit message #2:

refactor(bridge): remove layer1 client in in layer1 relayer constructor (#274)

Co-authored-by: vincent <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
# This is the commit message #3:

fix: add gas multiplier (#275)


# This is the commit message #4:

feat(libzkp): use dylib instead of staticlib  (#266)

Co-authored-by: maskpp <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
Co-authored-by: colin <[email protected]>
Co-authored-by: colinlyguo <[email protected]>
# This is the commit message #5:

Revert "fix: add gas multiplier (#275)" (#279)


# This is the commit message #6:

build: add nightly-2022-12-10 rust-related builder image (#282)


# This is the commit message #7:

fix(bridge): compatible with DynamicFeeTxType not supported chain (#280)

Co-authored-by: colinlyguo <[email protected]>
# This is the commit message #8:

feat(contract): enable whitelist relayer (#272)

Co-authored-by: Péter Garamvölgyi <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
# This is the commit message #9:

perf(bridge): execute relayer loops independently (#258)

Co-authored-by: colin <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
# This is the commit message #10:

feat(bridge): confirm block based on "safe" and "finalized" tags (#265)


# This is the commit message #11:

feat: allow to override L2 deployment when address is provided (#293)


# This is the commit message #12:

feat(contracts): Add fee vault (#223)


# This is the commit message #13:

feat(confirmations): Upgrade confirm (#291)


# This is the commit message #14:

feat(coordinator): Enable set ws compression level. (#292)


# This is the commit message #15:

feat(roller&coordinator): upgrade lizkp to zkevm-0215 version (#281)

Co-authored-by: HAOYUatHZ <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
Co-authored-by: xinran chen <[email protected]>
Co-authored-by: Ubuntu <[email protected]>
# This is the commit message #16:

build: update version to `alpha-v1.0` (#301)


# This is the commit message #17:

feat: import genesis batch during startup (#299)

Co-authored-by: HAOYUatHZ <[email protected]>
# This is the commit message #18:

feat(contracts): new bridge contracts (#288)

Co-authored-by: Haichen Shen <[email protected]>
Co-authored-by: Thegaram <[email protected]>
Co-authored-by: colin <[email protected]>
# This is the commit message #19:

chore: upgrade l2geth dependency for trace type (#304)
ChuhanJin pushed a commit that referenced this pull request Mar 15, 2023
@JJVincentJJ @0xmountaintop
feat: add monitor metrics (#262)
770e0b1 
Co-authored-by: colinlyguo <[email protected]>
Co-authored-by: maskpp <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
Co-authored-by: Péter Garamvölgyi <[email protected]>

refactor(bridge): remove layer1 client in in layer1 relayer constructor (#274)

Co-authored-by: vincent <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>

fix: add gas multiplier (#275)

feat(libzkp): use dylib instead of staticlib  (#266)

Co-authored-by: maskpp <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
Co-authored-by: colin <[email protected]>
Co-authored-by: colinlyguo <[email protected]>

Revert "fix: add gas multiplier (#275)" (#279)

build: add nightly-2022-12-10 rust-related builder image (#282)

fix(bridge): compatible with DynamicFeeTxType not supported chain (#280)

Co-authored-by: colinlyguo <[email protected]>

feat(contract): enable whitelist relayer (#272)

Co-authored-by: Péter Garamvölgyi <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>

perf(bridge): execute relayer loops independently (#258)

Co-authored-by: colin <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>

feat(bridge): confirm block based on "safe" and "finalized" tags (#265)

feat: allow to override L2 deployment when address is provided (#293)

feat(contracts): Add fee vault (#223)

feat(confirmations): Upgrade confirm (#291)

feat(coordinator): Enable set ws compression level. (#292)

feat(roller&coordinator): upgrade lizkp to zkevm-0215 version (#281)

Co-authored-by: HAOYUatHZ <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
Co-authored-by: xinran chen <[email protected]>
Co-authored-by: Ubuntu <[email protected]>

build: update version to `alpha-v1.0` (#301)

feat: import genesis batch during startup (#299)

Co-authored-by: HAOYUatHZ <[email protected]>

feat(contracts): new bridge contracts (#288)

Co-authored-by: Haichen Shen <[email protected]>
Co-authored-by: Thegaram <[email protected]>
Co-authored-by: colin <[email protected]>

chore: upgrade l2geth dependency for trace type (#304)

feat(bridge): update the watcher and relayer based on the new contract (#305)

Co-authored-by: colinlyguo <[email protected]>
Co-authored-by: zimpha <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>

fix incorrect block order during batch recovery (#311)

fix(bridge): fix batch proposer (#312)

Co-authored-by: HAOYUatHZ <[email protected]>
Co-authored-by: Péter Garamvölgyi <[email protected]>

fix: Flush buffered writer (#314)

fix(config): fix typos (#315)

feat(bridge): only update gas price oracle for exceeding diff threshold (#319)

fix(bridge): fix typos (#321)

feat(batch proposer): add time limit to commit batches (#323)

fix(db): fix `SetMaxOpenConns` (#328)

Fix(zkevm): fix zkevm bug for goerli.  (#334)

fix(build): jenkinsfile tag job optimized and fix (#331)

Co-authored-by: vincent <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>

fix: reduce finalize batch tx frequency (#332)

alpha inegration with multibin

fix makefile

fix lint

fix lint

try fix commit

op

fix lint

goimports

trigger ci

bugfix(libzkp): fix difficulty (#343)

fix(contract): forbid to call message queue and l2 messenger from l1 (#341)

Co-authored-by: HAOYUatHZ <[email protected]>

fix(roller): fix stack bug (#320)

Co-authored-by: HAOYUatHZ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thegaram Thegaram Thegaram approved these changes

@0xmountaintop 0xmountaintop Awaiting requested review from 0xmountaintop

@ChuhanJin ChuhanJin Awaiting requested review from ChuhanJin

+1 more reviewer

@colinlyguo colinlyguo colinlyguo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mask-pp @ChuhanJin @Thegaram @colinlyguo