fix(bridge): compatible with DynamicFeeTxType not supported chain #280

colinlyguo · 2023-02-03T10:06:27Z

Purpose or design rationale of this PR
If block header does not contain baseFeePerGas (due to disabling EIP-1559), the bridge will crush due to invalid memory address or nil pointer dereference in starting.
This PR is to make bridge compatible with block header without baseFeePerGas.
Does this PR involve a new deployment, and involve a new git tag & docker image tag? If so, has tag in common/version.go been updated?
Y.
Is this PR a breaking change? If so, have it been attached a breaking-change label?
N.

ChuhanJin · 2023-02-03T10:10:44Z

ChuhanJin · 2023-02-03T10:48:41Z

ChuhanJin · 2023-02-03T10:52:41Z

bridge/sender/sender.go

ChuhanJin · 2023-02-03T12:19:06Z

mask-pp · 2023-02-03T13:07:34Z

Please update l2geth's version in common/docker/l2geth/Dockerfile.

colinlyguo · 2023-02-03T13:08:44Z

Please update l2geth's version in common/docker/l2geth/Dockerfile.

done.

ChuhanJin · 2023-02-03T13:41:18Z

bridge/config.json

ChuhanJin · 2023-02-06T03:40:57Z

bridge/sender/sender.go

ChuhanJin · 2023-02-06T04:29:30Z

bridge/sender/sender.go

ChuhanJin · 2023-02-06T05:19:05Z

# This is the 1st commit message: feat: add monitor metrics (#262) Co-authored-by: colinlyguo <[email protected]> Co-authored-by: maskpp <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: Péter Garamvölgyi <[email protected]> # This is the commit message #2: refactor(bridge): remove layer1 client in in layer1 relayer constructor (#274) Co-authored-by: vincent <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> # This is the commit message #3: fix: add gas multiplier (#275) # This is the commit message #4: feat(libzkp): use dylib instead of staticlib (#266) Co-authored-by: maskpp <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: colin <[email protected]> Co-authored-by: colinlyguo <[email protected]> # This is the commit message #5: Revert "fix: add gas multiplier (#275)" (#279) # This is the commit message #6: build: add nightly-2022-12-10 rust-related builder image (#282) # This is the commit message #7: fix(bridge): compatible with DynamicFeeTxType not supported chain (#280) Co-authored-by: colinlyguo <[email protected]> # This is the commit message #8: feat(contract): enable whitelist relayer (#272) Co-authored-by: Péter Garamvölgyi <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> # This is the commit message #9: perf(bridge): execute relayer loops independently (#258) Co-authored-by: colin <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> # This is the commit message #10: feat(bridge): confirm block based on "safe" and "finalized" tags (#265) # This is the commit message #11: feat: allow to override L2 deployment when address is provided (#293) # This is the commit message #12: feat(contracts): Add fee vault (#223) # This is the commit message #13: feat(confirmations): Upgrade confirm (#291) # This is the commit message #14: feat(coordinator): Enable set ws compression level. (#292) # This is the commit message #15: feat(roller&coordinator): upgrade lizkp to zkevm-0215 version (#281) Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: xinran chen <[email protected]> Co-authored-by: Ubuntu <[email protected]> # This is the commit message #16: build: update version to `alpha-v1.0` (#301) # This is the commit message #17: feat: import genesis batch during startup (#299) Co-authored-by: HAOYUatHZ <[email protected]> # This is the commit message #18: feat(contracts): new bridge contracts (#288) Co-authored-by: Haichen Shen <[email protected]> Co-authored-by: Thegaram <[email protected]> Co-authored-by: colin <[email protected]> # This is the commit message #19: chore: upgrade l2geth dependency for trace type (#304)

Co-authored-by: colinlyguo <[email protected]> Co-authored-by: maskpp <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: Péter Garamvölgyi <[email protected]> refactor(bridge): remove layer1 client in in layer1 relayer constructor (#274) Co-authored-by: vincent <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> fix: add gas multiplier (#275) feat(libzkp): use dylib instead of staticlib (#266) Co-authored-by: maskpp <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: colin <[email protected]> Co-authored-by: colinlyguo <[email protected]> Revert "fix: add gas multiplier (#275)" (#279) build: add nightly-2022-12-10 rust-related builder image (#282) fix(bridge): compatible with DynamicFeeTxType not supported chain (#280) Co-authored-by: colinlyguo <[email protected]> feat(contract): enable whitelist relayer (#272) Co-authored-by: Péter Garamvölgyi <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> perf(bridge): execute relayer loops independently (#258) Co-authored-by: colin <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> feat(bridge): confirm block based on "safe" and "finalized" tags (#265) feat: allow to override L2 deployment when address is provided (#293) feat(contracts): Add fee vault (#223) feat(confirmations): Upgrade confirm (#291) feat(coordinator): Enable set ws compression level. (#292) feat(roller&coordinator): upgrade lizkp to zkevm-0215 version (#281) Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: xinran chen <[email protected]> Co-authored-by: Ubuntu <[email protected]> build: update version to `alpha-v1.0` (#301) feat: import genesis batch during startup (#299) Co-authored-by: HAOYUatHZ <[email protected]> feat(contracts): new bridge contracts (#288) Co-authored-by: Haichen Shen <[email protected]> Co-authored-by: Thegaram <[email protected]> Co-authored-by: colin <[email protected]> chore: upgrade l2geth dependency for trace type (#304) feat(bridge): update the watcher and relayer based on the new contract (#305) Co-authored-by: colinlyguo <[email protected]> Co-authored-by: zimpha <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> fix incorrect block order during batch recovery (#311) fix(bridge): fix batch proposer (#312) Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: Péter Garamvölgyi <[email protected]> fix: Flush buffered writer (#314) fix(config): fix typos (#315) feat(bridge): only update gas price oracle for exceeding diff threshold (#319) fix(bridge): fix typos (#321) feat(batch proposer): add time limit to commit batches (#323) fix(db): fix `SetMaxOpenConns` (#328) Fix(zkevm): fix zkevm bug for goerli. (#334) fix(build): jenkinsfile tag job optimized and fix (#331) Co-authored-by: vincent <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> fix: reduce finalize batch tx frequency (#332) alpha inegration with multibin fix makefile fix lint fix lint try fix commit op fix lint goimports trigger ci bugfix(libzkp): fix difficulty (#343) fix(contract): forbid to call message queue and l2 messenger from l1 (#341) Co-authored-by: HAOYUatHZ <[email protected]> fix(roller): fix stack bug (#320) Co-authored-by: HAOYUatHZ <[email protected]>

colinlyguo added 2 commits February 3, 2023 17:59

fix: set bridge baseFeePerGas to 0

8a4db7b

bump version

4002010

colinlyguo requested review from Thegaram and 0xmountaintop February 3, 2023 10:11

colinlyguo marked this pull request as ready for review February 3, 2023 10:11

0xmountaintop previously approved these changes Feb 3, 2023

View reviewed changes

colinlyguo and others added 2 commits February 3, 2023 18:44

Merge branch 'staging' into fix-set-base-fee-to-zero

359e2f6

bump version

f105c8d

colinlyguo dismissed 0xmountaintop’s stale review via f105c8d February 3, 2023 10:47

Thegaram requested changes Feb 3, 2023

View reviewed changes

bridge/sender/sender.go Outdated Show resolved Hide resolved

fix: compatitable with DynamicFeeTxType not supported chain

e3561b0

colinlyguo changed the title ~~fix(bridge): set baseFeePerGas to 0~~ fix(bridge): compatible with DynamicFeeTxType not supported chain Feb 3, 2023

Thegaram previously approved these changes Feb 3, 2023

View reviewed changes

colinlyguo requested review from mask-pp and 0xmountaintop February 3, 2023 12:50

upgrade l2geth/Dockerfile

20279ff

colinlyguo dismissed Thegaram’s stale review via 20279ff February 3, 2023 13:07

0xmountaintop previously approved these changes Feb 3, 2023

View reviewed changes

change unit test tx type to legacy

bec4fc8

colinlyguo dismissed 0xmountaintop’s stale review via bec4fc8 February 3, 2023 13:36

colinlyguo requested review from Thegaram and 0xmountaintop February 3, 2023 13:45

0xmountaintop previously approved these changes Feb 3, 2023

View reviewed changes

Thegaram previously approved these changes Feb 3, 2023

View reviewed changes

bridge/config.json Show resolved Hide resolved

Merge branch 'staging' into fix-set-base-fee-to-zero

12bdc69

mask-pp previously approved these changes Feb 6, 2023

View reviewed changes

0xmountaintop reviewed Feb 6, 2023

View reviewed changes

bridge/sender/sender.go Outdated Show resolved Hide resolved

fix comments

90f629c

colinlyguo dismissed stale reviews from mask-pp, Thegaram, and 0xmountaintop via 90f629c February 6, 2023 04:24

0xmountaintop reviewed Feb 6, 2023

View reviewed changes

bridge/sender/sender.go Outdated Show resolved Hide resolved

fix bug

0389d93

0xmountaintop approved these changes Feb 6, 2023

View reviewed changes

scroll-dev approved these changes Feb 6, 2023

View reviewed changes

scroll-dev merged commit 33a912e into staging Feb 6, 2023

scroll-dev deleted the fix-set-base-fee-to-zero branch February 6, 2023 05:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(bridge): compatible with DynamicFeeTxType not supported chain #280

fix(bridge): compatible with DynamicFeeTxType not supported chain #280

Uh oh!

colinlyguo commented Feb 3, 2023 •

edited

Loading

Uh oh!

ChuhanJin commented Feb 3, 2023

Uh oh!

ChuhanJin commented Feb 3, 2023

Uh oh!

ChuhanJin commented Feb 3, 2023

Uh oh!

Uh oh!

ChuhanJin commented Feb 3, 2023

Uh oh!

mask-pp commented Feb 3, 2023

Uh oh!

colinlyguo commented Feb 3, 2023

Uh oh!

ChuhanJin commented Feb 3, 2023

Uh oh!

Uh oh!

ChuhanJin commented Feb 6, 2023

Uh oh!

Uh oh!

ChuhanJin commented Feb 6, 2023

Uh oh!

Uh oh!

ChuhanJin commented Feb 6, 2023

Uh oh!

Uh oh!

fix(bridge): compatible with DynamicFeeTxType not supported chain #280

fix(bridge): compatible with DynamicFeeTxType not supported chain #280

Uh oh!

Conversation

colinlyguo commented Feb 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChuhanJin commented Feb 3, 2023

Uh oh!

ChuhanJin commented Feb 3, 2023

Uh oh!

ChuhanJin commented Feb 3, 2023

Uh oh!

Uh oh!

ChuhanJin commented Feb 3, 2023

Uh oh!

mask-pp commented Feb 3, 2023

Uh oh!

colinlyguo commented Feb 3, 2023

Uh oh!

ChuhanJin commented Feb 3, 2023

Uh oh!

Uh oh!

ChuhanJin commented Feb 6, 2023

Uh oh!

Uh oh!

ChuhanJin commented Feb 6, 2023

Uh oh!

Uh oh!

ChuhanJin commented Feb 6, 2023

Uh oh!

Uh oh!

colinlyguo commented Feb 3, 2023 •

edited

Loading