feat(libzkp): use dylib instead of staticlib #266

Lawliet-Chan · 2023-01-28T14:17:40Z

Purpose or design rationale of this PR
Use dynamic library for golang instead of static library. Prepare for (frozen) Scroll dev 1220 scroll-prover#92
Does this PR involve a new deployment, and involve a new git tag & docker image tag? If so, has tag in common/version.go been updated?
yes
Is this PR a breaking change? If so, have it been attached a breaking-change label?
yes

This reverts commit 28ad8ad.

This reverts commit 6bd6d6f.

ChuhanJin · 2023-01-28T14:23:08Z

ChuhanJin · 2023-01-28T14:29:33Z

…api in bridge.l2backend. (#228) Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: colin <[email protected]> Co-authored-by: colinlyguo <[email protected]>

0xmountaintop · 2023-01-29T02:38:21Z

why do we change roller/assets/traces/*.json?

Lawliet-Chan · 2023-01-29T02:48:38Z

why do we change roller/assets/traces/*.json?

Because:

I drop the RpcStruct, only use blockTrace, so we don't need these "jsonrpc": "2.0", "id": 1,.
I copy the trace files directly from https://github.com/scroll-tech/scroll-zkevm/tree/fix/mpt_limit/zkevm/tests/traces/bridge, I think in the future we should keep the traces as same as scroll-zkevm

0xmountaintop · 2023-01-29T08:34:15Z

why do we change roller/assets/traces/*.json?

Because:

I drop the RpcStruct, only use blockTrace, so we don't need these "jsonrpc": "2.0", "id": 1,.

I copy the trace files directly from https://github.com/scroll-tech/scroll-zkevm/tree/fix/mpt_limit/zkevm/tests/traces/bridge, I think in the future we should keep the traces as same as scroll-zkevm

then maybe use 04.json ~ 09.json

01.json ~ 03.json have empty txs

ChuhanJin · 2023-01-29T10:35:56Z

ChuhanJin · 2023-01-29T13:51:37Z

ChuhanJin · 2023-01-31T10:02:47Z

…d trace api in bridge.l2backend. (#228)" This reverts commit b5549f6.

ChuhanJin · 2023-01-31T10:13:37Z

common/version/version.go

build/dockerfiles/coordinator.Dockerfile

Co-authored-by: HAOYUatHZ <[email protected]>

ChuhanJin · 2023-01-31T12:22:44Z

colinlyguo

LGTM.

ChuhanJin · 2023-02-01T05:56:37Z

ChuhanJin · 2023-02-01T06:00:42Z

coordinator/verifier/verifier_test.go

ChuhanJin · 2023-02-02T02:19:32Z

ChuhanJin · 2023-02-02T07:20:12Z

# This is the 1st commit message: feat: add monitor metrics (#262) Co-authored-by: colinlyguo <[email protected]> Co-authored-by: maskpp <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: Péter Garamvölgyi <[email protected]> # This is the commit message #2: refactor(bridge): remove layer1 client in in layer1 relayer constructor (#274) Co-authored-by: vincent <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> # This is the commit message #3: fix: add gas multiplier (#275) # This is the commit message #4: feat(libzkp): use dylib instead of staticlib (#266) Co-authored-by: maskpp <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: colin <[email protected]> Co-authored-by: colinlyguo <[email protected]> # This is the commit message #5: Revert "fix: add gas multiplier (#275)" (#279) # This is the commit message #6: build: add nightly-2022-12-10 rust-related builder image (#282) # This is the commit message #7: fix(bridge): compatible with DynamicFeeTxType not supported chain (#280) Co-authored-by: colinlyguo <[email protected]> # This is the commit message #8: feat(contract): enable whitelist relayer (#272) Co-authored-by: Péter Garamvölgyi <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> # This is the commit message #9: perf(bridge): execute relayer loops independently (#258) Co-authored-by: colin <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> # This is the commit message #10: feat(bridge): confirm block based on "safe" and "finalized" tags (#265) # This is the commit message #11: feat: allow to override L2 deployment when address is provided (#293) # This is the commit message #12: feat(contracts): Add fee vault (#223) # This is the commit message #13: feat(confirmations): Upgrade confirm (#291) # This is the commit message #14: feat(coordinator): Enable set ws compression level. (#292) # This is the commit message #15: feat(roller&coordinator): upgrade lizkp to zkevm-0215 version (#281) Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: xinran chen <[email protected]> Co-authored-by: Ubuntu <[email protected]> # This is the commit message #16: build: update version to `alpha-v1.0` (#301) # This is the commit message #17: feat: import genesis batch during startup (#299) Co-authored-by: HAOYUatHZ <[email protected]> # This is the commit message #18: feat(contracts): new bridge contracts (#288) Co-authored-by: Haichen Shen <[email protected]> Co-authored-by: Thegaram <[email protected]> Co-authored-by: colin <[email protected]> # This is the commit message #19: chore: upgrade l2geth dependency for trace type (#304)

Co-authored-by: colinlyguo <[email protected]> Co-authored-by: maskpp <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: Péter Garamvölgyi <[email protected]> refactor(bridge): remove layer1 client in in layer1 relayer constructor (#274) Co-authored-by: vincent <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> fix: add gas multiplier (#275) feat(libzkp): use dylib instead of staticlib (#266) Co-authored-by: maskpp <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: colin <[email protected]> Co-authored-by: colinlyguo <[email protected]> Revert "fix: add gas multiplier (#275)" (#279) build: add nightly-2022-12-10 rust-related builder image (#282) fix(bridge): compatible with DynamicFeeTxType not supported chain (#280) Co-authored-by: colinlyguo <[email protected]> feat(contract): enable whitelist relayer (#272) Co-authored-by: Péter Garamvölgyi <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> perf(bridge): execute relayer loops independently (#258) Co-authored-by: colin <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> feat(bridge): confirm block based on "safe" and "finalized" tags (#265) feat: allow to override L2 deployment when address is provided (#293) feat(contracts): Add fee vault (#223) feat(confirmations): Upgrade confirm (#291) feat(coordinator): Enable set ws compression level. (#292) feat(roller&coordinator): upgrade lizkp to zkevm-0215 version (#281) Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: xinran chen <[email protected]> Co-authored-by: Ubuntu <[email protected]> build: update version to `alpha-v1.0` (#301) feat: import genesis batch during startup (#299) Co-authored-by: HAOYUatHZ <[email protected]> feat(contracts): new bridge contracts (#288) Co-authored-by: Haichen Shen <[email protected]> Co-authored-by: Thegaram <[email protected]> Co-authored-by: colin <[email protected]> chore: upgrade l2geth dependency for trace type (#304) feat(bridge): update the watcher and relayer based on the new contract (#305) Co-authored-by: colinlyguo <[email protected]> Co-authored-by: zimpha <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> fix incorrect block order during batch recovery (#311) fix(bridge): fix batch proposer (#312) Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: Péter Garamvölgyi <[email protected]> fix: Flush buffered writer (#314) fix(config): fix typos (#315) feat(bridge): only update gas price oracle for exceeding diff threshold (#319) fix(bridge): fix typos (#321) feat(batch proposer): add time limit to commit batches (#323) fix(db): fix `SetMaxOpenConns` (#328) Fix(zkevm): fix zkevm bug for goerli. (#334) fix(build): jenkinsfile tag job optimized and fix (#331) Co-authored-by: vincent <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> fix: reduce finalize batch tx frequency (#332) alpha inegration with multibin fix makefile fix lint fix lint try fix commit op fix lint goimports trigger ci bugfix(libzkp): fix difficulty (#343) fix(contract): forbid to call message queue and l2 messenger from l1 (#341) Co-authored-by: HAOYUatHZ <[email protected]> fix(roller): fix stack bug (#320) Co-authored-by: HAOYUatHZ <[email protected]>

Lawliet-Chan added 13 commits January 28, 2023 15:42

dylib

7f0cdc2

fix path

6cf5e94

fix path

0c7fa22

fix path

c673989

fix path

c318e0b

update traces

c349619

update traces 5,6,7

28ad8ad

Revert "update traces 5,6,7"

6bd6d6f

This reverts commit 28ad8ad.

Revert "Revert "update traces 5,6,7""

0caf3cc

This reverts commit 6bd6d6f.

rm rpc struct

05c1208

fix

93542e1

dump proof

64d7971

use traces 1,2,3

361e440

clean

a658f83

mask-pp and others added 3 commits January 29, 2023 09:56

feat(cache and trace api): Add redis cache in database and add trace …

b5549f6

…api in bridge.l2backend. (#228) Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: colin <[email protected]> Co-authored-by: colinlyguo <[email protected]>

Merge branch 'staging' into dynamic_ffi

99aa1d3

trigger CI

cade156

Lawliet-Chan requested a review from 0xmountaintop January 29, 2023 06:14

add 04~09.json

5b244b3

mask-pp and others added 2 commits January 29, 2023 20:46

fix(docker redis): Fix redis docker randomly panic. (#267)

c8c063b

Merge branch 'staging' into dynamic_ffi

1044092

0xmountaintop and others added 2 commits January 30, 2023 10:48

feat(redis): support ClusterClient (#268)

346c713

Merge branch 'staging' into dynamic_ffi

274fb42

Revert "feat(cache and trace api): Add redis cache in database and ad…

7021d45

…d trace api in bridge.l2backend. (#228)" This reverts commit b5549f6.

0xmountaintop reviewed Jan 31, 2023

View reviewed changes

common/version/version.go Outdated Show resolved Hide resolved

0xmountaintop reviewed Jan 31, 2023

View reviewed changes

build/dockerfiles/coordinator.Dockerfile Show resolved Hide resolved

Update common/version/version.go

a7c8d25

Co-authored-by: HAOYUatHZ <[email protected]>

Lawliet-Chan requested a review from colinlyguo January 31, 2023 12:39

colinlyguo previously approved these changes Feb 1, 2023

View reviewed changes

Lawliet-Chan added 2 commits February 1, 2023 13:49

Merge branch 'staging' into dynamic_ffi

25a9b1f

bump version

5dd4356

Lawliet-Chan dismissed colinlyguo’s stale review via 5dd4356 February 1, 2023 05:50

colinlyguo reviewed Feb 1, 2023

View reviewed changes

coordinator/verifier/verifier_test.go Show resolved Hide resolved

colinlyguo previously approved these changes Feb 1, 2023

View reviewed changes

Merge branch 'staging' into dynamic_ffi

15bdd9a

0xmountaintop removed the breaking-change label Feb 2, 2023

0xmountaintop previously approved these changes Feb 2, 2023

View reviewed changes

bump version

165de69

Lawliet-Chan dismissed stale reviews from 0xmountaintop and colinlyguo via 165de69 February 2, 2023 07:14

0xmountaintop changed the title ~~feat(roller&coordinator): modify staticlib to dylib~~ feat(libzkp): use dylib instead of staticlib Feb 2, 2023

0xmountaintop approved these changes Feb 2, 2023

View reviewed changes

scroll-dev merged commit bb76a00 into staging Feb 2, 2023

scroll-dev deleted the dynamic_ffi branch February 2, 2023 07:25

feat(libzkp): use dylib instead of staticlib #266

feat(libzkp): use dylib instead of staticlib #266

Uh oh!

Conversation

Lawliet-Chan commented Jan 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChuhanJin commented Jan 28, 2023

Uh oh!

ChuhanJin commented Jan 28, 2023

Uh oh!

0xmountaintop commented Jan 29, 2023

Uh oh!

Lawliet-Chan commented Jan 29, 2023

Uh oh!

0xmountaintop commented Jan 29, 2023

Uh oh!

ChuhanJin commented Jan 29, 2023

Uh oh!

ChuhanJin commented Jan 29, 2023

Uh oh!

ChuhanJin commented Jan 31, 2023

Uh oh!

ChuhanJin commented Jan 31, 2023

Uh oh!

Uh oh!

Uh oh!

ChuhanJin commented Jan 31, 2023

Uh oh!

colinlyguo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ChuhanJin commented Feb 1, 2023

Uh oh!

ChuhanJin commented Feb 1, 2023

Uh oh!

Uh oh!

ChuhanJin commented Feb 2, 2023

Uh oh!

ChuhanJin commented Feb 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Lawliet-Chan commented Jan 28, 2023 •

edited

Loading

colinlyguo left a comment •

edited

Loading